Nicholas Shahan
8ff5176a77
Adding explicit source maps to the operator created a breakable location when viewing source-mapped dart code in chrome devtools. There isn't a breakable point in the javascript for a `!` operator so trying to enable the breakpoint visible in the dart code would trigger some "other breakpoint". Recent changes in the V8 debugger have changed which "other breakpoint" would be triggered. https://chromium.googlesource.com/v8/v8/+/16b0767adc54de6e0154a0a8226e01efecfdbfbb This causes our tests to fail and makes the user interaction a little confusing. Removing the extra source map here seems to be the most reasonable solution because it prevents a possible breakpoint from appearing where there isn't a breakable location. Now, the ! operator doesn't introduce any new source mapping it simply continues the previous mapping. Change-Id: I5903bfeaf1bcb2e2a3ce883433153575aa1fd05a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204742 Reviewed-by: Mark Zhou <markzipan@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>