Daco Harkes
4558112105
Rereland "[vm/ffi] Disallow Pointers and structs in finalizers and expandos"
...
`Dart_NewWeakPersistentHandle` and `Dart_NewFinalizableHandle` in
`dart_api.h` do no longer accept `Pointer`s and subtypes of `Struct`s
as values passed in to the `object` parameter.
Expandos no longer accept `Pointer`s and subtypes of `Struct`s
as values passed in to the `object` parameter.
Cleans up unused object_store->ffi_struct_class.
Reland 1: Allow importing `dart:ffi` from `dart:core` with
`--enable-ffi=false`.
Reland 2: Allow the new `_Compound` class to extend `NativeType`. (This
got triggered in this CL on the build because of the import
from `dart:core`.)
Closes: https://github.com/dart-lang/sdk/issues/45071
Breaking change: https://github.com/dart-lang/sdk/issues/45072
TEST=vm/cc/DartAPI_FinalizableHandleErrors
TEST=vm/cc/DartAPI_WeakPersistentHandleErrors
TEST=tests/ffi(_2)/expando_test.dart
Change-Id: I133278e16bd75cd2bb6234e7ddf042ffa0a54fd6
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try,dart-sdk-mac-try,dart-sdk-win-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-mac-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-win-release-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-msan-linux-release-x64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-precomp-android-release-arm_x64-try,analyzer-analysis-server-linux-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-linux-debug-x64c-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195079
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2021-04-14 12:07:18 +00:00
..
2020-04-27 21:04:56 +00:00
2020-04-14 19:25:45 +00:00
2020-03-16 20:51:26 +00:00
2021-04-13 02:36:16 +00:00
2020-04-16 09:20:21 +00:00
2020-04-16 09:20:21 +00:00
2021-04-13 02:36:16 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2020-05-09 00:22:16 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2020-07-27 16:44:15 +00:00
2020-04-30 02:33:53 +00:00
2020-04-30 02:33:53 +00:00
2020-04-30 02:33:53 +00:00
2020-04-30 02:33:53 +00:00
2020-04-30 02:33:53 +00:00
2020-05-01 17:02:23 +00:00
2020-05-01 17:02:23 +00:00
2019-12-02 23:13:10 +00:00
2020-04-17 08:45:46 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2020-03-11 23:31:06 +00:00
2021-02-25 21:18:02 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2020-03-24 17:34:25 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2020-09-26 01:11:54 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2019-12-02 23:13:10 +00:00
2020-06-22 10:29:15 +00:00
2020-07-21 10:00:41 +00:00
2020-05-05 09:57:23 +00:00
2020-04-02 18:25:29 +00:00
2020-05-05 09:57:23 +00:00
2020-05-27 14:59:39 +00:00
2019-12-02 23:19:10 +00:00
2021-04-14 12:07:18 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2020-03-17 13:43:17 +00:00
2020-03-27 19:02:52 +00:00
2020-04-07 20:09:26 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2020-03-17 13:43:17 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2020-01-03 17:32:29 +00:00
2019-12-02 23:19:10 +00:00
2020-04-06 19:17:54 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2020-04-06 19:17:54 +00:00
2020-03-24 17:34:25 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2020-04-06 19:17:54 +00:00
2020-04-01 00:03:46 +00:00
2020-04-01 00:03:46 +00:00
2020-04-01 00:03:46 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2020-02-03 19:06:17 +00:00
2020-02-03 19:06:17 +00:00
2021-01-28 17:19:35 +00:00
2020-02-03 19:06:17 +00:00
2019-12-02 23:19:10 +00:00
2020-03-24 17:34:25 +00:00
2019-12-02 23:19:10 +00:00
2019-12-02 23:19:10 +00:00
2020-01-09 17:11:46 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2020-11-05 19:46:35 +00:00
2020-11-05 19:46:35 +00:00
2020-03-30 19:58:08 +00:00
2019-12-10 01:17:24 +00:00
2020-01-09 17:11:46 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2019-12-10 01:17:24 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2020-03-31 18:14:45 +00:00
2020-03-30 19:58:08 +00:00
2020-03-30 19:58:08 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-05-04 08:14:43 +00:00
2019-12-10 01:17:24 +00:00
2020-07-09 01:37:23 +00:00
2020-03-31 18:14:45 +00:00
2020-05-04 08:14:43 +00:00
2019-12-10 01:17:24 +00:00
2020-03-30 19:58:08 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-07-15 00:45:43 +00:00
2020-03-30 19:58:08 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-01-09 17:11:46 +00:00
2019-12-10 01:17:24 +00:00
2021-04-08 16:51:00 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-03-20 17:58:22 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-03-11 23:31:06 +00:00
2019-12-10 01:17:24 +00:00
2020-03-24 08:21:36 +00:00
2020-04-16 09:20:21 +00:00
2019-12-10 01:17:24 +00:00
2020-03-24 17:34:25 +00:00
2020-01-09 17:11:46 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-07-21 10:00:41 +00:00
2020-01-09 17:11:46 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-03-24 08:21:36 +00:00
2019-12-10 01:17:24 +00:00
2019-12-10 01:17:24 +00:00
2020-04-16 09:20:21 +00:00
2020-03-30 19:58:08 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2020-11-05 14:26:53 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2020-11-25 12:01:44 +00:00
2020-06-30 17:14:14 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2020-03-24 08:21:36 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2020-12-10 11:00:27 +00:00
2019-12-17 23:06:24 +00:00
2020-12-10 11:00:27 +00:00
2019-12-17 23:06:24 +00:00
2020-04-06 19:17:54 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2021-03-22 13:20:13 +00:00
2019-12-17 23:06:24 +00:00
2020-03-27 15:59:27 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2020-03-30 19:58:08 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2021-02-05 23:53:28 +00:00
2020-03-30 19:58:08 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2020-03-25 17:32:02 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2020-01-18 02:55:28 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2020-04-16 09:20:21 +00:00
2020-04-16 09:20:21 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2020-02-26 21:32:51 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2021-03-09 17:15:00 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2021-01-11 15:22:06 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2019-12-17 23:06:24 +00:00
2021-02-05 18:31:48 +00:00