f891d8f664
Fixes: https://github.com/dart-lang/sdk/issues/63207 Change-Id: I9e62450ce01c9e38a923af639602007afb81e7ff Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/496540 Auto-Submit: FMorschel <git@fmorschel.dev> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
231 lines
4.4 KiB
Dart
231 lines
4.4 KiB
Dart
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:analyzer/src/diagnostic/diagnostic.dart' as diag;
|
|
import 'package:test_reflective_loader/test_reflective_loader.dart';
|
|
|
|
import '../rule_test_support.dart';
|
|
|
|
void main() {
|
|
defineReflectiveSuite(() {
|
|
defineReflectiveTests(SimplifyVariablePatternTest);
|
|
});
|
|
}
|
|
|
|
@reflectiveTest
|
|
class SimplifyVariablePatternTest extends LintRuleTest {
|
|
@override
|
|
String get lintRule => LintNames.simplify_variable_pattern;
|
|
|
|
Future<void> test_noPatternField() async {
|
|
await assertNoDiagnostics('''
|
|
void f(Object o) {
|
|
if (o case int i) {}
|
|
}
|
|
''');
|
|
}
|
|
|
|
Future<void> test_patternField_dynamic() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f(Object o) {
|
|
if (o case dynamic(isEven:var isEven)) {}
|
|
}
|
|
''',
|
|
[lint(40, 6)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_patternField_explicit() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f(Object o) {
|
|
if (o case int(isEven:var isEven)) {}
|
|
}
|
|
''',
|
|
[lint(36, 6)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_patternField_function() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f(Object o) {
|
|
if (o case Function(call:var call)) {}
|
|
}
|
|
''',
|
|
[lint(41, 4)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_patternField_implicit() async {
|
|
await assertNoDiagnostics('''
|
|
void f(Object o) {
|
|
if (o case int(:var isEven)) {}
|
|
}
|
|
''');
|
|
}
|
|
|
|
Future<void> test_patternField_otherName() async {
|
|
await assertNoDiagnostics('''
|
|
void f(Object o) {
|
|
if (o case int(isEven:var other)) {}
|
|
}
|
|
''');
|
|
}
|
|
|
|
Future<void> test_patternField_parenthesized() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f(Object o) {
|
|
if (o case int(isEven:((var isEven)))) {}
|
|
}
|
|
''',
|
|
[lint(36, 6)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_patternField_unnexistingProperty() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f(Object o) {
|
|
if (o case int(isEvenn:var isEvenn) when isEvenn) {}
|
|
}
|
|
''',
|
|
[error(diag.undefinedGetter, 36, 7)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_recordDestructuring() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f((int, {String name}) record) {
|
|
var (x, name: name) = record;
|
|
}
|
|
''',
|
|
[lint(48, 4)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_recordDestructuring_unnexistingField() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f((int, {String name}) record) {
|
|
var (x, namee: namee) = record;
|
|
print(namee);
|
|
}
|
|
''',
|
|
[error(diag.patternTypeMismatchInIrrefutableContext, 44, 17)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_typedef_if() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
typedef O = Object;
|
|
|
|
void f(Object o) {
|
|
if (o case O(hashCode: final hashCode)) {}
|
|
}
|
|
''',
|
|
[lint(55, 8)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_typedef_record() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
typedef R = ({int value});
|
|
|
|
void f(Object o) {
|
|
if (o case R(value: var value)) {}
|
|
}
|
|
''',
|
|
[lint(62, 5)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_typedef_typeParameter() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
typedef O<T extends Object> = T;
|
|
void f(O o) {
|
|
if (o case O(hashCode: var hashCode)) {}
|
|
}
|
|
''',
|
|
[lint(62, 8)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_typedef_variableDeclaration() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
typedef O = Object;
|
|
|
|
void f(Object o) {
|
|
final O(hashCode: hashCode) = o;
|
|
}
|
|
''',
|
|
[lint(50, 8)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_typeParameter() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f<T extends Object>(T o) {
|
|
if (o case T(hashCode: var hashCode)) {}
|
|
}
|
|
''',
|
|
[lint(47, 8)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_typeParameter_functionType() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f<F extends void Function()>(F o) {
|
|
if (o case F(call: var call)) {}
|
|
}
|
|
''',
|
|
[lint(56, 4)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_typeParameter_record() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f<R extends ({int value})>(R o) {
|
|
if (o case R(value: var value)) {}
|
|
}
|
|
''',
|
|
[lint(54, 5)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_typeParameter_typedef_record() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f<T extends R>(T o) {
|
|
if (o case T(value: var value)) {}
|
|
}
|
|
|
|
typedef R = ({int value});
|
|
''',
|
|
[lint(42, 5)],
|
|
);
|
|
}
|
|
|
|
Future<void> test_typeParameter_typeParameterBounded() async {
|
|
await assertDiagnostics(
|
|
'''
|
|
void f<T extends Object, O extends T>(O o) {
|
|
if (o case O(hashCode: var hashCode)) {}
|
|
}
|
|
''',
|
|
[lint(60, 8)],
|
|
);
|
|
}
|
|
}
|