As far as I can tell, the ConvertFieldFormalToNormal assist does
everything ConvertToNormalParameter does but better. They both operate
on a field formal and convert it to a normal parameter by removing the
"this." and adding an explicit initializer. But
ConvertToNormalParameter:
- Doesn't support private named parameters.
- Removes a "dynamic" type annotation from the parameter, for no clear
reason.
- Fails to add a type annotation for the parameter if the field is
typed dynamic. (That does the right thing relying on implicit dynamic
hasn't been idiomatic Dart in many years.)
reason.
I can't find any reason for ConvertToNormalParameter to exist.
Change-Id: I05de4d3d213fd061f408ed22c4447d75124aef10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/479082
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Robert Nystrom
3a55003099