Martin Kustermann
407afe84ca
This reduces acx main: module -0.35%, global section: -2.3% Previous change in [0] made dynamic call sites have per-caller-shape dynamic forwarders. In this change we utilize this: Since we know the dynamic caller shape we can make the dynamic forwarder call via a closure representation that matches this caller shape (modulo the type arguments - as a dynamic call without type arguments may get default type arguments of unknown count). => This means we no longer have to pass types, positionals and named arguments as wasm arrays to dynamic call forwarder. Instead we can pass the arguments unpacked to the vtable. Additionally we change `Function.apply`: If we know there's no `Function.apply` usage with named arguments, we can enumerate all possible closure representations and call the corresponding vtable entry. We use 2 `br_table` instructions for this: * branch on number of type parameters * branch on number of positional parameters Together these two changes means that neither dynamic forwarders nor `Function.apply` will use the dynamic call entry. => We remove the dynamic call entry from the vtable construction The only exception to the above are: * If dynamic submodules is enabled we don't compute closed world information about closures and always call via dynamic call entry * If `Function.apply` is used with named arguments then call via dynamic call entry (and make vtables have it). [0] https://dart-review.googlesource.com/c/sdk/+/461720 Issue https://github.com/dart-lang/sdk/issues/60458 Change-Id: I26e6a2a48ee37616061d701dc4d4327c2e109e82 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/462060 Reviewed-by: Ömer Ağacan <omersa@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.