Samir Jindel
663a8630e6
This reverts commit bab592fd28.
Reason for revert: Breaks SIMARM_X64 build and crashes in hot-reload.
Original change's description:
> [vm/ffi] Dispatch native callbacks through trampolines if we can't ensure callbacks will always be executable.
>
> Issue https://github.com/dart-lang/sdk/issues/37629
>
> Change-Id: Ib61c32bde5a8b38d90b4da77e27e3874b8bfb7e2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111432
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
TBR=kustermann@google.com,alexmarkov@google.com,sjindel@google.com
Change-Id: Id7dc3068a97debc7a8f757df31ef33fb68bdcb44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113827
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
67 lines
2.5 KiB
C++
67 lines
2.5 KiB
C++
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_VM_STACK_FRAME_X64_H_
|
|
#define RUNTIME_VM_STACK_FRAME_X64_H_
|
|
|
|
#include "vm/constants_x64.h"
|
|
|
|
namespace dart {
|
|
|
|
/* X64 Dart Frame Layout
|
|
|
|
| | <- TOS
|
|
Callee frame | ... |
|
|
| saved PP |
|
|
| code object |
|
|
| saved RBP | (RBP of current frame)
|
|
| saved PC | (PC of current frame)
|
|
+--------------------+
|
|
Current frame | ... T| <- RSP of current frame
|
|
| first local T|
|
|
| caller's PP T|
|
|
| code object T| (current frame's code object)
|
|
| caller's RBP | <- RBP of current frame
|
|
| caller's ret addr | (PC of caller frame)
|
|
+--------------------+
|
|
Caller frame | last parameter | <- RSP of caller frame
|
|
| ... |
|
|
|
|
T against a slot indicates it needs to be traversed during GC.
|
|
*/
|
|
|
|
static const int kDartFrameFixedSize = 4; // PC marker, RBP, PP, PC.
|
|
static const int kSavedPcSlotFromSp = -1;
|
|
|
|
static const int kFirstObjectSlotFromFp = -1; // Used by GC to traverse stack.
|
|
static const int kLastFixedObjectSlotFromFp = -2;
|
|
|
|
static const int kFirstLocalSlotFromFp = -3;
|
|
static const int kSavedCallerPpSlotFromFp = -2;
|
|
static const int kPcMarkerSlotFromFp = -1;
|
|
static const int kSavedCallerFpSlotFromFp = 0;
|
|
static const int kSavedCallerPcSlotFromFp = 1;
|
|
|
|
static const int kParamEndSlotFromFp = 1; // One slot past last parameter.
|
|
static const int kCallerSpSlotFromFp = 2;
|
|
static const int kLastParamSlotFromEntrySp = 1; // Skip return address.
|
|
|
|
// Entry and exit frame layout.
|
|
#if defined(_WIN64)
|
|
static const int kExitLinkSlotFromEntryFp = -32;
|
|
#else
|
|
static const int kExitLinkSlotFromEntryFp = -10;
|
|
#endif // defined(_WIN64)
|
|
|
|
// For FFI native -> Dart callbacks, the number of stack slots between arguments
|
|
// passed on stack and arguments saved in callback prologue. 2 = return adddress
|
|
// (1) + saved frame pointer (1). Also add slots for the shadow space, if
|
|
// present.
|
|
constexpr intptr_t kCallbackSlotsBeforeSavedArguments =
|
|
2 + CallingConventions::kShadowSpaceBytes / kWordSize;
|
|
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_VM_STACK_FRAME_X64_H_
|