Robert Nystrom
f9f005cdb9
Change-Id: Ie1faacd66448efe209b35dfd66fded622e59812a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110766 Auto-Submit: Bob Nystrom <rnystrom@google.com> Commit-Queue: Bob Nystrom <rnystrom@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com>
430 lines
13 KiB
Dart
430 lines
13 KiB
Dart
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:expect/expect.dart';
|
|
|
|
import 'package:test_runner/src/test_file.dart';
|
|
|
|
void main() {
|
|
testFlags();
|
|
testCompareTo();
|
|
testDescribeDifferences();
|
|
testSimplify();
|
|
}
|
|
|
|
void testFlags() {
|
|
var unspecified = StaticError(
|
|
line: 1,
|
|
column: 2,
|
|
length: 3,
|
|
code: "unspecified",
|
|
message: "unspecified");
|
|
var unspecifiedAnalyzer =
|
|
StaticError(line: 1, column: 2, length: 3, code: "unspecified");
|
|
var unspecifiedCfe =
|
|
StaticError(line: 1, column: 2, length: 3, message: "unspecified");
|
|
var noLength = StaticError(line: 1, column: 2, code: "E.CODE");
|
|
var analyzer = StaticError(line: 1, column: 2, length: 3, code: "E.CODE");
|
|
var cfe = StaticError(line: 1, column: 2, length: 3, message: "E.");
|
|
var both =
|
|
StaticError(line: 1, column: 2, length: 3, code: "E.CODE", message: "E.");
|
|
|
|
// isAnalyzer.
|
|
Expect.isTrue(unspecified.isAnalyzer);
|
|
Expect.isTrue(unspecifiedAnalyzer.isAnalyzer);
|
|
Expect.isFalse(unspecifiedCfe.isAnalyzer);
|
|
Expect.isTrue(noLength.isAnalyzer);
|
|
Expect.isTrue(analyzer.isAnalyzer);
|
|
Expect.isFalse(cfe.isAnalyzer);
|
|
Expect.isTrue(both.isAnalyzer);
|
|
|
|
// isCfe.
|
|
Expect.isTrue(unspecified.isCfe);
|
|
Expect.isFalse(unspecifiedAnalyzer.isCfe);
|
|
Expect.isTrue(unspecifiedCfe.isCfe);
|
|
Expect.isFalse(noLength.isCfe);
|
|
Expect.isFalse(analyzer.isCfe);
|
|
Expect.isTrue(cfe.isCfe);
|
|
Expect.isTrue(both.isCfe);
|
|
}
|
|
|
|
void testCompareTo() {
|
|
var errors = [
|
|
// Order by line.
|
|
StaticError(line: 1, column: 2, length: 2, code: "E.CODE", message: "E."),
|
|
StaticError(line: 2, column: 1, length: 1, code: "E.CODE", message: "E."),
|
|
|
|
// Then column.
|
|
StaticError(line: 3, column: 1, length: 2, code: "E.CODE", message: "E."),
|
|
StaticError(
|
|
line: 3, column: 2, length: 1, code: "Error.CODE", message: "E."),
|
|
|
|
// Then length.
|
|
StaticError(line: 4, column: 1, length: 1, code: "Z.CODE", message: "Z."),
|
|
StaticError(line: 4, column: 1, length: 2, code: "A.CODE", message: "A."),
|
|
|
|
// Then code.
|
|
StaticError(line: 5, column: 1, length: 1, message: "Z."),
|
|
StaticError(line: 5, column: 1, length: 1, code: "A.CODE", message: "Z."),
|
|
StaticError(line: 5, column: 1, length: 1, code: "Z.CODE", message: "Z."),
|
|
|
|
// Then message.
|
|
StaticError(line: 6, column: 1, length: 1, code: "E.CODE"),
|
|
StaticError(line: 6, column: 1, length: 1, code: "E.CODE", message: "A."),
|
|
StaticError(line: 6, column: 1, length: 1, code: "E.CODE", message: "Z."),
|
|
];
|
|
|
|
// Every pair of errors in the array should be ordered correctly.
|
|
for (var i = 0; i < errors.length; i++) {
|
|
for (var j = 0; j < errors.length; j++) {
|
|
var expected = (i - j).sign;
|
|
Expect.equals(expected, errors[i].compareTo(errors[j]),
|
|
"Expected $expected comparison for:\n${errors[i]}\n${errors[j]}");
|
|
}
|
|
}
|
|
}
|
|
|
|
void testDescribeDifferences() {
|
|
var precise = StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Error message.");
|
|
|
|
// Perfect match.
|
|
expectNoDifferences(
|
|
precise,
|
|
StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Error message."));
|
|
|
|
// Ignore null code.
|
|
expectNoDifferences(
|
|
StaticError(line: 2, column: 3, length: 4, message: "Error message."),
|
|
StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Error message."));
|
|
expectNoDifferences(
|
|
StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Error message."),
|
|
StaticError(line: 2, column: 3, length: 4, message: "Error message."));
|
|
|
|
// Ignore null message.
|
|
expectNoDifferences(
|
|
StaticError(line: 2, column: 3, length: 4, code: "Error.CODE"),
|
|
StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Error message."));
|
|
expectNoDifferences(
|
|
StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Error message."),
|
|
StaticError(line: 2, column: 3, length: 4, code: "Error.CODE"));
|
|
|
|
// Different line.
|
|
expectDifferences(
|
|
precise,
|
|
StaticError(
|
|
line: 4,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Error message."),
|
|
"""
|
|
Expected on line 2 but was on 4.
|
|
""");
|
|
|
|
// Different column.
|
|
expectDifferences(
|
|
precise,
|
|
StaticError(
|
|
line: 2,
|
|
column: 5,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Error message."),
|
|
"""
|
|
Expected on column 3 but was on 5.
|
|
""");
|
|
|
|
// Different length.
|
|
expectDifferences(
|
|
precise,
|
|
StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 6,
|
|
code: "Error.CODE",
|
|
message: "Error message."),
|
|
"""
|
|
Expected length 4 but was 6.
|
|
""");
|
|
|
|
// Different code.
|
|
expectDifferences(
|
|
precise,
|
|
StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Weird.ERROR",
|
|
message: "Error message."),
|
|
"""
|
|
Expected error code Error.CODE but was Weird.ERROR.
|
|
""");
|
|
|
|
// Different message.
|
|
expectDifferences(
|
|
precise,
|
|
StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Funny story."),
|
|
"""
|
|
Expected error message 'Error message.' but was 'Funny story.'.
|
|
""");
|
|
|
|
// Multiple differences.
|
|
expectDifferences(
|
|
precise,
|
|
StaticError(
|
|
line: 4,
|
|
column: 3,
|
|
length: 6,
|
|
code: "Weird.ERROR",
|
|
message: "Error message."),
|
|
"""
|
|
Expected on line 2 but was on 4.
|
|
Expected length 4 but was 6.
|
|
Expected error code Error.CODE but was Weird.ERROR.
|
|
""");
|
|
|
|
// Unspecified errors.
|
|
var unspecified = StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "unspecified",
|
|
message: "unspecified");
|
|
var specifiedAnalyzer = StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "unspecified");
|
|
var specifiedCfe = StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "unspecified",
|
|
message: "Error message.");
|
|
|
|
// Matches if line is right.
|
|
expectNoDifferences(
|
|
unspecified,
|
|
StaticError(
|
|
line: 2,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Error.CODE",
|
|
message: "Error message."));
|
|
|
|
// Does not match if lines differ.
|
|
expectDifferences(
|
|
unspecified,
|
|
StaticError(
|
|
line: 3,
|
|
column: 3,
|
|
length: 4,
|
|
code: "Weird.ERROR",
|
|
message: "Error message."),
|
|
"""
|
|
Expected on line 2 but was on 3.
|
|
""");
|
|
|
|
// Ignores differences in other fields.
|
|
expectNoDifferences(
|
|
unspecified,
|
|
StaticError(
|
|
line: 2,
|
|
column: 333,
|
|
length: 4444,
|
|
code: "Different.CODE",
|
|
message: "Different message."));
|
|
|
|
// If error is specified on analyzer, must match fields when actual is
|
|
// analyzer error.
|
|
expectDifferences(specifiedAnalyzer,
|
|
StaticError(line: 2, column: 5, length: 6, code: "Weird.ERROR"), """
|
|
Expected on column 3 but was on 5.
|
|
Expected length 4 but was 6.
|
|
Expected error code Error.CODE but was Weird.ERROR.
|
|
""");
|
|
expectNoDifferences(specifiedAnalyzer,
|
|
StaticError(line: 2, column: 333, length: 444, message: "Message."));
|
|
expectNoDifferences(specifiedAnalyzer,
|
|
StaticError(line: 2, column: 3, length: 4, code: "Error.CODE"));
|
|
|
|
// If error is specified on CFE, must match fields when actual is
|
|
// CFE error.
|
|
expectDifferences(
|
|
specifiedCfe,
|
|
StaticError(line: 2, column: 5, length: 6, message: "Different message."),
|
|
"""
|
|
Expected on column 3 but was on 5.
|
|
Expected length 4 but was 6.
|
|
Expected error message 'Error message.' but was 'Different message.'.
|
|
""");
|
|
expectNoDifferences(specifiedCfe,
|
|
StaticError(line: 2, column: 333, length: 444, code: "Error.CODE."));
|
|
expectNoDifferences(specifiedCfe,
|
|
StaticError(line: 2, column: 3, length: 4, message: "Error message."));
|
|
}
|
|
|
|
void testSimplify() {
|
|
// Merges errors if one has only a code and the only a message.
|
|
expectSimplify([
|
|
StaticError(line: 1, column: 2, length: 3, code: "Weird.ERROR"),
|
|
StaticError(line: 1, column: 2, length: 3, message: "Message.")
|
|
], [
|
|
StaticError(
|
|
line: 1, column: 2, length: 3, code: "Weird.ERROR", message: "Message.")
|
|
]);
|
|
|
|
// Merges if length is null.
|
|
expectSimplify([
|
|
StaticError(line: 1, column: 1, code: "A.ERR"),
|
|
StaticError(line: 1, column: 1, length: 3, message: "A."),
|
|
StaticError(line: 2, column: 1, length: 4, code: "B.ERR"),
|
|
StaticError(line: 2, column: 1, message: "B."),
|
|
StaticError(line: 3, column: 1, code: "C.ERR"),
|
|
StaticError(line: 3, column: 1, message: "C."),
|
|
], [
|
|
StaticError(line: 1, column: 1, length: 3, code: "A.ERR", message: "A."),
|
|
StaticError(line: 2, column: 1, length: 4, code: "B.ERR", message: "B."),
|
|
StaticError(line: 3, column: 1, code: "C.ERR", message: "C."),
|
|
]);
|
|
|
|
// Merges multiple errors with no length with errors that have length.
|
|
expectSimplify([
|
|
StaticError(line: 1, column: 2, length: 3, code: "ERROR.A"),
|
|
StaticError(line: 1, column: 4, length: 3, code: "ERROR.C"),
|
|
StaticError(line: 1, column: 2, length: 5, code: "ERROR.B"),
|
|
StaticError(line: 1, column: 2, message: "One."),
|
|
StaticError(line: 1, column: 4, message: "Three."),
|
|
StaticError(line: 1, column: 2, message: "Two."),
|
|
], [
|
|
StaticError(
|
|
line: 1, column: 2, length: 3, code: "ERROR.A", message: "One."),
|
|
StaticError(
|
|
line: 1, column: 2, length: 5, code: "ERROR.B", message: "Two."),
|
|
StaticError(
|
|
line: 1, column: 4, length: 3, code: "ERROR.C", message: "Three."),
|
|
]);
|
|
|
|
// Merges even if not adjacent in input array.
|
|
expectSimplify([
|
|
StaticError(line: 1, column: 2, length: 3, code: "Some.ERROR"),
|
|
StaticError(line: 10, column: 2, length: 3, code: "Other.ERROR"),
|
|
StaticError(line: 1, column: 2, length: 3, message: "Message.")
|
|
], [
|
|
StaticError(
|
|
line: 1, column: 2, length: 3, code: "Some.ERROR", message: "Message."),
|
|
StaticError(line: 10, column: 2, length: 3, code: "Other.ERROR")
|
|
]);
|
|
|
|
// Does not merge if positions differ.
|
|
expectSimplify([
|
|
StaticError(line: 1, column: 1, length: 1, code: "A.ERR"),
|
|
StaticError(line: 2, column: 1, length: 1, message: "A."),
|
|
], [
|
|
StaticError(line: 1, column: 1, length: 1, code: "A.ERR"),
|
|
StaticError(line: 2, column: 1, length: 1, message: "A."),
|
|
]);
|
|
expectSimplify([
|
|
StaticError(line: 1, column: 1, length: 1, code: "A.ERR"),
|
|
StaticError(line: 1, column: 2, length: 1, message: "A."),
|
|
], [
|
|
StaticError(line: 1, column: 1, length: 1, code: "A.ERR"),
|
|
StaticError(line: 1, column: 2, length: 1, message: "A."),
|
|
]);
|
|
expectSimplify([
|
|
StaticError(line: 1, column: 1, length: 1, code: "A.ERR"),
|
|
StaticError(line: 1, column: 1, length: 2, message: "A."),
|
|
], [
|
|
StaticError(line: 1, column: 1, length: 1, code: "A.ERR"),
|
|
StaticError(line: 1, column: 1, length: 2, message: "A."),
|
|
]);
|
|
|
|
// Does not merge if it would lose code or message.
|
|
expectSimplify([
|
|
StaticError(line: 1, column: 1, length: 1, code: "ERR.ONE"),
|
|
StaticError(line: 1, column: 1, length: 1, code: "ERR.TWO"),
|
|
StaticError(line: 2, column: 1, length: 1, message: "One."),
|
|
StaticError(line: 2, column: 1, length: 1, message: "Two."),
|
|
], [
|
|
StaticError(line: 1, column: 1, length: 1, code: "ERR.ONE"),
|
|
StaticError(line: 1, column: 1, length: 1, code: "ERR.TWO"),
|
|
StaticError(line: 2, column: 1, length: 1, message: "One."),
|
|
StaticError(line: 2, column: 1, length: 1, message: "Two."),
|
|
]);
|
|
|
|
// Orders output.
|
|
expectSimplify([
|
|
StaticError(line: 2, column: 1, length: 1, message: "Two."),
|
|
StaticError(line: 3, column: 1, length: 1, message: "Three."),
|
|
StaticError(line: 1, column: 1, length: 1, message: "One."),
|
|
], [
|
|
StaticError(line: 1, column: 1, length: 1, message: "One."),
|
|
StaticError(line: 2, column: 1, length: 1, message: "Two."),
|
|
StaticError(line: 3, column: 1, length: 1, message: "Three."),
|
|
]);
|
|
}
|
|
|
|
void expectNoDifferences(StaticError expectedError, StaticError actualError) {
|
|
var actualLines = expectedError.describeDifferences(actualError);
|
|
if (actualLines != null) {
|
|
Expect.fail("Expected no differences, but got:\n${actualLines.join('\n')}");
|
|
}
|
|
}
|
|
|
|
void expectDifferences(StaticError expectedError, StaticError actualError,
|
|
String expectedDifferences) {
|
|
var expectedLines = expectedDifferences
|
|
.split("\n")
|
|
.map((line) => line.trim())
|
|
.where((line) => line.isNotEmpty)
|
|
.toList();
|
|
var actualLines = expectedError.describeDifferences(actualError);
|
|
if (actualLines == null) {
|
|
Expect.fail("Got no differences, but expected:\n$expectedDifferences");
|
|
}
|
|
Expect.listEquals(expectedLines, actualLines);
|
|
}
|
|
|
|
void expectSimplify(List<StaticError> input, List<StaticError> expected) {
|
|
var actual = StaticError.simplify(input);
|
|
Expect.listEquals(expected.map((error) => error.toString()).toList(),
|
|
actual.map((error) => error.toString()).toList());
|
|
}
|