Paul Berry
3eb697c0af
An `await` expression or `yield` statement suspends the current function and allows other code in the same isolate to execute. In the case of nested functions, an `await` or `yield` in the inner function can allow the outer function to continue executing. That means that if the inner function promotes a local variable belonging to the outer function, then it isn't sound to carry that promotion past an `await` or `yield`. This change fixes the unsoundness by adding a flow analysis method `suspension`, which the shared type analysis logic uses to tell flow analysis that an `await` or `yield` has been found. The `suspension` method un-does the promotions of any variables that might be written to while the inner function is suspended. Fixes https://github.com/dart-lang/sdk/issues/62889. Change-Id: I77eaf997159819a7c50f44b67174d2aa6a6a6964 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499382 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.