Alexander Thomas
15d7023b60
This fixes an issue introduced when DDS testing support was added to the test suite. Previously, tests with multiple VMOptions lines would get the same name for both DDS and service variants. This caused incorrect behavior in the results processing that broke deflaking, but also caused one of the results to be ignored by the infrastructure. Also adds some tests for VMOptions handling in test_suite.dart. Fixes https://github.com/dart-lang/sdk/issues/43768 Change-Id: I3c0f9cbc1807fe814aed5ecb7531ef4289e95683 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166858 Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
53 lines
1.9 KiB
Dart
53 lines
1.9 KiB
Dart
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
import 'package:test_runner/src/configuration.dart';
|
|
import 'package:test_runner/src/options.dart';
|
|
import 'package:test_runner/src/path.dart';
|
|
import 'package:test_runner/src/static_error.dart';
|
|
import 'package:test_runner/src/test_file.dart';
|
|
import 'package:test_runner/src/test_suite.dart';
|
|
|
|
TestFile parseTestFile(String source,
|
|
{String path = "some_test.dart", String suite = "language"}) {
|
|
final suiteDirectory = Path(suite);
|
|
path = suiteDirectory.absolute.append(path).toNativePath();
|
|
return TestFile.parse(suiteDirectory.absolute, path, source);
|
|
}
|
|
|
|
// TODO(rnystrom): Would be nice if there was a simpler way to create a
|
|
// configuration for use in unit tests.
|
|
TestConfiguration makeConfiguration(List<String> arguments, String suite) {
|
|
return OptionsParser().parse([...arguments, suite]).first;
|
|
}
|
|
|
|
/// Creates a [StandardTestSuite] hardcoded to contain [testFiles].
|
|
StandardTestSuite makeTestSuite(TestConfiguration configuration,
|
|
List<TestFile> testFiles, String suite) =>
|
|
_MockTestSuite(configuration, testFiles, suite);
|
|
|
|
StaticError makeError(
|
|
{int line = 1,
|
|
int column = 2,
|
|
int length,
|
|
String analyzerError,
|
|
String cfeError,
|
|
String webError}) {
|
|
var errors = {
|
|
if (analyzerError != null) ErrorSource.analyzer: analyzerError,
|
|
if (cfeError != null) ErrorSource.cfe: cfeError,
|
|
if (webError != null) ErrorSource.web: webError,
|
|
};
|
|
return StaticError(errors, line: line, column: column, length: length);
|
|
}
|
|
|
|
class _MockTestSuite extends StandardTestSuite {
|
|
final List<TestFile> _testFiles;
|
|
|
|
_MockTestSuite(TestConfiguration configuration, this._testFiles, String suite)
|
|
: super(configuration, suite, Path(suite), []);
|
|
|
|
@override
|
|
Iterable<TestFile> findTests() => _testFiles;
|
|
}
|