Jens Johansen b5da327ed9 [parser] Parse and skip metadata according to spec ...

Make the parser handle metadata properly according to the spec.

There has been some confusion in regards to metadata because
https://github.com/dart-lang/language/blob/master/accepted/future-releases/small-features-21Q1/feature-specification.md
(used to) say we needed a spec update.

That was done in the parser in
https://dart-review.googlesource.com/c/sdk/+/182668
but really that made the parser adhere to the spec as it was which is
also correct (as the spec change wasn't needed at all).

The parser also needs to be able to skip metadata, though, and that
wasn't done it that CL which caused the issues in
https://github.com/dart-lang/sdk/issues/45120

The work directly in this CL is:
* Add lots of comments to parseMetadata to make them more up-to-date with
  the spec.
* Fix skipMetadata to correspond to parseMetadata.
* Tests verifying that 45120 is fixed in the parser and that metadata in
  general works as expected in the parser.

(In working on this, the future specification was corrected to say that the
spec did not need updating. Thanks to Erik for the quick turn-around
there).

Bug: #45120
Change-Id: Id1e4912cac7e5d9113efe083b3ecd06e6834a16e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190880
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>

2021-03-15 08:40:40 +00:00

..

ambiguous_builder_01.dart

[cfe] Handle ProblemBuilder in binary expression

2020-05-12 11:44:19 +00:00

ambiguous_builder_01.dart.expect

[cfe,analyzer] Pass message arguments directly to AnalysisError

2021-01-11 16:45:26 +00:00

ambiguous_builder_01.dart.intertwined.expect

[cfe,analyzer] Pass message arguments directly to AnalysisError

2021-01-11 16:45:26 +00:00

ambiguous_builder_01.dart.parser.expect

[cfe] Handle ProblemBuilder in binary expression

2020-05-12 11:44:19 +00:00

ambiguous_builder_01.dart.scanner.expect

[cfe] Handle ProblemBuilder in binary expression

2020-05-12 11:44:19 +00:00

assignment.dart

[cfe] Handle setter import conflicts

2019-12-16 12:02:47 +00:00

assignment.dart.expect

[cfe] Handle setter import conflicts

2019-12-16 12:02:47 +00:00

assignment.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

assignment.dart.parser.expect

[cfe] Handle setter import conflicts

2019-12-16 12:02:47 +00:00

assignment.dart.scanner.expect

[cfe] Handle setter import conflicts

2019-12-16 12:02:47 +00:00

built_in_identifier_class_fields.dart

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_class_fields.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

built_in_identifier_class_fields.dart.intertwined.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

built_in_identifier_class_fields.dart.parser.expect

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_class_fields.dart.scanner.expect

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_class_methods.dart

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_class_methods.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

built_in_identifier_class_methods.dart.intertwined.expect

[parser] Change recovery of multiple extends with comma

2020-08-13 08:49:53 +00:00

built_in_identifier_class_methods.dart.parser.expect

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_class_methods.dart.scanner.expect

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_top_level_fields.dart

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_top_level_fields.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

built_in_identifier_top_level_fields.dart.intertwined.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

built_in_identifier_top_level_fields.dart.parser.expect

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_top_level_fields.dart.scanner.expect

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_top_level_methods.dart

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_top_level_methods.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

built_in_identifier_top_level_methods.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

built_in_identifier_top_level_methods.dart.parser.expect

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

built_in_identifier_top_level_methods.dart.scanner.expect

[parser] Tests of using build in identifier and reserved keywords as method/field names

2020-05-01 07:40:46 +00:00

chained_call_01.dart

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_01.dart.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_01.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

chained_call_01.dart.parser.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_01.dart.scanner.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_02.dart

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_02.dart.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_02.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

chained_call_02.dart.parser.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_02.dart.scanner.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_03.dart

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_03.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

chained_call_03.dart.intertwined.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

chained_call_03.dart.parser.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_03.dart.scanner.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_04.dart

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_04.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

chained_call_04.dart.intertwined.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

chained_call_04.dart.parser.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_04.dart.scanner.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_05.dart

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_05.dart.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_05.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

chained_call_05.dart.parser.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_05.dart.scanner.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_06.dart

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_06.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

chained_call_06.dart.intertwined.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

chained_call_06.dart.parser.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_06.dart.scanner.expect

[parser] Parse chained calls with type arguments correctly

2020-03-02 10:28:47 +00:00

chained_call_07.dart

[parser] Parse bangs before type parameters correctly

2020-03-02 11:21:40 +00:00

chained_call_07.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

chained_call_07.dart.intertwined.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

chained_call_07.dart.parser.expect

[parser] Parse bangs before type parameters correctly

2020-03-02 11:21:40 +00:00

chained_call_07.dart.scanner.expect

[parser] Parse bangs before type parameters correctly

2020-03-02 11:21:40 +00:00

for_in_no_decl.dart

[cfe] Handle assigned variables in for and for-in

2019-10-31 11:36:43 +00:00

for_in_no_decl.dart.expect

[cfe] Use variable name in error message for missing initializer

2020-07-08 12:45:15 +00:00

for_in_no_decl.dart.intertwined.expect

[cfe] Use variable name in error message for missing initializer

2020-07-08 12:45:15 +00:00

for_in_no_decl.dart.parser.expect

[parser] New syntax for null aware index (2nd try)

2020-02-26 13:31:52 +00:00

for_in_no_decl.dart.scanner.expect

[cfe] Handle assigned variables in for and for-in

2019-10-31 11:36:43 +00:00

for_in.dart

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

for_in.dart.expect

[cfe] Use variable name in error message for missing initializer

2020-07-08 12:45:15 +00:00

for_in.dart.intertwined.expect

[cfe] Use variable name in error message for missing initializer

2020-07-08 12:45:15 +00:00

for_in.dart.parser.expect

[parser] New syntax for null aware index (2nd try)

2020-02-26 13:31:52 +00:00

for_in.dart.scanner.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

for_no_decl.dart

[cfe] Handle assigned variables in for and for-in

2019-10-31 11:36:43 +00:00

for_no_decl.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

for_no_decl.dart.intertwined.expect

[cfe] Use variable name in error message for missing initializer

2020-07-08 12:45:15 +00:00

for_no_decl.dart.parser.expect

[cfe] Handle assigned variables in for and for-in

2019-10-31 11:36:43 +00:00

for_no_decl.dart.scanner.expect

[cfe] Handle assigned variables in for and for-in

2019-10-31 11:36:43 +00:00

for.dart

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

for.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

for.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

for.dart.parser.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

for.dart.scanner.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

function_declaration.dart

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

function_declaration.dart.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

function_declaration.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

function_declaration.dart.parser.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

function_declaration.dart.scanner.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

function_expression.dart

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

function_expression.dart.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

function_expression.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

function_expression.dart.parser.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

function_expression.dart.scanner.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

generic_function_typedef.dart

[cfe] Fix scope setup for generic function types

2020-07-29 09:04:24 +00:00

generic_function_typedef.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

generic_function_typedef.dart.intertwined.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

generic_function_typedef.dart.parser.expect

[cfe] Fix scope setup for generic function types

2020-07-29 09:04:24 +00:00

generic_function_typedef.dart.scanner.expect

[cfe] Fix scope setup for generic function types

2020-07-29 09:04:24 +00:00

issue_41121.dart

[parser] Change recovery for constructor; report errors in bad constructors

2020-03-27 11:57:56 +00:00

issue_41121.dart.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

issue_41121.dart.intertwined.expect

[parser] Make begin/end events always come in pairs

2020-09-01 09:30:43 +00:00

issue_41121.dart.parser.expect

[parser] Change recovery for constructor; report errors in bad constructors

2020-03-27 11:57:56 +00:00

issue_41121.dart.scanner.expect

[parser] Change recovery for constructor; report errors in bad constructors

2020-03-27 11:57:56 +00:00

issue_45120.dart

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

issue_45120.dart.expect

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

issue_45120.dart.intertwined.expect

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

issue_45120.dart.parser.expect

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

issue_45120.dart.scanner.expect

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

metadata.dart

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

metadata.dart.expect

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

metadata.dart.intertwined.expect

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

metadata.dart.parser.expect

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

metadata.dart.scanner.expect

[parser] Parse and skip metadata according to spec

2021-03-15 08:40:40 +00:00

missing_end_bracket.dart

…

missing_end_bracket.dart.expect

[cfe,analyzer] Pass message arguments directly to AnalysisError

2021-01-11 16:45:26 +00:00

missing_end_bracket.dart.intertwined.expect

[cfe,analyzer] Pass message arguments directly to AnalysisError

2021-01-11 16:45:26 +00:00

missing_end_bracket.dart.parser.expect

…

missing_end_bracket.dart.scanner.expect

…

operator_hat_class.crash_dart

[parser] Reproduce analyser crash _OperatorName in endClassConstructor

2019-10-28 14:00:37 +00:00

operator_hat_class.crash_dart.expect

[cfe,analyzer] Pass message arguments directly to AnalysisError

2021-01-11 16:45:26 +00:00

operator_hat_class.crash_dart.intertwined.expect

[cfe,analyzer] Pass message arguments directly to AnalysisError

2021-01-11 16:45:26 +00:00

operator_hat_class.crash_dart.parser.expect

[parser] Reproduce analyser crash _OperatorName in endClassConstructor

2019-10-28 14:00:37 +00:00

operator_hat_class.crash_dart.scanner.expect

[parser] Reproduce analyser crash _OperatorName in endClassConstructor

2019-10-28 14:00:37 +00:00

try_catch.dart

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

try_catch.dart.expect

[cfe] Add BlockKind to parse/begin/endBlock

2019-10-29 09:17:06 +00:00

try_catch.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

try_catch.dart.parser.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

try_catch.dart.scanner.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

try_finally.dart

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

try_finally.dart.expect

[cfe] Add BlockKind to parse/begin/endBlock

2019-10-29 09:17:06 +00:00

try_finally.dart.intertwined.expect

[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void'

2020-05-06 11:56:24 +00:00

try_finally.dart.parser.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00

try_finally.dart.scanner.expect

[cfe] Compute AssignedVariables in body builder

2019-10-29 09:17:06 +00:00