Lasse Reichstein Holst Nielsen
81c3e8cbb4
Address comments from https://dart-review.googlesource.com/c/sdk/+/174471
...
* Rename `completer` to `result` (its role, rather than repeating its type).
* Change × in non-dartdoc comment to the actual character.
* Throw on an unexpected source address argument type.
Also handle failing unix socket connections better.
The current code did not account for all possible return values
from the native connect functions. Likely, those other values never
occurred, but unless it's proven that they can't, not even in unsound
mode, the code should be prepared for them.
(And added missing `return` to the native code).
TEST= Refactoring, no change to tests.
Change-Id: Ie27670f62ae6ecc64dc045c28869e3d5ab218fda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175042
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2020-12-07 15:42:57 +00:00
..
2020-11-18 14:40:50 +00:00
2020-11-17 13:20:57 +00:00
2020-12-04 22:46:12 +00:00
2019-04-02 20:06:19 +00:00
2020-10-02 00:54:46 +00:00
2019-04-02 20:06:19 +00:00
2019-09-19 03:57:30 +00:00
2019-12-27 17:30:05 +00:00
2019-12-27 17:30:05 +00:00
2019-09-19 03:57:30 +00:00
2019-04-22 20:15:43 +00:00
2018-10-29 15:11:16 +00:00
2019-05-15 21:27:19 +00:00
2019-05-15 21:27:19 +00:00
2020-06-19 18:42:33 +00:00
2020-08-20 19:00:59 +00:00
2020-11-24 10:09:48 +00:00
2020-11-30 18:46:42 +00:00
2020-11-17 10:20:00 +00:00
2020-11-13 22:10:54 +00:00
2020-11-03 10:27:44 +00:00
2020-11-13 22:10:54 +00:00
2020-08-06 19:55:12 +00:00
2020-09-01 22:44:01 +00:00
2020-09-01 22:44:01 +00:00
2020-09-01 22:44:01 +00:00
2020-09-01 22:44:01 +00:00
2020-10-02 00:54:46 +00:00
2020-07-23 11:30:39 +00:00
2020-09-22 17:14:44 +00:00
2020-03-09 14:16:47 +00:00
2019-01-29 15:10:34 +00:00
2020-03-03 20:30:32 +00:00
2019-04-22 20:15:43 +00:00
2019-11-06 16:28:12 +00:00
2019-02-15 23:28:17 +00:00
2020-08-06 21:29:29 +00:00
2020-04-20 16:19:36 +00:00
2019-11-06 16:28:12 +00:00
2019-02-15 23:28:17 +00:00
2019-11-06 16:28:12 +00:00
2019-02-15 23:28:17 +00:00
2020-03-27 15:28:23 +00:00
2020-03-27 15:28:23 +00:00
2019-10-07 22:10:59 +00:00
2019-11-06 16:28:12 +00:00
2020-06-25 03:36:41 +00:00
2020-04-13 21:11:52 +00:00
2019-09-24 15:03:19 +00:00
2019-09-24 15:03:19 +00:00
2019-09-24 15:03:19 +00:00
2019-09-24 15:03:19 +00:00
2020-06-25 03:36:41 +00:00
2020-06-25 03:36:41 +00:00
2019-02-15 23:28:17 +00:00
2019-02-15 23:28:17 +00:00
2019-02-15 23:28:17 +00:00
2020-06-18 12:59:33 +00:00
2020-08-06 21:29:29 +00:00
2020-06-18 12:59:33 +00:00
2020-06-18 12:59:33 +00:00
2020-02-14 17:49:42 +00:00
2020-09-08 17:57:45 +00:00
2018-11-26 16:30:33 +00:00
2020-09-08 17:57:45 +00:00
2020-09-02 20:41:32 +00:00
2020-09-24 16:26:00 +00:00
2020-09-02 20:41:32 +00:00
2019-09-05 21:41:42 +00:00
2020-10-12 20:24:22 +00:00
2020-10-02 00:54:46 +00:00
2020-07-27 22:40:46 +00:00
2020-07-23 11:30:39 +00:00
2020-07-23 11:30:39 +00:00
2020-12-04 14:22:10 +00:00
2020-11-13 22:10:54 +00:00
2020-05-07 19:40:18 +00:00
2019-04-19 16:38:44 +00:00
2019-04-19 16:38:44 +00:00
2020-02-27 17:50:43 +00:00
2020-11-03 10:27:44 +00:00
2020-07-07 21:07:55 +00:00
2020-10-01 23:40:16 +00:00
2019-09-19 03:57:30 +00:00
2020-07-17 19:29:47 +00:00
2020-07-17 19:29:47 +00:00
2020-08-04 19:00:18 +00:00
2020-07-17 19:29:47 +00:00
2020-12-04 14:22:10 +00:00
2020-12-04 14:22:10 +00:00
2020-12-04 14:22:10 +00:00
2020-08-07 18:09:35 +00:00
2020-08-07 18:09:35 +00:00
2019-01-15 22:07:51 +00:00
2020-08-07 18:09:35 +00:00
2020-10-02 00:54:46 +00:00
2020-07-23 11:30:39 +00:00
2019-04-22 20:15:43 +00:00
2019-07-03 10:54:24 +00:00
2020-12-04 14:22:10 +00:00
2020-12-04 14:22:10 +00:00
2019-09-24 20:43:20 +00:00
2019-09-24 20:43:20 +00:00
2019-09-24 20:43:20 +00:00
2020-07-07 21:07:55 +00:00
2020-07-07 21:07:55 +00:00
2020-07-07 21:07:55 +00:00
2019-10-18 10:30:48 +00:00
2020-05-26 22:40:52 +00:00
2020-07-07 21:07:55 +00:00
2020-07-22 03:45:35 +00:00
2020-10-01 15:25:58 +00:00
2020-07-22 03:45:35 +00:00
2020-07-22 03:45:35 +00:00
2020-05-16 00:26:32 +00:00
2020-12-04 22:46:12 +00:00
2019-11-06 16:28:12 +00:00
2020-05-04 20:19:18 +00:00
2019-10-09 21:48:20 +00:00
2020-08-20 19:00:59 +00:00
2020-10-01 23:40:16 +00:00
2020-10-02 01:58:56 +00:00
2020-10-01 23:40:16 +00:00
2020-08-07 18:09:35 +00:00
2019-10-23 18:08:16 +00:00
2020-10-01 23:40:16 +00:00
2020-10-01 23:40:16 +00:00
2020-10-01 23:40:16 +00:00
2020-12-02 02:29:57 +00:00
2020-12-04 22:46:12 +00:00
2020-10-12 15:06:52 +00:00
2020-10-12 15:06:52 +00:00
2019-07-03 10:54:24 +00:00
2019-07-03 10:54:24 +00:00
2020-10-08 19:59:15 +00:00
2020-07-27 21:51:03 +00:00
2020-03-23 03:51:40 +00:00
2020-03-27 15:28:23 +00:00
2020-03-23 03:51:40 +00:00
2020-08-19 17:00:16 +00:00
2020-03-23 20:35:47 +00:00
2020-03-27 15:28:23 +00:00
2020-03-23 03:51:40 +00:00
2020-03-27 15:28:23 +00:00
2020-03-23 03:51:40 +00:00
2020-06-25 03:36:41 +00:00
2020-03-23 03:51:40 +00:00
2020-08-14 00:34:33 +00:00
2020-03-27 15:28:23 +00:00
2020-03-23 03:51:40 +00:00
2020-03-23 03:51:40 +00:00
2020-03-23 03:51:40 +00:00
2020-03-23 03:51:40 +00:00
2020-12-07 15:42:57 +00:00
2020-05-19 21:33:10 +00:00
2020-06-09 21:33:35 +00:00
2018-11-26 16:30:33 +00:00
2020-06-09 21:33:35 +00:00
2020-06-09 21:33:35 +00:00
2020-03-23 03:51:40 +00:00
2020-03-23 03:51:40 +00:00
2020-03-23 03:51:40 +00:00
2020-03-23 03:51:40 +00:00
2020-07-23 11:30:39 +00:00
2019-10-25 19:21:56 +00:00
2019-02-13 20:29:46 +00:00
2019-02-13 20:29:46 +00:00
2019-02-13 20:29:46 +00:00
2019-02-26 01:00:26 +00:00
2018-11-09 18:44:49 +00:00
2019-02-13 20:29:46 +00:00
2019-05-10 18:22:28 +00:00
2019-04-22 20:15:43 +00:00
2020-11-13 22:10:54 +00:00
2020-06-25 03:36:41 +00:00
2020-08-20 19:00:59 +00:00
2020-08-20 19:00:59 +00:00