This changes the API of writing an analysis rule test. Instead of overriding the `String get analysisRule` property, and registering the rule in `setUp` (which requires importing a private type), the developer can now just set the `AbstractAnalysisRule rule` field in `setUp`. This both removes the requirement to manually register the rule, and reduces the risk of typos, by removing the String API. Fixes https://github.com/dart-lang/sdk/issues/61793 Change-Id: Ic7753d3157e06906ba5ccbccfea67aaa3179dcc8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459340 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
5.0 KiB
Testing rules
The analyzer_testing package provides an API for testing analysis rules.
Tests can be written concisely, encouraging the plugin author to write test
cases with good coverage of possible Dart syntax, and the analysis rules
themselves.
The test class
Analysis rule tests that are written with the analyzer_testing package's
support use a class hierarchy to specify shared variables, helper methods, and
set-up and tear-down code. This is all based on the test_reflective_loader
package. Here is the basic structure:
import 'package:analyzer_testing/analysis_rule/analysis_rule.dart';
import 'package:my_rule/src/rules/my_rule.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
@reflectiveTest
class MyRuleTest extends AnalysisRuleTest {
@override
void setUp() {
rule = MyRule();
super.setUp();
}
// Test cases go here.
}
This test file can be written anywhere in the test directory of the plugin
package, maybe at test/my_rule_test.dart.
In this code, we are testing the my_rule analysis rule built in
writing rules, which reports any time an 'await expression' is found.
This structure is different from the classic test structure used when writing
tests with the test package, in which all tests are declared in anonymous
closures passed to the group and test functions. Let's examine the
components of the MyRuleTest class.
class MyRuleTest extends AnalysisRuleTest- The test class usesAnalysisRuleTest, from theanalyzer_testingpackage, as a base.AnalysisRuleTestprovides common functionality likeassertDiagnosticsandnewFile.void setUp- Override this method to provide some set-up code that is executed before each test. This method must callsuper.setUp(). This method is where we instantiate the analysis rule that we are testing:rule = MyRule();.
The test cases
The individual test cases are declared as instance methods of this class. Each
method whose name starts with test_ is registered as a test case. See the
test_reflective_loader package's documentation for more details.
@reflectiveTest
class MyRuleTest extends AnalysisRuleTest {
// ...
void test_has_await() async {
await assertDiagnostics(
r'''
void f(Future<int> p) async {
await p;
}
''',
[lint(33, 5)],
);
}
void test_no_await() async {
await assertNoDiagnostics(
r'''
void f(Future<int> p) async {
// No await.
}
''');
}
}
Let's look at the APIs used in these test cases:
assertDiagnostics- This is the primary assertion method used in analysis rule tests. It allows us to assert which diagnostics are reported, for some given Dart source code. The first argument is the source code, and the second is a list of expected diagnostics,ExpectedDiagnosticobjects. Generally,ExpectedDiagnosticobjects are not manually constructed. Instead, we use thelint()function:lint(33, 5)- This utilitiy creates an expected diagnostic object representing the analysis rule specified by theanalysisRulegetter, which is expected at offset33, for a length of5characters.assertNoDiagnostics- This is a convenience utility that asserts that no diagnostcs are reported for the given source code.
Most test cases can be written as simply as the two above, with a single call to
assertDiagnostics or assertNoDiagnostics.
Some test cases might involve code with compile-time errors, or warnings. (For example, you might want to verify that the analysis rule does not report when certain error conditions are present, so that the user can focus on fixing the error conditions, and not on spurious lint diagnostics.) Here is an example:
void test_has_await_in_non_async() async {
await assertDiagnostics(
r'''
void f(Future<int> p) {
await p;
}
''',
[
// No lint is reported with this error.
error(CompileTimeError.UNDEFINED_IDENTIFIER_AWAIT, 27, 5),
],
);
}
In this example, we assert that the only diagnostic reported for this code
is an CompileTimeError.UNDEFINED_IDENTIFIER_AWAIT error.
The entrypoint
All of the test code above comes together when we register the test class in the
test file's main function:
void main() {
defineReflectiveSuite(() {
defineReflectiveTests(MyRuleTest);
});
}
With this main function, tests can be run in the same way as class test
package tests. They can be run in the usual ways, such as using the IDE, or by
running dart test or dart --enable-asserts test/my_rule_test.dart.