3a91bf9b22
Changes the initialization logic for `PluginConfiguration` so that it always populates the `diagnosticConfigs` field with a map that ignores case when matching keys. This insures that diagnostic codes in a plug-in configuration are matched in a case-insensitive fashion. Also changes the logic in `pkg/analysis_server_plugin` so that when it looks up names in this map, it uses `DiagnosticCode.lowerCaseName` rather than `DiagnosticCode.name`. This in itself has no effect (since the map ignores case), but it paves the way for deprecating (and eventually removing) the `DiagnosticCode.name` getter. Change-Id: I6a6a6964f8ba149f883d1e9b2c9168a0929f7803 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/466184 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com>