Sam Rawlins
331c700f33
The PluginServer class needs access to AssistProcessor in order to compute assists. That class needs access to a few other classes, which then must also be moved: * assist_core.dart - the Assist class * assist_dart.dart - the DartAssistContext class * assist_generators.dart - the registeredAssistGenerators variable * assist_performance.dart - the AssistPerformance and GetAssistsPerformance classes * assist_processor.dart - the AssistProcessor class with it's singular API, `compute()` * performance.dart - the ProducerRequestPerformance class * the `addCaretAtOffset` helper function, refactored into a `withCaretAt` extension method This change is functionally a no-op. Change-Id: Ic883d21e9cc8c3db1f6093f830f01ec6eb9a0976 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416680 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.