Simon Binder
3196571c9b
Some features in `dart:_wasm` are relevant for all WebAssembly targets (like interop types or memory intrinsics). Others, in particular the helper methods to convert between `WasmExternRef` and `JSAny`, don't make sense for the standalone target. To be able to remove the `js_interop` library from the standalone target, we need to stop importing it from `dart:_wasm`. To prepare that step, this moves the helpers to a new library (`dart:_js_interop_wasm`) and re-exports them from `dart:_wasm`. Once Flutter has migrated to the new import, the export can be removed. Bug: https://github.com/dart-lang/sdk/issues/63166 Change-Id: I13fe875e509a13d16c48d420a5927d3130b90736 Cq-Include-Trybots: luci.dart.try:flutter-analyze-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505080 Reviewed-by: Martin Kustermann <kustermann@google.com> Auto-Submit: Simon Binder <oss@simonbinder.eu> Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Slava Egorov <vegorov@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.