10df757a49
We already have tests that exercise this, namely: - ffi_2/regress_39044_test - ffi_2/vmspecific_send_port_id_test Though the bug only appears if C++ compiler decides to evaluate arguments in a different order. This happens to be only the case on Windows. We don't have Windows hardware with Android phones on our CI, which is why this was not caught earlier. We have manually confirmed (via building app on windows with this fix and running on android) that the issue is fixed by this change. Fixes https://github.com/flutter/flutter/issues/54948 Change-Id: I51109cf1062964a5fb77948cffb9e2ba8fe2055f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149980 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com>