Aske Simon Christensen
2cbb5eabca
This removes the optimization that would reuse the Wasm struct of the superclass if no new fields were added in a class. Such reuse interferes with debugging. Binaryen performs a similar optimization in its TypeMerging pass. It seems to be doing a better job with the more precise type information provided after this change. Benchmarks show a positive trend. The change uncovered a number of latent bugs in the compiler, which are also fixed in this CL: - References to `StackTrace` objects must be typed with the representation type of `StackTrace`, rather than its struct type. - The dynamic call vtable entry and dynamic invocation forwarder functions must use `_ListBase` rather than `_List` for their parameters, since we sometimes pass growable lists to these functions. - Most covariant parameters must use the top type, since any object can be passed into such parameters via class type parameter covariance or tear-offs. The change makes us fail a number of tests with very deep class hierarchies due to the Wasm subtyping depth limit of 63. The optimization did not absolve us from this limitation. It just made us only count classes with newly added fields. The limitation is not expected to cause any problems for real code. The maximum subclassing depth that occurs in the Flute benchmark is 11. FWIW, Java has a limit of 60. The limitation is mentioned along with other limitations in https://github.com/dart-lang/sdk/issues/53703 Change-Id: Ifaa23d8278989e2549c41696d8913e55ed1e80aa Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324460 Commit-Queue: Aske Simon Christensen <askesc@google.com> Reviewed-by: Ömer Ağacan <omersa@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency