Files
sdk/runtime/vm/flow_graph_optimizer.cc
T
vegorov@google.com 70a81f4264 Implement inlined version of binary arithmetic operations for doubles.
No attempt to reuse temporary boxes or locally propagate types is done.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10533053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8433 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-08 11:27:28 +00:00

344 lines
10 KiB
C++

// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
#include "vm/flow_graph_optimizer.h"
#include "vm/flow_graph_builder.h"
#include "vm/il_printer.h"
#include "vm/object_store.h"
namespace dart {
DECLARE_FLAG(bool, enable_type_checks);
DECLARE_FLAG(bool, print_flow_graph);
DECLARE_FLAG(bool, trace_optimization);
void FlowGraphOptimizer::ApplyICData() {
VisitBlocks();
if (FLAG_print_flow_graph) {
OS::Print("After Optimizations:\n");
FlowGraphPrinter printer(Function::Handle(), block_order_);
printer.PrintBlocks();
}
}
void FlowGraphOptimizer::VisitBlocks() {
for (intptr_t i = 0; i < block_order_.length(); ++i) {
Instruction* instr = block_order_[i]->Accept(this);
// Optimize all successors until an exit, branch, or a block entry.
while ((instr != NULL) && !instr->IsBlockEntry()) {
instr = instr->Accept(this);
}
}
}
static bool ICDataHasReceiverClass(const ICData& ic_data, const Class& cls) {
ASSERT(!cls.IsNull());
ASSERT(ic_data.num_args_tested() > 0);
Class& test_class = Class::Handle();
Function& target = Function::Handle();
for (intptr_t i = 0; i < ic_data.NumberOfChecks(); i++) {
ic_data.GetOneClassCheckAt(i, &test_class, &target);
if (cls.raw() == test_class.raw()) {
return true;
}
}
return false;
}
static bool ICDataHasTwoReceiverClasses(const ICData& ic_data,
const Class& cls1,
const Class& cls2) {
ASSERT(!cls1.IsNull() && !cls2.IsNull());
if (ic_data.num_args_tested() != 2) {
return false;
}
Function& target = Function::Handle();
for (intptr_t i = 0; i < ic_data.NumberOfChecks(); i++) {
GrowableArray<const Class*> classes;
ic_data.GetCheckAt(i, &classes, &target);
ASSERT(classes.length() == 2);
if (classes[0]->raw() == cls1.raw()) {
if (classes[1]->raw() == cls2.raw()) {
return true;
}
}
}
return false;
}
static bool HasOneSmi(const ICData& ic_data) {
const Class& smi_class =
Class::Handle(Isolate::Current()->object_store()->smi_class());
return ICDataHasReceiverClass(ic_data, smi_class);
}
static bool HasTwoSmi(const ICData& ic_data) {
const Class& smi_class =
Class::Handle(Isolate::Current()->object_store()->smi_class());
return ICDataHasTwoReceiverClasses(ic_data, smi_class, smi_class);
}
static bool HasOneDouble(const ICData& ic_data) {
const Class& double_class =
Class::Handle(Isolate::Current()->object_store()->double_class());
return ICDataHasReceiverClass(ic_data, double_class);
}
static bool HasTwoDouble(const ICData& ic_data) {
const Class& double_class =
Class::Handle(Isolate::Current()->object_store()->double_class());
return ICDataHasTwoReceiverClasses(ic_data, double_class, double_class);
}
void FlowGraphOptimizer::TryReplaceWithBinaryOp(InstanceCallComp* comp,
Token::Kind op_kind) {
if (comp->ic_data()->NumberOfChecks() != 1) {
// TODO(srdjan): Not yet supported.
return;
}
BinaryOpComp::OperandsType operands_type;
if (HasTwoSmi(*comp->ic_data())) {
if (op_kind == Token::kDIV ||
op_kind == Token::kMOD) {
// TODO(srdjan): Not yet supported.
return;
}
operands_type = BinaryOpComp::kSmiOperands;
} else if (HasTwoDouble(*comp->ic_data())) {
if (op_kind != Token::kADD &&
op_kind != Token::kSUB &&
op_kind != Token::kMUL &&
op_kind != Token::kDIV) {
// TODO(vegorov): Not yet supported.
return;
}
operands_type = BinaryOpComp::kDoubleOperands;
} else {
// TODO(srdjan): Not yet supported.
return;
}
ASSERT(comp->instr() != NULL);
ASSERT(comp->InputCount() == 2);
Value* left = comp->InputAt(0);
Value* right = comp->InputAt(1);
BinaryOpComp* bin_op =
new BinaryOpComp(op_kind,
operands_type,
comp,
left,
right);
ASSERT(bin_op->ic_data() == NULL);
bin_op->set_ic_data(comp->ic_data());
bin_op->set_instr(comp->instr());
comp->instr()->replace_computation(bin_op);
}
void FlowGraphOptimizer::TryReplaceWithUnaryOp(InstanceCallComp* comp,
Token::Kind op_kind) {
if (comp->ic_data()->NumberOfChecks() != 1) {
// TODO(srdjan): Not yet supported.
return;
}
ASSERT(comp->instr() != NULL);
ASSERT(comp->InputCount() == 1);
Computation* unary_op = NULL;
if (HasOneSmi(*comp->ic_data())) {
unary_op = new UnarySmiOpComp(op_kind, comp, comp->InputAt(0));
} else if (HasOneDouble(*comp->ic_data()) && (op_kind == Token::kNEGATE)) {
unary_op = new NumberNegateComp(comp, comp->InputAt(0));
}
if (unary_op != NULL) {
ASSERT(unary_op->ic_data() == NULL);
unary_op->set_ic_data(comp->ic_data());
unary_op->set_instr(comp->instr());
comp->instr()->replace_computation(unary_op);
}
}
// Returns true if all targets are the same.
static bool HasOneTarget(const ICData& ic_data) {
ASSERT(ic_data.NumberOfChecks() > 0);
Function& prev_target = Function::Handle();
Class& cls = Class::Handle();
ic_data.GetOneClassCheckAt(0, &cls, &prev_target);
ASSERT(!prev_target.IsNull());
Function& target = Function::Handle();
for (intptr_t i = 1; i < ic_data.NumberOfChecks(); i++) {
ic_data.GetOneClassCheckAt(i, &cls, &target);
ASSERT(!target.IsNull());
if (prev_target.raw() != target.raw()) {
return false;
}
prev_target = target.raw();
}
return true;
}
// Using field class
static RawField* GetField(const Class& field_class, const String& field_name) {
Class& cls = Class::Handle(field_class.raw());
Field& field = Field::Handle();
while (!cls.IsNull()) {
field = cls.LookupInstanceField(field_name);
if (!field.IsNull()) {
return field.raw();
}
cls = cls.SuperClass();
}
return Field::null();
}
// Returns array of all class ids that are in ic_data. The result is
// normalized so that a smi class is at index 0 if it exists in the ic_data.
static ZoneGrowableArray<intptr_t>* ExtractClassIds(const ICData& ic_data) {
if (ic_data.NumberOfChecks() == 0) return NULL;
ZoneGrowableArray<intptr_t>* result =
new ZoneGrowableArray<intptr_t>(ic_data.NumberOfChecks());
intptr_t smi_index = -1;
Function& target = Function::Handle();
Class& cls = Class::Handle();
for (intptr_t i = 0; i < ic_data.NumberOfChecks(); i++) {
ic_data.GetOneClassCheckAt(i, &cls, &target);
result->Add(cls.id());
if (cls.id() == kSmi) {
ASSERT(smi_index < 0); // Classes entered only once in ic_data.
smi_index = i;
}
}
if (smi_index >= 0) {
// Smi class id must be at index 0.
intptr_t temp = (*result)[0];
(*result)[0] = (*result)[smi_index];
(*result)[smi_index] = temp;
}
return result;
}
// Only unique implicit instance getters can be currently handled.
void FlowGraphOptimizer::TryInlineInstanceGetter(InstanceCallComp* comp) {
ASSERT(comp->HasICData());
const ICData& ic_data = *comp->ic_data();
if (ic_data.NumberOfChecks() == 0) {
// No type feedback collected
return;
}
if (!HasOneTarget(ic_data)) {
// TODO(srdjan): Implement when not all targets are the sa,e.
return;
}
Function& target = Function::Handle();
Class& cls = Class::Handle();
ic_data.GetOneClassCheckAt(0, &cls, &target);
if (target.kind() != RawFunction::kImplicitGetter) {
// Not an implicit getter.
// TODO(srdjan): Inline special getters (e.g., array length).
return;
}
// Inline implicit instance getter.
const String& field_name =
String::Handle(Field::NameFromGetter(comp->function_name()));
const Field& field = Field::Handle(GetField(cls, field_name));
ASSERT(!field.IsNull());
LoadInstanceFieldComp* load = new LoadInstanceFieldComp(
field, comp->InputAt(0), comp, ExtractClassIds(ic_data));
// Replace 'comp' with 'load'.
load->set_instr(comp->instr());
comp->instr()->replace_computation(load);
}
void FlowGraphOptimizer::TryInlineInstanceSetter(InstanceSetterComp* comp) {
ASSERT(comp->HasICData());
const ICData& ic_data = *comp->ic_data();
if (ic_data.NumberOfChecks() == 0) {
// No type feedback collected
return;
}
if (!HasOneTarget(ic_data)) {
// TODO(srdjan): Implement when not all targets are the sa,e.
return;
}
Function& target = Function::Handle();
Class& cls = Class::Handle();
ic_data.GetOneClassCheckAt(0, &cls, &target);
if (target.kind() != RawFunction::kImplicitSetter) {
// Not an implicit setter.
// TODO(srdjan): Inline special setters.
return;
}
// Inline implicit instance setter.
const Field& field = Field::Handle(GetField(cls, comp->field_name()));
ASSERT(!field.IsNull());
StoreInstanceFieldComp* store = new StoreInstanceFieldComp(
field,
comp->InputAt(0),
comp->InputAt(1),
comp,
ExtractClassIds(ic_data));
// Replace 'comp' with 'store'.
store->set_instr(comp->instr());
comp->instr()->replace_computation(store);
}
void FlowGraphOptimizer::VisitInstanceCall(InstanceCallComp* comp) {
if (comp->HasICData()) {
const String& function_name = comp->function_name();
Token::Kind op_kind = Token::GetBinaryOp(function_name);
if (op_kind != Token::kILLEGAL) {
TryReplaceWithBinaryOp(comp, op_kind);
return;
}
op_kind = Token::GetUnaryOp(function_name);
if (op_kind != Token::kILLEGAL) {
TryReplaceWithUnaryOp(comp, op_kind);
return;
}
if (Field::IsGetterName(function_name)) {
TryInlineInstanceGetter(comp);
return;
}
}
}
void FlowGraphOptimizer::VisitInstanceSetter(InstanceSetterComp* comp) {
// TODO(srdjan): Add assigneable check node if --enable_type_checks.
if (comp->HasICData() && !FLAG_enable_type_checks) {
TryInlineInstanceSetter(comp);
}
}
void FlowGraphOptimizer::VisitDo(DoInstr* instr) {
instr->computation()->Accept(this);
}
void FlowGraphOptimizer::VisitBind(BindInstr* instr) {
instr->computation()->Accept(this);
}
} // namespace dart