Teagan Strickland 17f62d3f3a
[vm/aot] Drop more Function objects not needed at runtime when possible. ...
Before, use of a function in the static calls table of a Code object
would cause it to be retained. Now, like dispatch table use, we only
retain such functions if there are other uses like dynamic function
lookup that needs the function object or if the
--retain-function-objects flag is enabled.
In most modes, --retain-function-objects is enabled by default.
It is only disabled by default in product mode when
--dwarf-stack-traces is enabled, since otherwise the removed
function objects may be needed for debugging platforms like the
Observatory or when creating symbolic stack traces.
Changes on flutter gallery in release mode:
Default:
arm7: isolate: +6.65%, total: +1.30%
arm8: isolate: +6.67%, total: +1.28%
(The increase is due to changing back to all function objects
being retained as the default when using symbolic stack traces.)
With --no-retain-function-objects:
arm7: isolate: -9.95%, total: -1.73%
arm8: isolate: -10.04%, total: -1.77%
(This measures how much dropping static call function objects
when possible affects the size compared to just dropping
function objects for dispatch table entries when possible.)
Bug: https://github.com/dart-lang/sdk/issues/41052
Change-Id: I3c834b14b0c58ccfdbaca3f154df536df29c13ef
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-product-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142146
Commit-Queue: Tess Strickland <sstrickl@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-04-16 14:26:04 +00:00
2020-04-16 14:26:04 +00:00
2020-04-14 20:37:29 +00:00
2019-08-08 00:47:55 +00:00
2020-04-08 19:43:38 +00:00
2020-02-27 17:50:43 +00:00
2019-10-21 16:26:39 +00:00
2019-12-03 22:00:48 +00:00
2019-12-03 22:00:48 +00:00
2019-12-03 22:00:48 +00:00
2019-07-11 13:36:02 +00:00
2019-11-01 17:06:02 +00:00
2019-10-07 18:13:06 +00:00
2020-03-11 13:05:59 +00:00
2020-03-11 13:05:59 +00:00
2020-02-14 17:57:47 +00:00
2019-11-14 12:49:06 +00:00
2019-10-16 08:25:53 +00:00
2019-10-16 08:25:53 +00:00
2019-11-18 19:54:53 +00:00
2020-03-26 18:30:44 +00:00
2020-03-13 22:29:47 +00:00
2020-03-24 16:58:25 +00:00
2020-03-24 16:58:25 +00:00
2020-03-16 15:01:38 +00:00
2019-06-05 01:05:51 +00:00
2020-04-14 20:37:29 +00:00
2020-02-27 19:54:03 +00:00
2020-04-04 15:03:48 +00:00
2020-04-14 20:37:29 +00:00
2020-04-14 20:37:29 +00:00
2020-04-16 14:26:04 +00:00
2020-04-14 20:37:29 +00:00
2019-11-21 12:28:45 +00:00
2019-11-21 12:28:45 +00:00
2019-11-18 11:50:13 +00:00
2020-02-14 17:57:47 +00:00
2020-02-14 17:57:47 +00:00
2019-08-05 10:46:29 +00:00
2019-11-21 12:28:45 +00:00
2020-03-05 15:17:04 +00:00
2020-04-14 20:37:29 +00:00
2020-03-05 15:17:04 +00:00
2020-04-14 20:37:29 +00:00
2020-03-05 15:17:04 +00:00
2020-04-14 20:37:29 +00:00
2020-03-05 15:17:04 +00:00
2020-04-14 20:37:29 +00:00
2019-10-27 18:18:29 +00:00
2020-04-14 20:37:29 +00:00
2020-04-02 08:39:24 +00:00
2020-04-02 08:39:24 +00:00
2019-12-03 22:00:48 +00:00
2020-02-05 16:36:09 +00:00
2020-04-10 10:14:04 +00:00
2020-02-05 16:36:09 +00:00
2020-04-10 10:14:04 +00:00
2020-02-18 08:43:16 +00:00
2020-02-05 16:36:09 +00:00
2020-04-10 10:14:04 +00:00
2019-06-21 21:38:09 +00:00
2019-12-20 03:26:29 +00:00
2020-02-05 16:36:09 +00:00
2020-04-10 10:14:04 +00:00
2020-04-06 10:36:50 +00:00
2020-02-18 08:43:16 +00:00
2019-08-01 14:14:39 +00:00
2019-09-05 21:41:42 +00:00
2020-03-20 19:05:48 +00:00
2019-10-23 14:44:33 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-10-27 18:18:29 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-10-27 18:18:29 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-09-05 21:41:42 +00:00
2020-03-21 00:36:09 +00:00
2020-04-14 20:37:29 +00:00
2020-04-14 20:37:29 +00:00
2020-01-27 18:27:39 +00:00
2019-05-06 21:01:39 +00:00
2019-10-21 16:26:39 +00:00
2020-02-20 21:08:35 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-04-14 20:37:29 +00:00
2020-04-14 20:37:29 +00:00
2020-01-31 12:56:31 +00:00
2019-12-03 22:00:48 +00:00
2019-06-12 21:56:53 +00:00
2019-06-12 21:56:53 +00:00
2019-09-18 12:24:31 +00:00
2019-06-05 17:39:04 +00:00
2019-06-12 21:56:53 +00:00
2020-03-03 20:30:32 +00:00
2020-01-16 12:47:03 +00:00
2020-01-31 12:56:31 +00:00
2019-10-27 18:18:29 +00:00
2020-03-21 00:36:09 +00:00
2019-10-27 18:18:29 +00:00
2020-03-13 17:19:52 +00:00
2020-03-13 17:19:52 +00:00
2019-07-31 11:52:44 +00:00
2019-07-31 11:52:44 +00:00
2020-03-18 10:23:36 +00:00
2020-03-13 17:19:52 +00:00
2020-03-24 01:09:35 +00:00
2020-03-18 10:23:36 +00:00
2019-09-05 21:41:42 +00:00
2020-04-15 20:04:34 +00:00
2020-04-15 20:04:34 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2020-04-14 20:37:29 +00:00
2020-04-14 20:37:29 +00:00
2020-02-14 17:50:42 +00:00
2020-01-29 11:46:50 +00:00
2020-04-16 14:26:04 +00:00
2020-02-04 23:31:17 +00:00
2019-11-18 10:11:38 +00:00
2019-09-05 21:41:42 +00:00
2020-02-20 21:08:35 +00:00
2020-02-10 15:08:04 +00:00
2019-09-13 18:25:16 +00:00
2020-03-04 18:56:16 +00:00
2020-04-14 20:37:29 +00:00
2019-10-21 18:30:54 +00:00
2020-02-20 20:29:25 +00:00
2020-02-27 23:21:23 +00:00
2019-09-05 21:41:42 +00:00
2020-04-08 12:01:12 +00:00
2020-03-13 17:19:52 +00:00
2020-04-15 14:10:53 +00:00
2020-04-15 14:10:53 +00:00
2020-04-15 14:10:53 +00:00
2020-04-15 14:10:53 +00:00
2019-07-10 22:20:10 +00:00
2019-05-08 17:33:15 +00:00
2020-03-23 23:32:35 +00:00
2020-04-15 14:10:53 +00:00
2019-10-27 18:18:29 +00:00
2020-04-14 20:37:29 +00:00
2019-11-15 22:55:26 +00:00
2020-04-14 20:37:29 +00:00
2020-04-15 22:29:04 +00:00
2020-04-06 18:41:24 +00:00
2020-02-20 21:08:35 +00:00
2019-11-14 02:08:35 +00:00
2020-04-14 22:58:06 +00:00
2020-04-14 20:37:29 +00:00
2019-10-17 03:45:41 +00:00
2019-10-17 03:45:41 +00:00
2019-05-03 18:07:27 +00:00
2019-05-03 18:07:27 +00:00
2020-04-06 14:00:01 +00:00
2020-04-15 13:46:43 +00:00
2020-03-20 17:48:27 +00:00
2019-12-27 19:46:15 +00:00
2020-04-02 16:33:34 +00:00
2020-03-05 15:17:04 +00:00
2020-02-27 04:36:24 +00:00
2020-04-06 14:00:01 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 20:29:25 +00:00
2019-10-27 18:18:29 +00:00
2020-04-04 15:03:48 +00:00
2019-09-04 18:49:40 +00:00
2020-03-03 16:51:51 +00:00
2020-02-20 21:08:35 +00:00
2019-11-05 20:25:43 +00:00
2019-05-06 21:01:39 +00:00
2020-02-04 23:31:17 +00:00
2020-02-14 17:50:42 +00:00
2019-10-28 19:58:53 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-03-23 21:19:36 +00:00
2019-11-18 19:54:53 +00:00
2020-04-14 20:37:29 +00:00
2019-11-18 19:54:53 +00:00
2019-05-06 21:01:39 +00:00
2019-05-06 21:01:39 +00:00
2020-03-23 10:13:43 +00:00
2020-03-23 10:13:43 +00:00
2020-03-23 10:13:43 +00:00
2020-03-23 10:13:43 +00:00
2020-03-23 10:13:43 +00:00
2020-03-23 10:13:43 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2020-03-04 18:56:16 +00:00
2020-03-23 10:13:43 +00:00
2020-01-10 23:48:07 +00:00
2019-07-10 22:20:10 +00:00
2019-11-14 02:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-04-14 20:37:29 +00:00
2020-04-04 15:03:48 +00:00
2020-02-27 19:26:33 +00:00
2020-04-14 20:37:29 +00:00
2020-04-16 04:55:00 +00:00
2020-03-25 11:58:20 +00:00
2019-07-10 22:20:10 +00:00
2020-04-16 14:26:04 +00:00
2020-04-15 14:10:53 +00:00
2019-10-27 18:18:29 +00:00
2020-01-29 21:10:40 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-10-17 21:45:38 +00:00
2019-12-06 19:46:31 +00:00
2019-10-02 05:33:29 +00:00
2019-12-06 19:46:31 +00:00
2019-05-23 17:42:37 +00:00
2020-02-10 20:15:54 +00:00
2019-10-25 19:21:56 +00:00
2019-10-25 19:21:56 +00:00
2019-10-27 18:18:29 +00:00
2019-10-17 21:45:38 +00:00
2020-03-02 20:09:42 +00:00
2019-09-06 23:37:33 +00:00
2020-04-06 10:36:50 +00:00
2019-05-06 21:01:39 +00:00
2020-02-14 17:50:42 +00:00
2019-05-06 21:01:39 +00:00
2019-09-05 21:41:42 +00:00
2020-03-27 20:55:24 +00:00
2019-12-11 18:15:27 +00:00
2020-04-07 06:55:58 +00:00
2020-03-23 10:13:43 +00:00
2019-12-07 00:28:15 +00:00
2020-04-16 14:26:04 +00:00
2020-04-16 14:26:04 +00:00
2020-04-04 15:03:48 +00:00
2019-08-19 19:31:42 +00:00
2020-04-04 15:03:48 +00:00
2020-04-14 20:37:29 +00:00
2020-04-16 14:26:04 +00:00
2019-12-13 00:41:46 +00:00
2020-01-09 01:37:27 +00:00
2020-01-09 01:37:27 +00:00
2019-09-05 21:41:42 +00:00
2019-10-17 16:51:32 +00:00
2019-08-20 00:49:52 +00:00
2020-02-03 11:04:15 +00:00
2020-02-03 11:04:15 +00:00
2020-03-03 20:30:32 +00:00
2020-02-29 01:21:30 +00:00
2020-02-10 15:08:04 +00:00
2020-02-10 15:08:04 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2020-04-04 15:03:48 +00:00
2019-07-10 22:20:10 +00:00
2020-04-14 20:37:29 +00:00
2019-10-30 21:55:25 +00:00
2019-09-05 21:41:42 +00:00
2019-12-06 19:54:42 +00:00
2019-12-06 19:54:42 +00:00
2020-02-21 17:50:13 +00:00
2019-07-23 15:24:28 +00:00
2020-04-14 20:37:29 +00:00
2020-04-14 20:37:29 +00:00
2020-03-04 18:56:16 +00:00
2020-04-14 20:37:29 +00:00
2020-02-28 22:12:16 +00:00
2020-03-23 21:49:37 +00:00
2019-07-16 19:46:56 +00:00
2019-07-16 19:46:56 +00:00
2020-03-13 22:29:47 +00:00
2019-10-15 08:50:52 +00:00
2020-03-13 22:29:47 +00:00
2019-10-02 20:37:10 +00:00
2019-10-27 18:18:29 +00:00
2020-02-11 23:37:05 +00:00
2020-04-07 19:37:47 +00:00
2020-04-14 20:37:29 +00:00
2020-04-04 15:03:48 +00:00
2019-08-01 21:07:50 +00:00
2020-02-07 20:57:46 +00:00
2019-10-02 05:33:29 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2020-02-05 08:46:07 +00:00
2020-03-30 18:33:48 +00:00
2020-03-13 16:58:41 +00:00
2020-03-30 18:33:48 +00:00
2020-03-30 18:33:48 +00:00
2019-09-05 21:41:42 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2020-04-10 10:14:04 +00:00
2019-07-10 22:20:10 +00:00
2020-04-16 04:55:00 +00:00
2020-02-20 13:07:18 +00:00
2020-04-14 20:37:29 +00:00
2020-04-04 15:03:48 +00:00
2020-02-20 21:08:35 +00:00
2019-06-18 17:51:10 +00:00
2020-03-11 22:03:50 +00:00
2020-03-11 22:03:50 +00:00
2020-03-11 22:03:50 +00:00
2020-03-11 22:03:50 +00:00
2020-03-28 00:41:51 +00:00
2020-03-03 18:28:34 +00:00
2019-12-04 14:26:48 +00:00
2019-06-18 17:51:10 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2020-03-05 15:17:04 +00:00
2020-03-11 13:05:59 +00:00
2020-04-10 19:27:04 +00:00
2019-12-11 19:36:18 +00:00
2020-03-10 23:29:18 +00:00
2020-01-17 18:10:04 +00:00
2019-12-07 00:28:15 +00:00
2020-02-20 21:08:35 +00:00
2020-03-10 23:29:18 +00:00
2019-10-09 21:48:20 +00:00
2019-09-05 10:36:13 +00:00
2019-10-29 23:39:36 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-03-17 14:11:02 +00:00
2020-04-07 19:13:26 +00:00
2020-03-17 14:11:02 +00:00
2020-04-14 20:37:29 +00:00
2020-04-14 20:37:29 +00:00
2019-10-17 17:19:32 +00:00
2020-02-20 13:07:18 +00:00
2020-02-20 13:07:18 +00:00
2020-03-23 10:00:03 +00:00
2020-02-20 21:08:35 +00:00
2020-02-20 21:08:35 +00:00
2019-12-18 18:02:41 +00:00
2020-02-20 21:08:35 +00:00
2019-12-10 12:26:05 +00:00
2020-04-14 20:37:29 +00:00
2020-02-20 21:08:35 +00:00
2020-03-17 14:11:02 +00:00
2019-05-01 00:36:14 +00:00
2020-03-24 01:09:35 +00:00
2020-03-24 01:09:35 +00:00
2019-10-17 16:51:32 +00:00
2019-10-17 16:51:32 +00:00
Teagan Strickland
17f62d3f3a