Nate Biggs
63ee73a2ed
- For direct calls in selector branch, ensure 'if' branches have correct inputs. - For overrideable selectors, the receiver type cannot be known in the main module so use 'top' type. Technically we could do better if selectors tracked interfaces they targeted. Then we could take the LUB of all those classes. But this would be a significant refactor for a small benefit. - Type checks on classes defined in the main module should use the class ID ranges from the main module rather than those from the dynamic submodule. This only applies to non-dynamic module extendable types (otherwise we'd use the RTT checks). So we know the class can only exist in one of the range sets, not both. I discovered (1) from running Flutter which led me to create this test which uncovered (2) and (3). Change-Id: I80f39835f66aa7cf0cff527341e3f4a948a7a0cb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430360 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Nate Biggs <natebiggs@google.com>
Tests for Dart dynamic modules
This folder contains tests for an experiment of implementing dynamic modules in Dart. All tests are written in the style of the language end-to-end tests.
Folder structure
Each folder consists of a single test scenario. You'll find 4 kinds of files:
-
main.dart: the host application that will later load dynamic modules. This will be the core driver of the test. -
shared/: folder containing multiple libraries with code that can be used by both the host application and dynamic modules. -
modules/: folder containing code private to dynamic modules. It includes libraries with common code as well as an entrypoint file per dynamic module. Entrypoint files are namedentryN.dartand must define an exported dynamic module entrypoint. Note: semantics limit that two dynamic modules can't share code unless they are compiled in a chained fashion, currently the test harness focuses on compiling modules in isolation and ensuring conflicts don't arise. -
dynamic_interface.yaml: a contract specifying what parts of the host application and libraries inshared/are visible to dynamic modules.
Execution
We've build a test framework that frontloads compilation, so that execution of the test can be streamlined. This means that:
-
The host app will be compiled first, using
dynamic_interface.yamlas a specification for AOT compilers. -
Each and every dynamic module entrypoint in
modules/will be compiled to create a dynamic module artifact. -
Finally an execution environment will be launched that will in turn load each dynamic module as prompted by the test logic.
Commands to drive the loading and execution of each dynamic module are
controlled by a helper library in ../common/testing.dart, which
uses the Dart SDK API and abstracts away differences between platforms.
Example
Refer to update_top_level. This is one of the simplest tests that illustrates
the utilities and concepts in this framework.