Alexander Markov aa34e70d50 Revert "Make Zone functions not call register*, but properly catch errors." ...

This reverts commit fc2c46ae82.

Reason for revert: broke Flutter tests:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8724303399273084113/+/u/Run_framework_coverage_tests/stdout
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8724303399273084097/+/u/Run_framework_tests_libraries_tests/stdout
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8724303399273084081/+/u/Run_framework_tests_misc_tests/stdout
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8724303399273084049/+/u/Run_framework_tests_widgets_tests/stdout
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8724303399273084033/+/u/Run_tool_tests_tests/stdout

Original change's description:
> Make Zone functions not call `register*`, but properly catch errors.
>
> Make `Zone.createTimer`, `Zone.createPeriodicTimer` and `Zone.scheduleMicrotask`
> not call register on the same zone.
> These are low-level functions that should not build on top
> of other low-level functions.
>
> Instead the function is registered in the `Timer` constructors and
> top-level `scheduleMicrotask` code, and the root zone's `createTimer`
> and `scheduleMicrotask` just make sure that the callback will run
> in its original zone, and that uncaught errors are handled in the
> correct zone.
> Avoids a double-registration that timers did.
>
> Significant clean-up.
> - The private `_Zone`, `_ZoneSpecification` and `_ZoneDelegate`
>   subclasses are not necessary now that their superclasses are `final`.
> - Stopped using type aliases instead of function types
>   and old-style function arguments.
> - Renamed some parameters to not be, fx, `f`.
>
> Avoided some closure allocations for microtasks by putting the zone
> into the queue entry, instead of wrapping the callback in a closure calling `zone.run`.
>
> This is a potentially visible change if any code uses the zone functions
> directly and expect them to invoke `Zone.register*`.
> (Suspiciously no test failed with this change. May need to add some.)
>
> Fixes #59913.
>
> CoreLibraryReviewExempt: Have had all +1s, just not at the same time.
> Bug: https://dartbug.com/59913
> Change-Id: Ie3c87f5f22aedcbe30ab04718df98e1c0f0659c3
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405020
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Commit-Queue: Lasse Nielsen <lrn@google.com>

Bug: https://dartbug.com/59913
Change-Id: I386b2b6d2594a50a7597363e13fe24111ea72ade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406685
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>

2025-01-30 09:48:40 -08:00

..

async_await_sync_completer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

async_await_zones_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

async_no_await_zones_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors6_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors7_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors8_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors11_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors12_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors13_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors14_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors15_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors16_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors17_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors18_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors19_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors20_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors21_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors22_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors23_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors24_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors25_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors26_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors27_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors28_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors.dart

…

dart2js_uncaught_error_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

error_stack_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

event_helper.dart

…

first_regression_test.dart

…

future_constructor2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_constructor_test.dart

…

future_delayed_error_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_extension_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_foreach_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_future_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_iterable_extension_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_microtask_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_onerror_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_or_bad_type_test.dart

Migrate corelib and lib tests off @compile-error.

2023-04-20 19:19:01 +00:00

future_or_only_in_async_test.dart

Opt multitests out of formatting in corelib/ and lib/.

2024-11-19 11:14:40 +00:00

future_or_strong_test.dart

…

future_or_type_test.dart

Reland "Tweak expect.dart library."

2024-04-26 15:28:26 +00:00

future_record_extension_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_regression_48493_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_self_complete_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_timeout_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_value_chain2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_value_chain3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_value_chain4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_value_chain_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

futures_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

ignore_regress_56806_test.dart

Fix issue 56806, incorrect ignore on futures.

2024-10-15 13:40:52 +00:00

intercept_print1_test.dart

…

intercept_schedule_microtask1_test.dart

…

intercept_schedule_microtask2_test.dart

…

intercept_schedule_microtask3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

intercept_schedule_microtask4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

intercept_schedule_microtask5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

intercept_schedule_microtask6_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

multiple_timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

null_future_zone_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

periodic_timer2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

periodic_timer3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

periodic_timer4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

regress46319_test.dart

…

regress154963234_strong_test.dart

…

regress154963234_weak_test.dart

…

run_zoned1_test.dart

…

run_zoned4_test.dart

…

run_zoned5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

run_zoned6_test.dart

Opt multitests out of formatting in corelib/ and lib/.

2024-11-19 11:14:40 +00:00

run_zoned7_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

run_zoned8_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

run_zoned9_test.dart

Opt multitests out of formatting in corelib/ and lib/.

2024-11-19 11:14:40 +00:00

schedule_microtask2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

schedule_microtask3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

schedule_microtask5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

schedule_microtask_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

slow_consumer2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

slow_consumer3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

slow_consumer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace01_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace02_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace03_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace04_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace05_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace06_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace07_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace08_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace09_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace10_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace11_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace12_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace13_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace14_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace15_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace16_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace17_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace18_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace19_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace20_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace21_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace22_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace23_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace24_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace25_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_controller_async_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_controller_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_distinct_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_empty_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_error_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_event_transformed_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_first_where_test.dart

Opt multitests out of formatting in corelib/ and lib/.

2024-11-19 11:14:40 +00:00

stream_from_futures_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_from_iterable_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_iterator_double_cancel_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_iterator_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_join_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_last_where_test.dart

Opt multitests out of formatting in corelib/ and lib/.

2024-11-19 11:14:40 +00:00

stream_listen_zone_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_multi_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic6_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_single_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_single_to_multi_subscriber_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_state_helper.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_state_nonzero_timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_state_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_subscription_as_future_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_subscription_cancel_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_take_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_timeout_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transform_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transformation_broadcast_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transformer_from_bind_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transformer_from_handlers_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transformer_test.dart

…

stream_type_test.dart

…

stream_value_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_view_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_zones_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

syncstar_mixed_iterators_test.dart

…

timer_cancel1_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

timer_cancel2_test.dart

…

timer_cancel_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

timer_isActive_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

timer_repeat_test.dart

…

timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

unawaited_error_test.dart

…

unawaited_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

uncaught_error_handler_throws_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

wait_for_cancel_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_bind_callback_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_bind_callback_unary_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_bind_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_create_periodic_timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_create_timer2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_create_timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_debug_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_empty_description2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_empty_description_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_error_callback_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_fork_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_future_schedule_microtask_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_register_callback_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_register_callback_unary_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_root_bind_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_run_guarded_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_run_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_run_unary_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_value_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00