Konstantin Shcheglov
c0bca2c210
Main changes: 1. Separating `FragmentBuilder` and `ElementBuilder`. I removed `augmentation.dart` and its builders, because now it is implemented in the new `ElementBuilder`. 2. Fragments are not given actual `Reference` objects anymore, there might be some in the current state, but I will go over this in the future and remove them completely. 3. Writing and reading elements also happens in two stages: first fragments, then elements. Each fragment in the summary is given unique ID, and during writing / reading elements we use these ID to locate fragments and create elements around them. 4. Lazy loading of `ClassElement` members is simplified and generalized, could be potentially applied to any `InstanceElement`. Maybe use also in mixins, which are used somewhat often in Flutter. 5. There are slight changes to tests, mostly to the better, sometime a bit reordering, a couple of new tests. There is some dirty code added, especially around patching types for getters, setters, and their fragments. I plan to clean this in future CLs as I move toward better implementation, and from using fragments where this is wrong. Change-Id: I1e4bf2a3b7ff45f1dba133797e85cd70aa729c11 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433180 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.