Kevin Moore
23a289417d
When casting a getter return value that requires a covariance check, the CFE inserts an AsExpression where both the operand type and tested-against type are statically identical (the instantiated member return type, e.g. Callable<void Function(num)>). The types.dart optimizer previously assumed that because the static types matched, the runtime type arguments must also match, and optimized away the type-argument checks. However, in a covariance check, the dynamic value returned is a supertype (e.g. Callable<void Function(int)>) due to class parameter covariance. This change safely rewrites the static operand type of a covariance check by preserving the InterfaceType structure but using calculateBounds to rewrite its type arguments to their upper bounds (falling back to Object? or Object for non-interface types). This allows us to keep class-check optimizations active while remaining sound. TEST=tests/language/covariant/callable_class_field_getter_test.dart Fixes https://github.com/dart-lang/sdk/issues/53091 Change-Id: Ia64ea90b1bad2f7c1dab81cc3385103507b97b3e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508425 Reviewed-by: Martin Kustermann <kustermann@google.com> Auto-Submit: Kevin Moore <kevmoo@google.com> Commit-Queue: Kevin Moore <kevmoo@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.