Nicholas Shahan
2379cdc080
- Add a runtime flag to enable checks on non-nullable APIs that return values from non-static JavaScript interop. - Call a new helper method at the call site when these APIs are detected to perform the null check. - Add test file for the cases we can detect and enforce. NOTE: This does not make non-static JavaScript interop sound. This only adds more checks to enforce soundness with respect to nullability in some cases. There are still holes that will never be closed due to the permissive nature of this form of JavaScript interop. Change-Id: I2f88d1543a683fdc84d764e2b0eaafeb0ca73107 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/358581 Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Mayank Patke <fishythefish@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
75 lines
3.1 KiB
Plaintext
75 lines
3.1 KiB
Plaintext
# Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
|
|
# for details. All rights reserved. Use of this source code is governed by a
|
|
# BSD-style license that can be found in the LICENSE file.
|
|
|
|
[ $compiler != dart2js ]
|
|
dummy_compiler_test: SkipByDesign # Issue 30773. Test should be migrated as a unit test of dart2js, is only intended to test self-hosting.
|
|
internal/deferred_url_test: SkipByDesign # test specific for the dart2js runtime
|
|
weak_reference_polyfill_test: SkipByDesign # test specific for the dart2js runtime
|
|
|
|
[ $compiler == dart2wasm ]
|
|
(?!wasm)*: SkipByDesign
|
|
|
|
[ $compiler != dart2wasm ]
|
|
wasm/*: SkipByDesign
|
|
|
|
[ $compiler == ddc ]
|
|
async_stacktrace_test: Skip # Issue 53555
|
|
|
|
[ $runtime == jsshell ]
|
|
deferred/load_in_correct_order_test: SkipByDesign # jsshell preamble does not support this test.
|
|
|
|
[ $browser ]
|
|
native/*: Skip
|
|
|
|
[ $compiler == dart2js && $mode == debug ]
|
|
operator_test: Skip
|
|
string_interpolation_test: Skip
|
|
|
|
[ $compiler == dart2js && $runtime == chrome && $system == windows ]
|
|
class_test: Slow, Pass # Issue 25940
|
|
closure_capture3_test: Slow, Pass # Issue 25940
|
|
closure_capture5_test: Slow, Pass # Issue 25940
|
|
conditional_test: Slow, Pass # Issue 25940
|
|
consistent_codeUnitAt_error_test: Slow, Pass # Issue 25940
|
|
constant_javascript_semantics2_test: Slow, Pass # Issue 25940
|
|
deferred_split_test: Slow, Pass # Issue 25940
|
|
|
|
[ $compiler == dart2js && $runtime == chrome && $csp ]
|
|
deferred/load_in_correct_order_test: SkipByDesign # Purposely uses `eval`
|
|
|
|
[ $compiler == dart2js && $runtime == d8 ]
|
|
internal/object_members_test: SkipByDesign # Browser test
|
|
|
|
[ $compiler == dart2js && $runtime == ff && $system == windows ]
|
|
consistent_index_error_string_test: Slow, Pass # Issue 25940
|
|
|
|
[ $compiler == dart2js && $csp ]
|
|
deferred_custom_loader_test: SkipByDesign # Issue 25683
|
|
deferred_fail_and_retry_test: SkipByDesign # Uses eval to simulate failed loading.
|
|
internal/object_members_test: SkipByDesign # Uses eval for interop
|
|
js_interop_non_null_asserts_disabled_test: SkipByDesign # Issue 42085. CSP policy disallows injected JS code
|
|
js_interop_non_null_asserts_enabled_test: SkipByDesign # Issue 42085. CSP policy disallows injected JS code
|
|
regress/issue/49129_test: SkipByDesign # Uses eval for interop
|
|
|
|
|
|
[ $compiler == dart2js && !$host_asserts ]
|
|
deferred/many_parts/many_parts_test: Slow, Pass # Large stress test by design
|
|
dummy_compiler_test: Slow, Pass # Issue 32439. self-hosting doesn't work with CFE yet.
|
|
|
|
[ $compiler == dart2js && $minified ]
|
|
code_motion_exception_test: Skip # Requires unminified operator names.
|
|
|
|
[ $compiler == dart2js && ($runtime == ff || $runtime == jsshell || $runtime == safari) ]
|
|
code_motion_exception_test: Skip # Required V8 specific format of JavaScript errors.
|
|
|
|
[ $compiler == dart2js && ($browser || $host_asserts) ]
|
|
dummy_compiler_test: SkipByDesign # Issue 30773. Test should be migrated as a unit test of dart2js, is only intended to test self-hosting.
|
|
|
|
[ $compiler == dartk && $runtime == vm ]
|
|
new_from_env_test: SkipByDesign # dart2js only test
|
|
unconditional_dartio_import_test: SkipByDesign # dart2js only test
|
|
|
|
[ $compiler == dartkp || $runtime == vm ]
|
|
weak_reference_test: SkipByDesign # Web only test
|