Tess Strickland
1f5fd27c61
The command line flag allows the user to specify the minimum MacOS or iOS version used in the build version load command for the Mach-O dynamic library snapshot. If not specified, the minimum OS version specified in macOS Mach-O snapshots is 10.15 (Catalina) and the minimum OS version specified in iOS Mach-O snapshots is 13. This CL also changes the targeted OS version in the build version load command to be the same as the minimum OS version. Adds support to parsing build version load commands to pkg/native_stack_traces's Mach-O parser in order to test the existence and contents of build version load commands in vm/dart/unobfuscated_static_symbols. TEST=vm/dart/unobfuscated_static_symbols Issue: https://github.com/dart-lang/sdk/issues/60307 Change-Id: I3ee3ba34297d3261be7e3a1d2fb3c1da1ef0ef05 Cq-Include-Trybots: luci.dart.try:vm-aot-mac-debug-x64-try,vm-aot-mac-debug-arm64-try,vm-aot-linux-debug-arm64-try,vm-aot-linux-debug-x64-try,pkg-mac-release-try,pkg-mac-release-arm64-try,pkg-linux-release-arm64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438901 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.