Alexander Markov
e8f57b6605
This is a follow-up to https://dart-review.googlesource.com/c/sdk/+/186680. After that change, tree shaker started reusing Reference to a Field when it is replaced with a getter. As a side-effect, this makes FieldInitializer.field to crash as Reference is now pointing to Procedure, not a Field. The fix is to carefully use 'node.fieldReference.asMember' instead of 'node.field' and then retrieve original Field node if it was replaced with a getter. TEST=pkg/vm/testcases/transformations/type_flow/transformer/regress_45324_2.dart Fixes https://github.com/dart-lang/sdk/issues/45324 Change-Id: Ic34e8b9933b00997cd350a4ad93f798c86ac60ad Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191323 Auto-Submit: Alexander Markov <alexmarkov@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency