asiva@google.com
eaebf15f43
The stack frame iteration during GC was missing one slot in stub frames that did not save the pool pointer. - This change makes all stub frames uniform, i.e they always save/restore the pool pointer. This ensures that we will traverse all slots on the stack. - A new constant called kFirstObjectSlotFromFp has been added which is used as the slot to start stack traversal. (The ARM and MIPs changes will be in a different CL) R=iposva@google.com, regis@google.com, zra@google.com Review URL: https://codereview.chromium.org//63093003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30088 260f80e4-7a28-3924-810f-c04153c831b5
54 lines
2.0 KiB
C++
54 lines
2.0 KiB
C++
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef VM_STACK_FRAME_X64_H_
|
|
#define VM_STACK_FRAME_X64_H_
|
|
|
|
namespace dart {
|
|
|
|
/* X64 Dart Frame Layout
|
|
|
|
| | <- TOS
|
|
Callee frame | ... |
|
|
| saved PP |
|
|
| callee's PC marker |
|
|
| saved RBP | (RBP of current frame)
|
|
| saved PC | (PC of current frame)
|
|
+--------------------+
|
|
Current frame | ... T| <- RSP of current frame
|
|
| first local T|
|
|
| caller's PP T|
|
|
| PC marker | (current frame's code entry + offset)
|
|
| caller's RBP | <- RBP of current frame
|
|
| caller's ret addr | (PC of caller frame)
|
|
+--------------------+
|
|
Caller frame | last parameter | <- RSP of caller frame
|
|
| ... |
|
|
|
|
T against a slot indicates it needs to be traversed during GC.
|
|
*/
|
|
|
|
static const int kDartFrameFixedSize = 4; // PC marker, RBP, PP, PC.
|
|
static const int kSavedPcSlotFromSp = -1;
|
|
|
|
static const int kFirstObjectSlotFromFp = -2; // Used by GC to traverse stack.
|
|
|
|
static const int kFirstLocalSlotFromFp = -3;
|
|
static const int kSavedCallerPpSlotFromFp = -2;
|
|
static const int kPcMarkerSlotFromFp = -1;
|
|
static const int kSavedCallerFpSlotFromFp = 0;
|
|
static const int kSavedCallerPcSlotFromFp = 1;
|
|
|
|
static const int kParamEndSlotFromFp = 1; // One slot past last parameter.
|
|
static const int kCallerSpSlotFromFp = 2;
|
|
static const int kSavedAboveReturnAddress = 3; // Saved above return address.
|
|
|
|
// Entry and exit frame layout.
|
|
static const int kSavedContextSlotFromEntryFp = -9;
|
|
static const int kExitLinkSlotFromEntryFp = -8;
|
|
|
|
} // namespace dart
|
|
|
|
#endif // VM_STACK_FRAME_X64_H_
|