Paul Berry
1511cbe8bb
This change uses Gerrit OWNERS file syntax (documented here: https://gerrit.googlesource.com/plugins/find-owners/+/HEAD/src/main/resources/Documentation/syntax.md?pli=1) to ensure that any changes affecting pkg/analyzer/api.txt will be reviewed by the developer experience team (or one of the last resort global reviewers), rather than the Dart Model team. Since changes to the analyzer that affect its public API will inevitably affect both .dart files in pkg/analyzer (or pkg/_fe_analyzer_shared) as well as pkg/analyzer/api.txt, this ownership change ensures that any change affecting the analyzer public API will be reviewed both by a member of the Dart Model team and by a member of the developer experience team. Change-Id: I07527efe1fa7aa3f1d75488c1800410c2aaaa6ec Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410660 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency