Paul Berry
13d4eaf99a
Previously the implementation of this method was a stub. It turns out that all the necessary infrastructure was in place already, however the type arguments supplied by MiniAstOperations to TypeAnalyzerOperationsMixin and TypeAnalyzerOperations needed to be changed: in the "mini_ast" representation of types, an InferableParameter is represented by a String, not a PromotedTypeVariableType. This is because InferableParameter is meant to represent the declaration of the type parameter (StructuralParameter for the CFE, TypeParameterElement for the analyzer), not the type itself. The types used for unit testing in _fe_analyzer_shared don't have a separate notion of the declaration of a type parameter, so we just use its name. Implementing this logic required adding a method `TypeSystem.matchTypeParameterType`, which checks if a Type is a type parameter type, and returns the name of the type parameter if so. I based this on the previously existing `TypeSystem._isTypeVar` method (which performed the same job but did not return the type parameter name). I also took the liberty of fixing a flow analysis test that treated `T` as a type variable but failed to mark it as a type variable by calling `addTypeVariable`. This should help pave the way for unit testing more of the shared infrastructure for types. Change-Id: Ia7a9777ec3d90a5886567dcb9f831e388e372f32 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386607 Reviewed-by: Chloe Stefantsova <cstefantsova@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency