dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
1274e083f55cbc6eec00a71407e724655e9efd17
sdk/tests/corelib/math_parse_double_test.dart
T
hausner@google.com f6c776dcbe Eliminate unary plus with hex literals 
The spec says unary + is only allowed with integer and floating point literals, not with hex literals. Somebody noticed that the VM accepted
+0x10 as well.

Consequently, the Math.parseInt(str) library function should fail with
a BadNumberFormatException if it is called with a hex number that is preceded by a +.

Fixes issue 1540.

This change exposed that the dart2js core library implementation is
falsely accepting +0xNNN hex numbers. I filed issue 3333.
Review URL: https://chromiumcodereview.appspot.com//10456060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8177 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-31 22:35:29 +00:00

122 lines
7.1 KiB
Dart
Raw Blame History

// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
bool parseDoubleThrowsBadNumberFormatException(str) {
try {
Math.parseDouble(str);
return false;
} catch (BadNumberFormatException e) {
return true;
}
}
void main() {
Expect.equals(499.0, Math.parseDouble("499"));
Expect.equals(499.0, Math.parseDouble("499.0"));
Expect.equals(499.0, Math.parseDouble("499.0"));
Expect.equals(499.0, Math.parseDouble("+499"));
Expect.equals(-499.0, Math.parseDouble("-499"));
Expect.equals(499.0, Math.parseDouble(" 499 "));
Expect.equals(499.0, Math.parseDouble(" +499 "));
Expect.equals(-499.0, Math.parseDouble(" -499 "));
Expect.equals(0.0, Math.parseDouble("0"));
Expect.equals(0.0, Math.parseDouble("+0"));
Expect.equals(-0.0, Math.parseDouble("-0"));
Expect.equals(true, Math.parseDouble("-0").isNegative());
Expect.equals(0.0, Math.parseDouble(" 0 "));
Expect.equals(0.0, Math.parseDouble(" +0 "));
Expect.equals(-0.0, Math.parseDouble(" -0 "));
Expect.equals(true, Math.parseDouble(" -0 ").isNegative());
Expect.equals(1.0 * 0x1234567890, Math.parseDouble("0x1234567890"));
Expect.equals(1.0 * -0x1234567890, Math.parseDouble("-0x1234567890"));
Expect.equals(1.0 * 0x1234567890, Math.parseDouble(" 0x1234567890 "));
Expect.equals(1.0 * -0x1234567890, Math.parseDouble(" -0x1234567890 "));
Expect.equals(256.0, Math.parseDouble("0x100"));
Expect.equals(-256.0, Math.parseDouble("-0x100"));
Expect.equals(256.0, Math.parseDouble(" 0x100 "));
Expect.equals(-256.0, Math.parseDouble(" -0x100 "));
Expect.equals(1.0 * 0xabcdef, Math.parseDouble("0xabcdef"));
Expect.equals(1.0 * 0xABCDEF, Math.parseDouble("0xABCDEF"));
Expect.equals(1.0 * 0xabcdef, Math.parseDouble("0xabCDEf"));
Expect.equals(1.0 * -0xabcdef, Math.parseDouble("-0xabcdef"));
Expect.equals(1.0 * -0xABCDEF, Math.parseDouble("-0xABCDEF"));
Expect.equals(1.0 * 0xabcdef, Math.parseDouble(" 0xabcdef "));
Expect.equals(1.0 * 0xABCDEF, Math.parseDouble(" 0xABCDEF "));
Expect.equals(1.0 * -0xabcdef, Math.parseDouble(" -0xabcdef "));
Expect.equals(1.0 * -0xABCDEF, Math.parseDouble(" -0xABCDEF "));
Expect.equals(1.0 * 0xabcdef, Math.parseDouble("0x00000abcdef"));
Expect.equals(1.0 * 0xABCDEF, Math.parseDouble("0x00000ABCDEF"));
Expect.equals(1.0 * -0xabcdef, Math.parseDouble("-0x00000abcdef"));
Expect.equals(1.0 * -0xABCDEF, Math.parseDouble("-0x00000ABCDEF"));
Expect.equals(1.0 * 0xabcdef, Math.parseDouble(" 0x00000abcdef "));
Expect.equals(1.0 * 0xABCDEF, Math.parseDouble(" 0x00000ABCDEF "));
Expect.equals(1.0 * -0xabcdef, Math.parseDouble(" -0x00000abcdef "));
Expect.equals(1.0 * -0xABCDEF, Math.parseDouble(" -0x00000ABCDEF "));
Expect.equals(10.0, Math.parseDouble("010"));
Expect.equals(-10.0, Math.parseDouble("-010"));
Expect.equals(10.0, Math.parseDouble(" 010 "));
Expect.equals(-10.0, Math.parseDouble(" -010 "));
Expect.equals(0.1, Math.parseDouble("0.1"));
Expect.equals(0.1, Math.parseDouble(" 0.1 "));
Expect.equals(0.1, Math.parseDouble(" +0.1 "));
Expect.equals(-0.1, Math.parseDouble(" -0.1 "));
Expect.equals(0.1, Math.parseDouble(".1"));
Expect.equals(0.1, Math.parseDouble(" .1 "));
Expect.equals(0.1, Math.parseDouble(" +.1 "));
Expect.equals(-0.1, Math.parseDouble(" -.1 "));
Expect.equals(1234567.89, Math.parseDouble("1234567.89"));
Expect.equals(1234567.89, Math.parseDouble(" 1234567.89 "));
Expect.equals(1234567.89, Math.parseDouble(" +1234567.89 "));
Expect.equals(-1234567.89, Math.parseDouble(" -1234567.89 "));
Expect.equals(1234567e89, Math.parseDouble("1234567e89"));
Expect.equals(1234567e89, Math.parseDouble(" 1234567e89 "));
Expect.equals(1234567e89, Math.parseDouble(" +1234567e89 "));
Expect.equals(-1234567e89, Math.parseDouble(" -1234567e89 "));
Expect.equals(1234567.89e2, Math.parseDouble("1234567.89e2"));
Expect.equals(1234567.89e2, Math.parseDouble(" 1234567.89e2 "));
Expect.equals(1234567.89e2, Math.parseDouble(" +1234567.89e2 "));
Expect.equals(-1234567.89e2, Math.parseDouble(" -1234567.89e2 "));
Expect.equals(1234567.89e2, Math.parseDouble("1234567.89E2"));
Expect.equals(1234567.89e2, Math.parseDouble(" 1234567.89E2 "));
Expect.equals(1234567.89e2, Math.parseDouble(" +1234567.89E2 "));
Expect.equals(-1234567.89e2, Math.parseDouble(" -1234567.89E2 "));
Expect.equals(1234567.89e-2, Math.parseDouble("1234567.89e-2"));
Expect.equals(1234567.89e-2, Math.parseDouble(" 1234567.89e-2 "));
Expect.equals(1234567.89e-2, Math.parseDouble(" +1234567.89e-2 "));
Expect.equals(-1234567.89e-2, Math.parseDouble(" -1234567.89e-2 "));
// TODO(floitsch): add tests for NaN and Infinity.
Expect.equals(false, parseDoubleThrowsBadNumberFormatException("1.5"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("1b"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" 1b "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" 1 b "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" e3 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" .e3 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("00x12"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" 00x12 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("-1b"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" -1b "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" -1 b "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("-00x12"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" -00x12 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" -00x12 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("0x0x12"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("+ 1.5"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("- 1.5"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(""));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("5."));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" 5. "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" +5. "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" -5. "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("1234567.e2"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" 1234567.e2 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" +1234567.e2 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" -1234567.e2 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("+0x1234567890"));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" +0x1234567890 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException(" +0x100 "));
Expect.equals(true, parseDoubleThrowsBadNumberFormatException("+0x100"));
}
Reference in New Issue View Git Blame Copy Permalink