Jenny Messerly
2d851eb444
This change improves DDC/DDK source maps: - fix Analyzer backend step locations to pass all of the tests Kernel was passing. Also improves breakpoints and code coverage. - fix Analyzer backend to mark hover spans where possible, such as fields, parameters, locals, `this`, properties, methods, etc. - refactor DDC/DDK backends to emit source locations, rather than pointers to Analyzer/Kernel tree nodes. - unify/simplify source_map_printer between Analyzer/Kernel backends. - source_map_printer understands JS expression nesting, marking the innermost JS expression offset corresponding to a given Dart offset. This preserves hover tooltips, even for expressions with implicit coercions (e.g. `dart.test(x)`) - source_map_printer understands that JS end-of-function markings need to be before the closing brace. - merge _visitAndMarkExpression and _visitExpression to simplify Analyzer & Kernel backends. - fix test expectations where the column location was too specific. - adds a message to the stepping test runner to help future debugging. - removes optional destructuring support from Analyzer backend. This was unused/untested and added complexity. Instead we should decide if/when to fully switch to destructuring, and then do so. Change-Id: Ic47b4e21447fffc8fb1809b7bf8ffceeeb61b43e Reviewed-on: https://dart-review.googlesource.com/42028 Reviewed-by: Vijay Menon <vsm@google.com>
Testing of source maps
This folder contains two types of tests for validating sourcemaps: the debugging behavior and the stacktrace behavior.
For both there are 2 suits: One for (legacy) DDC and one for DDC with kernel (DDK).
Running the tests likely requires the compilation of the correct targets. DDK currently also
requires ddc_sdk.dill inside
{sdkroot}/{out,xcodebuild}/ReleaseX64/gen/utils/dartdevc/kernel/ddc_sdk.dill.
Except for that, running them should simply be a matter of executing the *_suite.dart files.
All tests are plain Dart files and goes in "testfiles" (debugging tests) or "stacktrace_testfiles" (stacktrace tests). They are automatically picked up by the testing framework.
Debugging tests (step tests)
See README.md in pkg/sourcemap_testing.
Debugging a test
One can filter which tests are run by running (from the sourcemap folder):
dart sourcemaps_ddc_suite.dart -- sourcemaps_ddc//printing_class_fields
One can additionally get debug output for failing tests (i.e. tests with different outcome than expected), e.g.:
dart sourcemaps_ddc_suite.dart -Ddebug=true -- sourcemaps_ddc//printing_class_fields
The latter is also useful in combination with /*fail*/ when adding new tests to see all the places
where the debugger stopped (both in JS positions and translated to dart positions).
For instance -Ddebug=true -- sourcemaps_ddk//next_through_catch_test with a /*fail*/
currently gives output like the following:
Stop #1
test.main = function() { | main() {
try { | try {
let value = /*STOP*/"world"; | var value = /*STOP*/"world";
dart.throw(dart.str`Hello, ${value}`); | // Comment
} catch (e) { | throw "Hello, $value";
Stop #2
try { | var value = "world";
let value = "world"; | // Comment
/*STOP*/dart.throw(dart.str`Hello, ${value}`); | /*STOP*/throw "Hello, $value";
} catch (e) { | }
let st = dart.stackTrace(e); | // Comment
Stop #3
dart.throw(dart.str`Hello, ${value}`); | }
} catch (e) { | // Comment
let st = /*STOP*/dart.stackTrace(e); | catch (e, /*STOP*/st) {
{ | print(e);
core.print(e); | print(st);
[...]