dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
0916cca7d2f3cf59ee89ff0d2b71c45fbbdf6327
sdk/runtime/lib
T
History
Jens Johansen 5c74e0e16f Fix wrong assert in InvocationMirror_unpackTypeArguments 
There's an assert in InvocationMirror_unpackTypeArguments checking that
the length of the incomming TypeArguments is positive (len > 0).
That's not a valid assert.
When creating TypeArguments it will be TypeArguments::null() if it is
empty or contains only dynamic.
TypeArguments::null() will answer 0 as length which is thus perfectly
valid.

This CL fixes the wrong assert (technically it returns before the assert,
but still).

Fixes #31381.

Change-Id: I7a253418b69751b13e98fcf2def2b23b32f96142
Reviewed-on: https://dart-review.googlesource.com/37480
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2018-01-30 12:25:49 +00:00
..
array_patch.dart
[VM] Fix typing violations in string_patch.dart.
2017-10-19 06:42:37 +00:00
array.cc
[VM, Compiler] Move compiler to a separate folder.
2017-09-04 15:15:18 +00:00
array.dart
[vm] Split _List&_GrowableList []= into checked and unchecked parts
2017-12-07 13:09:55 +00:00
async_patch.dart
Change some constant declarations to lowerCase.
2017-11-14 12:59:14 +00:00
async_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
async.cc
Remove the debugger_ field from Isolate in a PRODUCT build.
2017-07-18 13:29:40 -07:00
bigint_patch.dart
Provide distinct BigInt implementation classes in VM, dart2js, and dartdevc.
2018-01-29 18:12:34 +00:00
bigint.dart
[vm,libs] Strong mode fix to bigint.dart
2017-11-30 22:51:46 +00:00
bool_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
bool.cc
VM: Re-format to use at most one newline between functions
2017-07-13 08:08:37 -07:00
class_id_fasta.dart
Changes to runtime patches so Fasta can understand them.
2017-11-01 15:16:04 +00:00
class_id.cc
VM: Restore old implementation of ClassID.cid* fields.
2017-02-16 17:43:42 +01:00
class_id.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
collection_patch.dart
Insert implicit downcasts for simple assignments.
2017-10-27 18:27:09 +00:00
collection_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
compact_hash.dart
[VM] Do eager rehashing of [LinkedHashMap]s in order to avoid checking on every access
2017-10-31 13:42:15 +00:00
convert_patch.dart
[VM] Cleanup more typing issues in convert_patch.
2017-10-19 14:01:07 +00:00
convert_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
core_patch.dart
Provide distinct BigInt implementation classes in VM, dart2js, and dartdevc.
2018-01-29 18:12:34 +00:00
core_sources.gni
Provide distinct BigInt implementation classes in VM, dart2js, and dartdevc.
2018-01-29 18:12:34 +00:00
date_patch.dart
Change some constant declarations to lowerCase.
2017-11-14 12:59:14 +00:00
date.cc
VM: Re-format to use at most one newline between functions
2017-07-13 08:08:37 -07:00
deferred_load_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
developer_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
developer.cc
Remove the debugger_ field from Isolate in a PRODUCT build.
2017-07-18 13:29:40 -07:00
developer.dart
Reapply "Partial static mode changes for vm-service and tests (part 3)."
2018-01-11 01:31:17 +00:00
double_patch.dart
Change some constant declarations to lowerCase.
2017-11-14 12:59:14 +00:00
double.cc
[VM] Relax constraints for integer literals according to int64 spec
2017-11-09 16:58:38 +00:00
double.dart
[vm/corelib] Fix int/double comparisons in num.compareTo
2018-01-22 18:22:28 +00:00
empty_source.dart
…
errors_patch.dart
Change some constant declarations to lowerCase.
2017-11-14 12:59:14 +00:00
errors.cc
Revised "Eliminate dependencies on assemblers and code stubs in precompiled runtime."
2017-09-04 13:13:26 +02:00
expando_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
function_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
function.cc
[VM] Replace hand-written assembly prologues with IR
2017-12-13 16:04:34 +00:00
function.dart
Fix SDK errors due to inconsistent inheritance of Operator==.
2017-12-11 13:02:19 +00:00
growable_array.cc
[VM, Compiler] Move compiler to a separate folder.
2017-09-04 15:15:18 +00:00
growable_array.dart
[vm] Split _List&_GrowableList []= into checked and unchecked parts
2017-12-07 13:09:55 +00:00
identical_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
identical.cc
Remove more things
2016-02-22 08:53:11 -08:00
immutable_map.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
integers_patch.dart
[kernel] Support 64-bit integer literals correctly in Fasta.
2017-12-13 20:35:19 +00:00
integers.cc
Reapply CL "Option to truncate integers to 64 bits, part 2"
2017-07-17 12:20:17 -07:00
integers.dart
[vm/corelib] Fix int/double comparisons in num.compareTo
2018-01-22 18:22:28 +00:00
internal_patch.dart
[VM runtime] Implement support for _extractTypeArguments in the VM (fixes #31805).
2018-01-12 21:32:20 +00:00
internal_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
invocation_mirror_patch.dart
Revert "Revert "[kernel] Implementation of fine-grained strong mode argument type-checks, phase 2""
2017-11-27 18:25:31 +00:00
invocation_mirror.h
Revert "Revert "Dart Core Lib change to support generic functions in class NoSuchMethodError.""
2017-09-28 00:27:24 +00:00
isolate_patch.dart
Reland: [dart:cli] Adds waitFor(Future)
2018-01-18 16:38:54 +00:00
isolate_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
isolate.cc
Delete code related to FLAG_i_like_slow_isolate_spawn which was only used in dartium.
2017-10-05 00:56:43 +00:00
lib_prefix.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
libgen_in.cc
Windows: Link library sources into gen_snapshot/dart_bootstrap
2017-02-01 15:55:59 -08:00
linked_hash_map.cc
[VM, Compiler] Move compiler to a separate folder.
2017-09-04 15:15:18 +00:00
map_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
math_patch.dart
Change some constant declarations to lowerCase.
2017-11-14 12:59:14 +00:00
math_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
math.cc
VM: Re-format to use at most one newline between functions
2017-07-13 08:08:37 -07:00
mirror_reference.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
mirrors_impl.dart
[VM] Cleanup typing issues in mirrors_impl.dart
2017-10-16 10:30:26 +00:00
mirrors_patch.dart
Changes to runtime patches so Fasta can understand them.
2017-11-01 15:16:04 +00:00
mirrors_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
mirrors.cc
[VM generic functions] Properly instantiate generic signatures by providing the
2017-10-16 21:57:05 +00:00
mirrors.h
clang-format runtime/lib
2016-11-04 12:14:41 -07:00
null_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
object_patch.dart
[VM] Correct return type of _setHash
2017-10-31 22:01:08 +00:00
object.cc
Fix wrong assert in InvocationMirror_unpackTypeArguments
2018-01-30 12:25:49 +00:00
print_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
profiler_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
profiler.cc
VM: Re-format to use at most one newline between functions
2017-07-13 08:08:37 -07:00
profiler.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
regexp_patch.dart
[VM] Cleanup typing issues in regexp_patch.
2017-10-19 14:00:57 +00:00
regexp.cc
VM: Re-format to use at most one newline between functions
2017-07-13 08:08:37 -07:00
schedule_microtask_patch.dart
Reland: [dart:cli] Adds waitFor(Future)
2018-01-18 16:38:54 +00:00
simd128.cc
VM: Re-format to use at most one newline between functions
2017-07-13 08:08:37 -07:00
stacktrace.cc
Remove the debugger_ field from Isolate in a PRODUCT build.
2017-07-18 13:29:40 -07:00
stacktrace.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
stacktrace.h
Track async causal stack traces
2017-02-09 15:39:44 -08:00
stopwatch_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
stopwatch.cc
VM: Re-format to use at most one newline between functions
2017-07-13 08:08:37 -07:00
string_buffer_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
string_patch.dart
[VM] Stop treating 0x180e as whitespace
2018-01-18 10:37:15 +00:00
string.cc
[VM] Make "Hello, World!" run in strong mode (through DFE).
2017-10-24 11:43:48 +00:00
symbol_patch.dart
Changes to runtime patches so Fasta can understand them.
2017-11-01 15:16:04 +00:00
timeline.cc
Limit preserialized JSON for timeline events from Dart code to the arguments.
2017-09-19 23:29:55 +00:00
timeline.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
timer_impl.dart
Add correct type in Timer implementation
2017-10-30 13:36:14 +00:00
timer_patch.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00
type_patch.dart
[VM] Intrinsify Type.hashCode
2017-10-10 23:46:09 +00:00
typed_data_patch.dart
Change some constant declarations to lowerCase.
2017-11-14 12:59:14 +00:00
typed_data_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
typed_data.cc
Remove unused native methods ByteData_ToEndian<T>
2017-07-13 10:08:45 -07:00
uri_patch.dart
Change some constant declarations to lowerCase.
2017-11-14 12:59:14 +00:00
uri.cc
Rename TARGET_OS_* to HOST_OS_*.
2017-03-15 13:11:05 -07:00
vmservice_sources.gni
[infra] Translate _sources.gypi files to _sources.gni files
2017-08-14 21:54:36 -07:00
vmservice.cc
[vm, gardening] Move --trace-service output to stderr.
2017-08-09 13:06:14 -07:00
weak_property.cc
VM: Re-format to use at most one newline between functions
2017-07-13 08:08:37 -07:00
weak_property.dart
Clean up patches so they can be compiled by Fasta.
2017-10-05 14:05:50 +00:00