Teagan Strickland
089aeedf56
[vm/compiler] Reland "Add --save-debugging-info flag to gen_snapshot."
...
Removes an unnecessary change to the names of type testing stubs that
allowed name collisions to happen.
Old commit message:
The flag can be used when creating AOT snapshots. The resulting file can be
used with package:vm/dwarf/convert.dart to convert DWARF-based stack traces
to stack traces with function, file, and line number information.
Currently the saved file will be an ELF file with DWARF debugging information,
but this is subject to change in the future. To avoid being affected by any
changes in format, read the DWARF information from the file using
Dwarf.fromFile() in package:vm/dwarf/dwarf.dart.
Also adds --dwarf-stack-traces to the VM global flag list, so its value at
compilation will be read out of snapshots by the precompiled runtime.
Fixes https://github.com/dart-lang/sdk/issues/39512 , which was due to
a missing compiler::target:: prefix for Instructions::HeaderSize() in
BlobImageWriter::WriteText().
Exposes the information suggested in
https://github.com/dart-lang/sdk/issues/39490 so that package:vm/dwarf
can appropriately convert absolute PC addresses to the correct virtual
address for a given DWARF line number program.
Bug: https://github.com/dart-lang/sdk/issues/35851
Change-Id: I6723449dceb0b89c054a1f1e70e7acd7749baf14
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-precomp-mac-release-simarm64-try,vm-kernel-precomp-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128730
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-12-18 14:14:41 +00:00
..
2019-12-17 20:39:14 +00:00
2019-12-17 11:14:19 +00:00
2019-08-08 00:47:55 +00:00
2019-12-13 23:10:55 +00:00
2019-01-11 20:47:10 +00:00
2019-01-25 16:45:13 +00:00
2019-10-21 16:26:39 +00:00
2019-12-03 22:00:48 +00:00
2019-12-03 22:00:48 +00:00
2019-12-03 22:00:48 +00:00
2019-07-11 13:36:02 +00:00
2019-11-01 17:06:02 +00:00
2019-10-07 18:13:06 +00:00
2019-12-16 18:32:23 +00:00
2019-11-14 12:49:06 +00:00
2019-10-16 08:25:53 +00:00
2019-10-16 08:25:53 +00:00
2019-11-18 19:54:53 +00:00
2019-12-09 18:18:59 +00:00
2019-09-04 00:08:58 +00:00
2019-09-18 14:56:27 +00:00
2019-09-18 14:56:27 +00:00
2019-12-13 20:13:20 +00:00
2019-04-24 23:12:45 +00:00
2019-06-05 01:05:51 +00:00
2019-12-13 00:41:46 +00:00
2019-06-20 18:27:21 +00:00
2019-11-01 00:43:59 +00:00
2019-12-11 18:54:08 +00:00
2019-11-21 19:37:26 +00:00
2019-12-11 18:54:08 +00:00
2019-10-22 19:02:26 +00:00
2019-11-21 12:28:45 +00:00
2019-11-21 12:28:45 +00:00
2019-11-18 11:50:13 +00:00
2019-12-18 10:34:41 +00:00
2019-11-18 11:50:13 +00:00
2019-01-25 16:45:13 +00:00
2019-08-05 10:46:29 +00:00
2019-11-21 12:28:45 +00:00
2019-07-10 22:20:10 +00:00
2019-06-12 21:56:53 +00:00
2018-11-21 17:45:11 +00:00
2019-06-12 21:56:53 +00:00
2018-11-21 17:45:11 +00:00
2019-09-18 12:24:31 +00:00
2018-11-14 02:48:03 +00:00
2018-11-21 17:45:11 +00:00
2019-06-12 21:56:53 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-11-06 17:46:32 +00:00
2019-04-05 21:12:44 +00:00
2019-12-03 22:00:48 +00:00
2019-11-21 14:11:55 +00:00
2019-11-21 14:11:55 +00:00
2019-10-15 20:27:12 +00:00
2019-10-15 20:27:12 +00:00
2019-04-24 23:12:45 +00:00
2019-08-21 13:33:37 +00:00
2019-06-21 21:38:09 +00:00
2019-11-15 23:03:16 +00:00
2019-04-24 23:12:45 +00:00
2019-05-09 11:46:03 +00:00
2019-10-27 18:18:29 +00:00
2019-08-01 14:14:39 +00:00
2019-09-05 21:41:42 +00:00
2019-11-18 16:58:53 +00:00
2019-10-23 14:44:33 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-10-27 18:18:29 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-10-27 18:18:29 +00:00
2019-09-18 19:47:29 +00:00
2019-09-18 19:47:29 +00:00
2019-09-05 21:41:42 +00:00
2019-11-14 02:08:35 +00:00
2019-12-18 14:14:41 +00:00
2019-12-13 00:41:46 +00:00
2019-08-30 17:49:28 +00:00
2019-05-06 21:01:39 +00:00
2019-10-21 16:26:39 +00:00
2019-10-21 16:26:39 +00:00
2019-11-20 19:57:11 +00:00
2019-11-20 19:57:11 +00:00
2019-12-13 00:41:46 +00:00
2019-11-13 01:40:36 +00:00
2019-08-30 17:49:28 +00:00
2019-12-03 22:00:48 +00:00
2018-11-30 00:01:19 +00:00
2019-06-12 21:56:53 +00:00
2019-06-12 21:56:53 +00:00
2019-09-18 12:24:31 +00:00
2019-06-05 17:39:04 +00:00
2019-06-12 21:56:53 +00:00
2019-12-12 23:05:51 +00:00
2019-12-03 22:00:48 +00:00
2019-06-12 21:56:53 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-07-31 11:52:44 +00:00
2019-07-31 11:52:44 +00:00
2019-12-18 14:14:41 +00:00
2019-12-18 14:14:41 +00:00
2019-12-18 14:14:41 +00:00
2019-12-18 14:14:41 +00:00
2019-09-05 21:41:42 +00:00
2019-11-15 16:14:15 +00:00
2019-09-30 20:19:03 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-08-30 17:49:28 +00:00
2019-12-18 14:14:41 +00:00
2019-11-18 10:11:38 +00:00
2019-11-18 10:11:38 +00:00
2019-09-05 21:41:42 +00:00
2019-11-11 23:56:00 +00:00
2019-11-07 22:45:47 +00:00
2019-09-13 18:25:16 +00:00
2019-01-11 20:47:10 +00:00
2019-03-08 00:06:37 +00:00
2019-01-25 16:45:13 +00:00
2019-03-08 00:06:37 +00:00
2019-01-25 16:45:13 +00:00
2019-01-25 16:45:13 +00:00
2019-10-21 18:30:54 +00:00
2019-10-21 18:30:54 +00:00
2019-03-22 23:46:51 +00:00
2019-09-05 21:41:42 +00:00
2019-12-18 14:14:41 +00:00
2019-11-07 14:01:07 +00:00
2018-11-21 17:45:11 +00:00
2019-06-12 21:56:53 +00:00
2019-07-10 22:20:10 +00:00
2018-11-21 17:45:11 +00:00
2019-10-23 14:44:33 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-01-25 16:45:13 +00:00
2019-05-08 17:33:15 +00:00
2018-11-14 02:48:03 +00:00
2018-11-21 17:45:11 +00:00
2019-12-13 15:03:18 +00:00
2019-01-25 16:45:13 +00:00
2019-10-27 18:18:29 +00:00
2019-11-16 00:22:56 +00:00
2019-11-15 22:55:26 +00:00
2019-01-18 18:23:26 +00:00
2019-01-18 18:23:26 +00:00
2019-11-15 22:55:26 +00:00
2019-12-13 00:41:46 +00:00
2019-12-03 22:00:48 +00:00
2019-11-14 02:08:35 +00:00
2019-12-16 18:32:23 +00:00
2019-12-03 22:00:48 +00:00
2019-10-17 03:45:41 +00:00
2019-10-17 03:45:41 +00:00
2019-05-03 18:07:27 +00:00
2019-05-03 18:07:27 +00:00
2018-11-22 15:14:46 +00:00
2019-12-03 22:00:48 +00:00
2019-12-03 12:29:35 +00:00
2019-12-17 01:42:29 +00:00
2019-10-23 19:34:28 +00:00
2019-12-05 22:19:00 +00:00
2019-12-04 19:19:29 +00:00
2019-11-12 12:32:08 +00:00
2019-12-03 22:00:48 +00:00
2019-09-18 12:24:31 +00:00
2019-09-18 12:24:31 +00:00
2019-01-25 16:45:13 +00:00
2018-12-05 18:57:02 +00:00
2019-01-11 20:47:10 +00:00
2019-04-02 22:45:24 +00:00
2019-04-02 22:45:24 +00:00
2019-04-02 22:45:24 +00:00
2019-10-27 18:18:29 +00:00
2019-03-06 19:16:27 +00:00
2019-04-02 22:45:24 +00:00
2019-09-04 18:49:40 +00:00
2019-09-04 18:49:40 +00:00
2019-05-06 21:01:39 +00:00
2019-11-05 20:25:43 +00:00
2019-11-05 20:25:43 +00:00
2019-05-06 21:01:39 +00:00
2019-06-03 14:36:04 +00:00
2019-06-03 14:36:04 +00:00
2019-10-28 19:58:53 +00:00
2019-04-02 11:49:18 +00:00
2019-10-28 19:58:53 +00:00
2018-11-20 17:25:42 +00:00
2019-09-04 08:53:12 +00:00
2019-11-18 19:54:53 +00:00
2019-11-18 19:54:53 +00:00
2019-11-18 19:54:53 +00:00
2019-01-25 16:45:13 +00:00
2019-05-06 21:01:39 +00:00
2019-05-06 21:01:39 +00:00
2019-04-24 19:53:35 +00:00
2019-06-05 21:54:11 +00:00
2019-04-24 19:53:35 +00:00
2019-04-24 19:53:35 +00:00
2019-04-24 19:53:35 +00:00
2019-04-24 19:53:35 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-08-19 19:31:42 +00:00
2019-12-07 00:28:15 +00:00
2019-11-16 00:22:56 +00:00
2019-07-10 22:20:10 +00:00
2019-11-14 02:08:35 +00:00
2019-11-16 02:49:48 +00:00
2019-11-16 00:22:56 +00:00
2019-09-06 23:37:33 +00:00
2019-12-12 18:00:31 +00:00
2019-12-11 10:00:29 +00:00
2019-07-10 22:20:10 +00:00
2019-12-18 14:14:41 +00:00
2019-12-17 20:39:14 +00:00
2019-10-27 18:18:29 +00:00
2019-10-31 21:34:49 +00:00
2019-10-27 18:18:29 +00:00
2019-10-27 18:18:29 +00:00
2019-10-17 21:45:38 +00:00
2019-12-06 19:46:31 +00:00
2019-10-02 05:33:29 +00:00
2019-12-06 19:46:31 +00:00
2019-05-23 17:42:37 +00:00
2019-02-26 01:00:26 +00:00
2018-11-09 18:44:49 +00:00
2019-10-25 19:21:56 +00:00
2019-10-25 19:21:56 +00:00
2019-10-27 18:18:29 +00:00
2019-10-17 21:45:38 +00:00
2019-12-04 19:19:29 +00:00
2019-09-06 23:37:33 +00:00
2019-10-17 21:45:38 +00:00
2019-05-06 21:01:39 +00:00
2019-06-26 00:17:04 +00:00
2019-05-06 21:01:39 +00:00
2019-09-05 21:41:42 +00:00
2019-12-11 18:15:27 +00:00
2019-12-11 18:15:27 +00:00
2019-11-01 19:08:42 +00:00
2019-11-11 23:56:00 +00:00
2019-12-07 00:28:15 +00:00
2019-12-11 10:00:29 +00:00
2019-11-14 12:49:06 +00:00
2019-12-03 22:00:48 +00:00
2019-08-19 19:31:42 +00:00
2019-11-06 22:44:33 +00:00
2019-12-16 18:32:23 +00:00
2019-12-16 18:32:23 +00:00
2019-12-13 00:41:46 +00:00
2019-04-29 09:11:48 +00:00
2019-11-01 20:06:52 +00:00
2019-04-29 09:11:48 +00:00
2019-04-29 09:11:48 +00:00
2019-04-29 09:11:48 +00:00
2019-03-14 14:26:47 +00:00
2019-09-05 21:41:42 +00:00
2019-04-29 09:11:48 +00:00
2019-04-30 16:17:18 +00:00
2019-04-30 16:17:18 +00:00
2019-10-17 16:51:32 +00:00
2019-04-29 09:11:48 +00:00
2019-08-20 00:49:52 +00:00
2019-09-05 21:41:42 +00:00
2019-04-29 09:11:48 +00:00
2018-12-10 23:15:27 +00:00
2018-12-10 23:15:27 +00:00
2019-11-16 02:49:48 +00:00
2019-04-11 09:57:25 +00:00
2018-11-14 02:48:03 +00:00
2018-12-13 17:45:02 +00:00
2018-12-13 17:45:02 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-12-10 15:28:45 +00:00
2019-07-10 22:20:10 +00:00
2019-12-16 18:32:23 +00:00
2019-10-30 21:55:25 +00:00
2019-09-05 21:41:42 +00:00
2019-12-06 19:54:42 +00:00
2019-12-06 19:54:42 +00:00
2019-09-25 21:41:55 +00:00
2019-07-23 15:24:28 +00:00
2019-12-13 00:41:46 +00:00
2019-10-23 19:34:28 +00:00
2019-09-07 01:04:08 +00:00
2019-12-03 22:00:48 +00:00
2019-11-16 00:22:56 +00:00
2019-07-16 19:46:56 +00:00
2019-07-16 19:46:56 +00:00
2019-07-16 19:46:56 +00:00
2019-10-21 16:26:39 +00:00
2019-10-15 08:50:52 +00:00
2019-10-23 14:44:33 +00:00
2019-10-02 20:37:10 +00:00
2019-10-27 18:18:29 +00:00
2019-11-01 00:43:59 +00:00
2019-10-09 23:38:30 +00:00
2019-11-01 00:43:59 +00:00
2019-10-17 21:45:38 +00:00
2019-08-01 21:07:50 +00:00
2019-10-27 18:18:29 +00:00
2019-03-07 02:04:41 +00:00
2019-04-29 09:11:48 +00:00
2019-10-02 05:33:29 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-09-05 21:41:42 +00:00
2019-12-11 10:00:29 +00:00
2019-11-11 23:56:00 +00:00
2019-12-18 08:57:00 +00:00
2019-11-26 11:51:27 +00:00
2019-09-05 21:41:42 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-12-13 15:03:18 +00:00
2019-07-10 22:20:10 +00:00
2019-11-14 19:11:38 +00:00
2019-11-14 19:11:38 +00:00
2019-11-15 00:15:32 +00:00
2019-12-18 08:57:00 +00:00
2019-01-11 20:47:10 +00:00
2019-01-11 20:47:10 +00:00
2019-06-18 17:51:10 +00:00
2018-11-09 01:58:54 +00:00
2019-01-15 22:07:51 +00:00
2018-11-09 01:58:54 +00:00
2018-11-09 01:58:54 +00:00
2019-01-11 20:47:10 +00:00
2019-04-16 20:56:39 +00:00
2019-06-18 17:51:10 +00:00
2019-12-04 14:26:48 +00:00
2019-06-18 17:51:10 +00:00
2019-07-23 10:58:11 +00:00
2019-07-23 10:58:11 +00:00
2019-01-11 20:47:10 +00:00
2019-01-11 20:47:10 +00:00
2019-01-25 16:45:13 +00:00
2019-01-25 16:45:13 +00:00
2019-10-21 16:26:39 +00:00
2019-12-16 18:32:23 +00:00
2019-12-10 15:28:45 +00:00
2018-11-29 22:06:20 +00:00
2019-12-11 19:36:18 +00:00
2019-10-18 01:33:03 +00:00
2019-03-13 23:44:11 +00:00
2019-12-07 00:28:15 +00:00
2019-12-13 00:41:46 +00:00
2019-12-13 00:41:46 +00:00
2019-10-09 21:48:20 +00:00
2019-09-05 10:36:13 +00:00
2019-10-29 23:39:36 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-07-10 22:20:10 +00:00
2019-12-18 01:02:05 +00:00
2019-10-27 18:18:29 +00:00
2019-04-22 20:15:43 +00:00
2019-04-22 20:15:43 +00:00
2019-04-22 20:15:43 +00:00
2019-12-11 10:00:29 +00:00
2019-12-11 18:15:27 +00:00
2019-01-11 20:47:10 +00:00
2019-10-17 17:19:32 +00:00
2019-06-17 13:09:50 +00:00
2019-06-17 13:09:50 +00:00
2019-03-15 22:35:25 +00:00
2019-03-15 22:35:25 +00:00
2019-09-24 15:03:19 +00:00
2019-12-17 11:14:19 +00:00
2019-12-17 11:14:19 +00:00
2019-09-24 15:03:19 +00:00
2019-03-12 20:45:45 +00:00
2019-12-10 12:26:05 +00:00
2019-07-30 23:26:28 +00:00
2019-10-27 18:18:29 +00:00
2019-05-01 00:36:14 +00:00
2019-03-05 22:32:22 +00:00
2019-10-17 16:51:32 +00:00
2019-10-17 16:51:32 +00:00