Sam Rawlins
04e11b83c0
With this change, CreateMethodOrFunction complies with the contract that `fixKind` not change before/after `compute()` is called. This change includes some tidying to simplify the code: * The decision of whether to use `DartFixKind.CREATE_METHOD` or `DartFixKind.CREATE_FUNCTION` is solely based on whether the "target element" is an InterfaceElement. So in the new factory constructor, we compute the "target element", and save that in a final field, as well as the fixKind. * `isStatic` was computed eagerly with other variables in a nest of else-if bodies. But it is only needed when creating a _method_, and so it's value can be computed nearer to where it is used. * `compute()` was ~100 lines long, and a lot of that code was dedicated to computing the parameter type. Intermediate values like `argument` and `parameterElement` sort of clutter the local variables; all of that code can be moved to a function that just computes the parameter type. Change-Id: Ibd5d96b752e7e03e52f585bb594c34331b08cdf1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/436861 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.