Tess Strickland
e7d3a6027c
Creates HasParent() as a predicate for Function objects with a non-null parent function and makes IsLocalFunction() specific to local closures (i.e. explicit closures with non-null parent functions). Creates HasSavedArgumentsDescriptor() as a predicate to determine when saved_args_desc() can be used, to avoid the caller having to do explicit predicate checks for each dispatcher type that contains one. Also simplifies Function::PrintName, creates different suffixes for a SyncGenClosureMaker and its associateed SyncGenClosure, adds suffixes for skipping more than one generated body when printing the parent name, and changes ArgumentsDescriptor::PrintTo to match the compact syntax Function::PrintName used for signifying the arguments descriptor for certain dispatchers. TEST=pkg/vm_snapshot_analysis/test/instruction_sizes_test Cq-Include-Trybots: luci.dart.try:app-kernel-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,pkg-linux-release-try Change-Id: I0ac1226d1ffe1d81743b5c6788da170d5a4010c5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191560 Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency