dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
030b79dc1c38dddd347fdaab2ca1f092aa92eefe
sdk/pkg/analysis_server/test
T
History
Danny Tuppeny d3c06c4822 [analysis_server] Fix handling of semantic tokens when roots are being built 
This fixes https://github.com/dart-lang/sdk/issues/55889 which is repeat of https://github.com/Dart-Code/Dart-Code/issues/3929 (but semantic tokens was not fixed with that CL).

The issue was when the server was initialized with no roots (for example an empty workspace) and then a new file opened with requests being sent immediately before the roots were updated.

The fix changes from directly calling `server.getResolvedUnit` to instead using `requireResolvedUnit` which handles this situation by waiting for any in-progress context changes and retries.

Fixes https://github.com/dart-lang/sdk/issues/55889

Change-Id: Id078947e5c6665b2afb9e31adc244f16987870f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2024-06-03 15:45:56 +00:00
..
analysis
[analysis_server] Add highlights/semantic tokens for augmented()
2024-05-28 19:39:16 +00:00
channel
Implement the legacy protocol for showing messages and URIs to users
2023-03-24 18:10:17 +00:00
client
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
edit
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
integration
CQ. Enable unnecessary_final in analysis_server/
2024-05-16 21:20:28 +00:00
lsp
[analysis_server] Fix handling of semantic tokens when roots are being built
2024-06-03 15:45:56 +00:00
lsp_over_legacy
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
plugin
Legacy. Remove 'withNullability' parameters from analysis_server/ functions.
2024-02-06 20:19:48 +00:00
search
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
services
linter: Make some allowances in avoid_catches_without_on_clauses
2024-05-28 18:36:58 +00:00
src
quick fix for FINAL_ENUM
2024-06-03 14:56:29 +00:00
stress
CQ. Enable unnecessary_final in analysis_server/
2024-05-16 21:20:28 +00:00
support
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
timing
Remove support for the older legacy completion protocol
2023-12-12 00:54:48 +00:00
tool
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
utilities
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
utils
CQ. Enable unnecessary_final in analysis_server/
2024-05-16 21:20:28 +00:00
abstract_context.dart
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
abstract_single_unit.dart
[analysis_server] Bump yaml_edit, remove ignore_diagnostic workaround
2024-02-21 21:32:32 +00:00
analysis_abstract.dart
…
analysis_options.yaml
DAS: Add a test-directory-specific analysis options file
2024-05-10 15:16:40 +00:00
analysis_server_base.dart
Macro. Send dart/textDocumentContentDidChange before analysis.errors
2024-04-03 00:03:19 +00:00
analysis_server_test.dart
[dartdev]/[analysis_server] Report server errors to "dart analyze" to prevent misleading output for parse/analysis exceptions
2024-05-28 19:10:40 +00:00
benchmarks_test.dart
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
completion_test_support.dart
Remove support for the older legacy completion protocol
2023-12-12 00:54:48 +00:00
constants.dart
…
domain_analysis_test.dart
fix pubspec analysis for multi-options contexts
2024-05-06 23:41:32 +00:00
domain_completion_test.dart
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
domain_completion_util.dart
Remove support for the older legacy completion protocol
2023-12-12 00:54:48 +00:00
domain_diagnostic_test.dart
…
domain_execution_test.dart
enable flutter_style_todos in server
2023-11-14 21:08:12 +00:00
domain_server_test.dart
[analysis_server] Add a supportsUris client capability for legacy server to switch into URI mode
2024-02-01 22:19:00 +00:00
mocks_lsp.dart
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
mocks.dart
analyzer: Move the Source class to be public API.
2023-11-14 17:10:37 +00:00
protocol_server_test.dart
analyzer: Move the Source class to be public API.
2023-11-14 17:10:37 +00:00
protocol_test.dart
…
socket_server_test.dart
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
test_all.dart
[analysis_server] Remove redundant solo_test tests
2024-05-22 16:34:31 +00:00
test_macros.dart
Macro. Report a diagnostic if not allowed declaration, ignore the code.
2024-05-10 15:42:25 +00:00
verify_error_fix_status_test.dart
Introduce first presubmit check for analyzer team.
2023-10-16 16:42:24 +00:00
verify_no_utf8_encode_test.dart
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00
verify_sorted_test.dart
Delete the migration tool
2023-11-20 18:53:00 +00:00
verify_tests_test.dart
Enable 'unnecessary_final' in analysis_server/.
2024-04-16 20:04:15 +00:00