rnystrom@google.com
0f9bed70a5
- Show the contents of their package. - Let the confirm the upload even if there are no warnings. - Make the error/warning text less scary. - Validate that the pubspec has a version client-side. Addresses #7175 and #7219. Review URL: https://codereview.chromium.org//11557008 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16068 260f80e4-7a28-3924-810f-c04153c831b5
79 lines
2.7 KiB
Dart
79 lines
2.7 KiB
Dart
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
library validator;
|
|
|
|
import 'entrypoint.dart';
|
|
import 'log.dart' as log;
|
|
import 'io.dart';
|
|
import 'system_cache.dart';
|
|
import 'utils.dart';
|
|
import 'validator/lib.dart';
|
|
import 'validator/license.dart';
|
|
import 'validator/name.dart';
|
|
import 'validator/pubspec_field.dart';
|
|
|
|
/// The base class for validators that check whether a package is fit for
|
|
/// uploading. Each validator should override [errors], [warnings], or both to
|
|
/// return lists of errors or warnings to display to the user. Errors will cause
|
|
/// the package not to be uploaded; warnings will require the user to confirm
|
|
/// the upload.
|
|
abstract class Validator {
|
|
/// The entrypoint that's being validated.
|
|
final Entrypoint entrypoint;
|
|
|
|
/// The accumulated errors for this validator. Filled by calling [validate].
|
|
final errors = <String>[];
|
|
|
|
/// The accumulated warnings for this validator. Filled by calling [validate].
|
|
final warnings = <String>[];
|
|
|
|
Validator(this.entrypoint);
|
|
|
|
/// Validates the entrypoint, adding any errors and warnings to [errors] and
|
|
/// [warnings], respectively.
|
|
Future validate();
|
|
|
|
/// Run all validators on the [entrypoint] package and print their results.
|
|
/// The future will complete with the error and warning messages,
|
|
/// respectively.
|
|
static Future<Pair<List<String>, List<String>>> runAll(
|
|
Entrypoint entrypoint) {
|
|
var validators = [
|
|
new LibValidator(entrypoint),
|
|
new LicenseValidator(entrypoint),
|
|
new NameValidator(entrypoint),
|
|
new PubspecFieldValidator(entrypoint)
|
|
];
|
|
|
|
// TODO(nweiz): The sleep 0 here forces us to go async. This works around
|
|
// 3356, which causes a bug if all validators are (synchronously) using
|
|
// Future.immediate and an error is thrown before a handler is set up.
|
|
return sleep(0).chain((_) {
|
|
return Futures.wait(validators.map((validator) => validator.validate()));
|
|
}).transform((_) {
|
|
var errors = flatten(validators.map((validator) => validator.errors));
|
|
var warnings = flatten(validators.map((validator) => validator.warnings));
|
|
|
|
if (!errors.isEmpty) {
|
|
log.error("Missing requirements:");
|
|
for (var error in errors) {
|
|
log.error("* ${Strings.join(error.split('\n'), '\n ')}");
|
|
}
|
|
log.error("");
|
|
}
|
|
|
|
if (!warnings.isEmpty) {
|
|
log.warning("Suggestions:");
|
|
for (var warning in warnings) {
|
|
log.warning("* ${Strings.join(warning.split('\n'), '\n ')}");
|
|
}
|
|
log.warning("");
|
|
}
|
|
|
|
return new Pair<List<String>, List<String>>(errors, warnings);
|
|
});
|
|
}
|
|
}
|