Sam Rawlins
006751327d
I noticed, when running `dart analyze`, that when `pub upgrade` could not be run in a plugin directory, we would get the "An error occurred while setting up ..." message (good), but then the plugin would still be executed! And this message would get printed: > An unexpected error was encountered by the Analysis Server. > Please file an issue at https://github.com/dart-lang/sdk/issues/new/choose with the following details: > > Internal error: Issue stopping a plugin > Bad state: Cannot stop a plugin that is not running. The reason is that a PluginException was _only_ thrown, on line 560, if the package config file was still _missing_. But in my case, the plugin directory was pre-existing, from an earlier, successful run, and so the package config file existed! So no exception was thrown, and the server still attempted to run the plugin. So this CL makes that whole situation much simpler, and in particular removes the erroneous "An unexpected error was encountered by the Analysis Server" message that we do not want to show to users, and an extra stack trace. Change-Id: I9be39d10b687e055392f9b81285c99cca4c57534 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453140 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
This directory contains sources for the "prototype" plugin system introduced
circa 2017, which is being replaced by the "new" plugin system introduced
circa 2024. The sources for the "new" plugin system are located in ../plugin2.