Nicholas Shahan
c2a879e41d
The existing usage will no longer work as expected once the security measures to prevent native Object prototype pollution are enabled. The recommended replacements are `Object.getPrototypeOf()` and `Object.setPrototypeOf()`. Change-Id: I0617233bd31ccd2afc9f94c527eecb31c5f1b340 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330047 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>
116 lines
2.7 KiB
Dart
116 lines
2.7 KiB
Dart
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import "native_testing.dart";
|
|
|
|
// Test to see if resolving a hidden native class's method interferes with
|
|
// subsequent resolving the subclass's method. This might happen if the
|
|
// superclass caches the method in the prototype, so shadowing the dispatcher
|
|
// stored on Object.prototype.
|
|
|
|
// Version 1: It might be possible to call foo directly.
|
|
@Native("A1")
|
|
class A1 {
|
|
foo() native;
|
|
}
|
|
|
|
@Native("B1")
|
|
class B1 extends A1 {
|
|
foo() native;
|
|
}
|
|
|
|
makeA1() native;
|
|
makeB1() native;
|
|
|
|
// Version 2: foo needs some kind of trampoline.
|
|
@Native("A2")
|
|
class A2 {
|
|
foo([a = 99]) native;
|
|
}
|
|
|
|
@Native("B2")
|
|
class B2 extends A2 {
|
|
foo([z = 1000]) native;
|
|
}
|
|
|
|
makeA2() native;
|
|
makeB2() native;
|
|
|
|
void setup() {
|
|
JS('', r"""
|
|
(function(){
|
|
// This code is inside 'setup' and so not accessible from the global scope.
|
|
function inherits(child, parent) {
|
|
if (Object.getPrototypeOf(child.prototype)) {
|
|
Object.setPrototypeOf(child.prototype, parent.prototype);
|
|
} else {
|
|
function tmp() {};
|
|
tmp.prototype = parent.prototype;
|
|
child.prototype = new tmp();
|
|
child.prototype.constructor = child;
|
|
}
|
|
}
|
|
function A1(){}
|
|
function B1(){}
|
|
inherits(B1, A1);
|
|
A1.prototype.foo = function(){return 100;};
|
|
B1.prototype.foo = function(){return 200;};
|
|
|
|
self.makeA1 = function(){return new A1()};
|
|
self.makeB1 = function(){return new B1()};
|
|
|
|
function A2(){}
|
|
function B2(){}
|
|
inherits(B2, A2);
|
|
A2.prototype.foo = function(a){return a + 10000;};
|
|
B2.prototype.foo = function(z){return z + 20000;};
|
|
|
|
self.makeA2 = function(){return new A2()};
|
|
self.makeB2 = function(){return new B2()};
|
|
|
|
self.nativeConstructor(A1);
|
|
self.nativeConstructor(A2);
|
|
self.nativeConstructor(B1);
|
|
self.nativeConstructor(B2);
|
|
})()""");
|
|
applyTestExtensions(['A1', 'A2', 'B1', 'B2']);
|
|
}
|
|
|
|
main() {
|
|
nativeTesting();
|
|
setup();
|
|
|
|
var a1 = makeA1();
|
|
var b1 = makeB1();
|
|
Expect.equals(100, a1.foo());
|
|
Expect.equals(200, b1.foo());
|
|
|
|
var a2 = makeA2();
|
|
var b2 = makeB2();
|
|
Expect.equals(10000 + 99, a2.foo());
|
|
Expect.equals(20000 + 1000, b2.foo());
|
|
|
|
Expect.equals(10000 + 1, a2.foo(1));
|
|
Expect.equals(20000 + 2, b2.foo(2));
|
|
|
|
bool caught = false;
|
|
try {
|
|
a1.foo(20);
|
|
} catch (ex) {
|
|
caught = true;
|
|
Expect.isTrue(ex is NoSuchMethodError);
|
|
}
|
|
Expect.isTrue(caught, 'a1.foo(20) should throw');
|
|
|
|
caught = false;
|
|
try {
|
|
dynamic x = 123;
|
|
x.foo(20);
|
|
} catch (ex) {
|
|
caught = true;
|
|
Expect.isTrue(ex is NoSuchMethodError);
|
|
}
|
|
Expect.isTrue(caught, "x.foo(20) should throw");
|
|
}
|