Konstantin Shcheglov
51003df5c3
Centralize diagnostics for illegal constructor/method bodies in
ErrorVerifier instead of reporting them from the AST builder and Fasta
error conversion.
This consolidates several overlapping checks and fixes inconsistent
error locations (for example, reporting at `external`/`const` instead of
at `{`/`=>`).
Key changes:
- Remove constructor-body validation from AstBuilder (const bodies, const
factories) and stop converting the corresponding Fasta codes to analyzer
diagnostics to avoid duplicate reporting.
- Add a single verifier entry point that validates whether a body is allowed
based on:
- factory vs generative
- const vs non-const
- external vs non-external
- redirecting vs non-redirecting
- Reuse the same validation for both regular constructors and primary
constructors, and report at the body token for stable source ranges.
- Add a shared check for `external` functions/methods with block or expression
bodies, and apply it consistently to top-level functions and class members.
- Align expectation files to the new, body-based error ranges and remove
formatter-crash classification where the new reporting no longer triggers it.
Change-Id: Ie91ea08a7b5505d3e6443b12317c45359bac1c2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/477780
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
105 lines
3.4 KiB
Dart
105 lines
3.4 KiB
Dart
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
class Bar {
|
|
Bar(val);
|
|
}
|
|
|
|
class Foo {
|
|
// ^
|
|
// [cfe] The non-abstract class 'Foo' is missing implementations for these members:
|
|
var x = -1;
|
|
f() {}
|
|
|
|
Foo() : x = 0;
|
|
//^^^
|
|
// [analyzer] COMPILE_TIME_ERROR.NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD
|
|
// [cfe] This constructor should initialize field 'external' because its type 'int' doesn't allow null.
|
|
|
|
external var x01;
|
|
external int x02;
|
|
|
|
external f11() { }
|
|
// ^
|
|
// [analyzer] SYNTACTIC_ERROR.EXTERNAL_METHOD_WITH_BODY
|
|
// [cfe] An external or native method can't have a body.
|
|
external f12() => 1;
|
|
// ^^
|
|
// [analyzer] SYNTACTIC_ERROR.EXTERNAL_METHOD_WITH_BODY
|
|
// [cfe] An external or native method can't have a body.
|
|
// ^
|
|
// [cfe] An external or native method can't have a body.
|
|
static external f14();
|
|
// ^^^^^^^^
|
|
// [analyzer] SYNTACTIC_ERROR.MODIFIER_OUT_OF_ORDER
|
|
// [cfe] The modifier 'external' should be before the modifier 'static'.
|
|
int external f16();
|
|
// ^^^^^^^^
|
|
// [analyzer] SYNTACTIC_ERROR.EXPECTED_TOKEN
|
|
// [cfe] Expected ';' after this.
|
|
// ^^^^^^
|
|
// [analyzer] COMPILE_TIME_ERROR.CONCRETE_CLASS_WITH_ABSTRACT_MEMBER
|
|
|
|
external Foo.n21(val) : x = 1;
|
|
// ^
|
|
// [analyzer] SYNTACTIC_ERROR.EXTERNAL_CONSTRUCTOR_WITH_INITIALIZER
|
|
// [cfe] An external constructor can't have any initializers.
|
|
external Foo.n22(val) { x = 1; }
|
|
// ^
|
|
// [analyzer] SYNTACTIC_ERROR.EXTERNAL_METHOD_WITH_BODY
|
|
// [cfe] An external or native method can't have a body.
|
|
external factory Foo.n23(val) => new Foo();
|
|
// ^^
|
|
// [analyzer] SYNTACTIC_ERROR.EXTERNAL_FACTORY_WITH_BODY
|
|
// [cfe] External factories can't have a body.
|
|
// ^
|
|
// [cfe] An external or native method can't have a body.
|
|
external Foo.n24(this.x);
|
|
// ^^^^
|
|
// [analyzer] SYNTACTIC_ERROR.EXTERNAL_CONSTRUCTOR_WITH_FIELD_INITIALIZERS
|
|
// ^
|
|
// [cfe] An external constructor can't initialize fields.
|
|
external factory Foo.n25(val) = Bar;
|
|
// ^
|
|
// [analyzer] SYNTACTIC_ERROR.EXTERNAL_FACTORY_REDIRECTION
|
|
// [cfe] A redirecting factory can't be external.
|
|
// ^^^
|
|
// [analyzer] COMPILE_TIME_ERROR.REDIRECT_TO_INVALID_RETURN_TYPE
|
|
// [cfe] The constructor function type 'Bar Function(dynamic)' isn't a subtype of 'Foo Function(dynamic)'.
|
|
}
|
|
|
|
external int t06(int i) { return 1; }
|
|
// ^
|
|
// [analyzer] SYNTACTIC_ERROR.EXTERNAL_METHOD_WITH_BODY
|
|
// [error column 1, length 8]
|
|
// [cfe] An external or native method can't have a body.
|
|
// ^
|
|
// [cfe] An external or native method can't have a body.
|
|
external int t07(int i) => i + 1;
|
|
// ^^
|
|
// [analyzer] SYNTACTIC_ERROR.EXTERNAL_METHOD_WITH_BODY
|
|
// [error column 1, length 8]
|
|
// [cfe] An external or native method can't have a body.
|
|
// ^
|
|
// [cfe] An external or native method can't have a body.
|
|
|
|
main() {
|
|
// Ensure Foo class is compiled.
|
|
var foo = new Foo();
|
|
|
|
new Foo().f11();
|
|
new Foo().f12();
|
|
Foo.f14();
|
|
new Foo().f16();
|
|
|
|
new Foo.n21(1);
|
|
new Foo.n22(1);
|
|
new Foo.n23(1);
|
|
new Foo.n24(1);
|
|
new Foo.n25(1);
|
|
|
|
t06(1);
|
|
t07(1);
|
|
}
|