Tess Strickland
6b53073eae
This is a reland of commit 38ef28a058
Fixes:
* Fix comparisons in ASSERT_EQUAL statements on 32-bit architectures.
* Take simulated architectures into account when deciding whether
to use dlopen() for native shared object formats.
* Fix struct/field name collision for GCC.
* Use CPU_TYPE_ANY/CPU_SUBTYPE_ANY for architectures that do not
have more specific cpu_type_t/cpu_subtype_t constants defined.
Original change's description:
> [vm, gen_snapshot] Add app-aot-macho-dylib option for AOT snapshots.
>
> This is the initial framework for creating snapshots as Mach-O dynamic
> libraries. Note that this framework is not 100% feature complete
> compared to generating Mach-O snapshots via assembly. In particular,
> the directly-compiled Mach-O dylib does not yet contain compact
> unwinding information.
>
> Other changes:
>
> * Adds UuidCommand to the native_stack_traces package's Mach-O reader,
> which now appropriately returns the UUID as the build ID for Mach-O
> shared objects.
>
> * Adds Utils::Basename(path) for portably retrieving the basename
> from a path. (Returns nullptr for all arguments where it is not
> currently implemented on Fuchsia or Windows.)
>
> * Adjusts vm/timeline.h to avoid pulling in <mach_o/loader.h> on MacOS,
> as that interferes with uses of the namespaced Mach-O definitions
> in platform/mach_o.h.
>
> * Only attempt to dlopen() a snapshot if ELF is the native format
> for the host platform or the snapshot is not an ELF shared object.
> If dlopen() is used, report the error message if it fails rather
> than attempting to manually load the snapshot as an ELF shared object.
>
> * Fix the magic number stored in DylibAppSnapshot for loaded non-ELF
> dynamic libraries.
>
> * Remove the detection of reverse-endian Mach-O magic numbers in
> DartUtils::SniffForMagicNumber(), since all our Mach-O related code
> assumes host-endian Mach-O files and so there's no point other than
> to give a slightly better error message when failing.
>
> TEST=vm/dart/exported_symbols_test
> vm/dart/unobfuscated_static_symbols_test
> vm/dart/use_dwarf_stack_traces_flag_test
> vm/cc/CanDetectMachOFiles
>
> Issue: https://github.com/dart-lang/sdk/issues/60307
> Change-Id: Idf5b49d6c6d035ab033509613212b95520d65965
> Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-x64-try,vm-mac-release-arm64-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-dwarf-linux-product-x64-try,vm-linux-debug-x64-try,vm-mac-debug-arm64-try,vm-fuchsia-release-x64-try,vm-fuchsia-release-arm64-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415020
> Reviewed-by: Slava Egorov <vegorov@google.com>
> Commit-Queue: Tess Strickland <sstrickl@google.com>
TEST=vm/dart/exported_symbols_test
vm/dart/unobfuscated_static_symbols_test
vm/dart/use_dwarf_stack_traces_flag_test
vm/cc/CanDetectMachOFiles
ci on trybots that failed on the original CL
Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-x64-try,vm-mac-release-arm64-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-dwarf-linux-product-x64-try,vm-linux-debug-x64-try,vm-mac-debug-arm64-try,vm-fuchsia-release-x64-try,vm-fuchsia-release-arm64-try,vm-linux-debug-ia32-try,vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-debug-simriscv32-try,vm-aot-linux-debug-simriscv64-try,vm-aot-linux-release-simarm_x64-try,vm-gcc-linux-try,vm-ubsan-linux-release-arm64-try
Change-Id: Iaffea0ddc6173100c8b5b2a9fe46c45f4f611a2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431240
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
80 lines
2.5 KiB
C++
80 lines
2.5 KiB
C++
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/globals.h"
|
|
#if defined(DART_HOST_OS_MACOS) && defined(SUPPORT_TIMELINE)
|
|
|
|
#include <os/signpost.h>
|
|
|
|
#include "vm/log.h"
|
|
#include "vm/timeline.h"
|
|
|
|
namespace dart {
|
|
|
|
TimelineEventMacosRecorder::TimelineEventMacosRecorder()
|
|
: TimelineEventPlatformRecorder() {
|
|
Timeline::set_recorder_discards_clock_values(true);
|
|
}
|
|
|
|
TimelineEventMacosRecorder::~TimelineEventMacosRecorder() {}
|
|
|
|
void TimelineEventMacosRecorder::OnEvent(TimelineEvent* event) {
|
|
if (event == nullptr) {
|
|
return;
|
|
}
|
|
|
|
os_log_t log = event->stream_->macos_log();
|
|
if (!os_signpost_enabled(log)) {
|
|
return;
|
|
}
|
|
|
|
const char* label = event->label();
|
|
bool is_static_label = event->stream_->has_static_labels();
|
|
uint8_t _Alignas(16) buffer[64];
|
|
buffer[0] = 0;
|
|
|
|
switch (event->event_type()) {
|
|
case TimelineEvent::kInstant:
|
|
if (is_static_label) {
|
|
_os_signpost_emit_with_name_impl(&__dso_handle, log, OS_SIGNPOST_EVENT,
|
|
OS_SIGNPOST_ID_EXCLUSIVE, label, "",
|
|
buffer, sizeof(buffer));
|
|
} else {
|
|
os_signpost_event_emit(log, OS_SIGNPOST_ID_EXCLUSIVE, "Event", "%s",
|
|
label);
|
|
}
|
|
break;
|
|
case TimelineEvent::kBegin:
|
|
case TimelineEvent::kAsyncBegin:
|
|
if (is_static_label) {
|
|
_os_signpost_emit_with_name_impl(
|
|
&__dso_handle, log, OS_SIGNPOST_INTERVAL_BEGIN, event->Id(), label,
|
|
"", buffer, sizeof(buffer));
|
|
} else {
|
|
os_signpost_interval_begin(log, event->Id(), "Event", "%s", label);
|
|
}
|
|
break;
|
|
case TimelineEvent::kEnd:
|
|
case TimelineEvent::kAsyncEnd:
|
|
if (is_static_label) {
|
|
_os_signpost_emit_with_name_impl(&__dso_handle, log,
|
|
OS_SIGNPOST_INTERVAL_END, event->Id(),
|
|
label, "", buffer, sizeof(buffer));
|
|
} else {
|
|
os_signpost_interval_end(log, event->Id(), "Event");
|
|
}
|
|
break;
|
|
case TimelineEvent::kCounter:
|
|
os_signpost_event_emit(log, OS_SIGNPOST_ID_EXCLUSIVE, "Counter", "%s=%s",
|
|
label, event->arguments()[0].value);
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined(DART_HOST_OS_MACOS) && defined(SUPPORT_TIMELINE)
|