Daco Harkes
f98a2138b7
When uploading CLs, the presubmit checks verify that the lines in the diff are formatted correctly according to `git cl format runtime`. However, when `buildtools/<os>-<arch>/clang/bin/clang-format` is updated, it does not force reformatting of files that would be reformatted. This leads to two issues: * Inconsistent style within the code base and within a single file. * Spurious reformatting in CLs when (1) clang-format is used on the whole file, or (2) the diff lines overlap. `clang-format` doesn't change that frequently, so in general this is not a large issue, but I've seen a bit too many "spurious formatting, please revert" comments on CLs recently. This CL formats the runtime to be in line with the current pinned `clang-format`: ``` $ find runtime/ -iname *.h -o -iname *.cc | xargs buildtools/mac-arm64/clang/bin/clang-format -i ``` `git cl format` (which only formats changed lines, and does so with `clang-format`) seems to not agree with itself, or clang-format, or cpplint in a handful of places. This CL adds `// clang-format off` for these. (See previous patchsets for the specific instances.) TEST=A variety of bots including GCC, MacOS and Windows. Change-Id: I470892e898971899fda14bb3b8f2c8efefd67686 Cq-Include-Trybots: luci.dart.try:vm-gcc-linux-try,vm-ffi-qemu-linux-release-riscv64-try,vm-ffi-qemu-linux-release-arm-try,vm-aot-win-debug-x64-try,vm-win-debug-x64c-try,vm-mac-debug-x64-try,vm-mac-debug-arm64-try,vm-aot-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362780 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
50 lines
1.8 KiB
C++
50 lines
1.8 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "platform/globals.h"
|
|
#if defined(DART_HOST_OS_WINDOWS)
|
|
|
|
#include "platform/floating_point_win.h"
|
|
|
|
#include <limits> // NOLINT
|
|
|
|
// Taken from third_party/v8/src/platform-win32.cc
|
|
double fmod_ieee(double x, double y) {
|
|
// x is dividend, y is divisor.
|
|
// Work around MS fmod bugs. ISO Standard says:
|
|
// If dividend is finite and divisor is an infinity or
|
|
// dividend is a zero and divisor is nonzero finite,
|
|
// then dividend is returned.
|
|
if (!(_finite(x) && (!_finite(y) && !isnan(y))) &&
|
|
!(x == 0 && (y != 0 && _finite(y)))) {
|
|
x = fmod(x, y);
|
|
}
|
|
return x;
|
|
}
|
|
|
|
// Bring MSVC atan2 behavior in line with ISO standard.
|
|
// MSVC atan2 returns NaN when x and y are either +infinity or -infinity.
|
|
// Per ISO standard:
|
|
// - If y is +/-infinity and x is -infinity, +/-3*pi/4 is returned.
|
|
// - If y is +/-infinity and x is +infinity, +/-pi/4 is returned.
|
|
double atan2_ieee(double x, double y) {
|
|
int cls_x = _fpclass(x);
|
|
int cls_y = _fpclass(y);
|
|
if (((cls_x & (_FPCLASS_PINF | _FPCLASS_NINF)) != 0) &&
|
|
((cls_y & (_FPCLASS_PINF | _FPCLASS_NINF)) != 0)) {
|
|
// atan2 values at infinities listed above are the same as values at (+/-1,
|
|
// +/-1). index_x is 0, when x is +infinity, 1 when x is -infinity. Same is
|
|
// with index_y.
|
|
int index_x = (cls_x & _FPCLASS_PINF) != 0 ? 0 : 1;
|
|
int index_y = (cls_y & _FPCLASS_PINF) != 0 ? 0 : 1;
|
|
static double atans_at_infinities[2][2] = {
|
|
{atan2(1., 1.), atan2(1., -1.)}, {atan2(-1., 1.), atan2(-1., -1.)}};
|
|
return atans_at_infinities[index_x][index_y];
|
|
} else {
|
|
return atan2(x, y);
|
|
}
|
|
}
|
|
|
|
#endif // defined(DART_HOST_OS_WINDOWS)
|