Daco Harkes
f98a2138b7
When uploading CLs, the presubmit checks verify that the lines in the diff are formatted correctly according to `git cl format runtime`. However, when `buildtools/<os>-<arch>/clang/bin/clang-format` is updated, it does not force reformatting of files that would be reformatted. This leads to two issues: * Inconsistent style within the code base and within a single file. * Spurious reformatting in CLs when (1) clang-format is used on the whole file, or (2) the diff lines overlap. `clang-format` doesn't change that frequently, so in general this is not a large issue, but I've seen a bit too many "spurious formatting, please revert" comments on CLs recently. This CL formats the runtime to be in line with the current pinned `clang-format`: ``` $ find runtime/ -iname *.h -o -iname *.cc | xargs buildtools/mac-arm64/clang/bin/clang-format -i ``` `git cl format` (which only formats changed lines, and does so with `clang-format`) seems to not agree with itself, or clang-format, or cpplint in a handful of places. This CL adds `// clang-format off` for these. (See previous patchsets for the specific instances.) TEST=A variety of bots including GCC, MacOS and Windows. Change-Id: I470892e898971899fda14bb3b8f2c8efefd67686 Cq-Include-Trybots: luci.dart.try:vm-gcc-linux-try,vm-ffi-qemu-linux-release-riscv64-try,vm-ffi-qemu-linux-release-arm-try,vm-aot-win-debug-x64-try,vm-win-debug-x64c-try,vm-mac-debug-x64-try,vm-mac-debug-arm64-try,vm-aot-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362780 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
110 lines
3.0 KiB
C++
110 lines
3.0 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "platform/globals.h"
|
|
#if defined(DART_HOST_OS_MACOS)
|
|
|
|
#include <errno.h> // NOLINT
|
|
#include <mach/clock.h> // NOLINT
|
|
#include <mach/mach.h> // NOLINT
|
|
#include <mach/mach_time.h> // NOLINT
|
|
#include <netdb.h> // NOLINT
|
|
#include <sys/time.h> // NOLINT
|
|
#include <time.h> // NOLINT
|
|
|
|
#include "bin/utils.h"
|
|
#include "platform/assert.h"
|
|
#include "platform/utils.h"
|
|
|
|
namespace dart {
|
|
namespace bin {
|
|
|
|
OSError::OSError() : sub_system_(kSystem), code_(0), message_(nullptr) {
|
|
Reload();
|
|
}
|
|
|
|
void OSError::Reload() {
|
|
SetCodeAndMessage(kSystem, errno);
|
|
}
|
|
|
|
void OSError::SetCodeAndMessage(SubSystem sub_system, int code) {
|
|
set_sub_system(sub_system);
|
|
set_code(code);
|
|
if (sub_system == kSystem) {
|
|
const int kBufferSize = 1024;
|
|
char error_message[kBufferSize];
|
|
Utils::StrError(code, error_message, kBufferSize);
|
|
SetMessage(error_message);
|
|
} else if (sub_system == kGetAddressInfo) {
|
|
SetMessage(gai_strerror(code));
|
|
} else {
|
|
UNREACHABLE();
|
|
}
|
|
}
|
|
|
|
const char* StringUtils::ConsoleStringToUtf8(const char* str,
|
|
intptr_t len,
|
|
intptr_t* result_len) {
|
|
return nullptr;
|
|
}
|
|
|
|
const char* StringUtils::Utf8ToConsoleString(const char* utf8,
|
|
intptr_t len,
|
|
intptr_t* result_len) {
|
|
return nullptr;
|
|
}
|
|
|
|
char* StringUtils::ConsoleStringToUtf8(char* str,
|
|
intptr_t len,
|
|
intptr_t* result_len) {
|
|
return nullptr;
|
|
}
|
|
|
|
char* StringUtils::Utf8ToConsoleString(char* utf8,
|
|
intptr_t len,
|
|
intptr_t* result_len) {
|
|
return nullptr;
|
|
}
|
|
|
|
bool ShellUtils::GetUtf8Argv(int argc, char** argv) {
|
|
return false;
|
|
}
|
|
|
|
void TimerUtils::InitOnce() {}
|
|
|
|
int64_t TimerUtils::GetCurrentMonotonicMillis() {
|
|
return GetCurrentMonotonicMicros() / 1000;
|
|
}
|
|
|
|
int64_t TimerUtils::GetCurrentMonotonicMicros() {
|
|
return clock_gettime_nsec_np(CLOCK_MONOTONIC_RAW) /
|
|
kNanosecondsPerMicrosecond;
|
|
}
|
|
|
|
void TimerUtils::Sleep(int64_t millis) {
|
|
struct timespec req; // requested.
|
|
struct timespec rem; // remainder.
|
|
int64_t micros = millis * kMicrosecondsPerMillisecond;
|
|
int64_t seconds = micros / kMicrosecondsPerSecond;
|
|
micros = micros - seconds * kMicrosecondsPerSecond;
|
|
int64_t nanos = micros * kNanosecondsPerMicrosecond;
|
|
req.tv_sec = seconds;
|
|
req.tv_nsec = nanos;
|
|
while (true) {
|
|
int r = nanosleep(&req, &rem);
|
|
if (r == 0) {
|
|
break;
|
|
}
|
|
// We should only ever see an interrupt error.
|
|
ASSERT(errno == EINTR);
|
|
// Copy remainder into requested and repeat.
|
|
req = rem;
|
|
}
|
|
}
|
|
|
|
} // namespace bin
|
|
} // namespace dart
|
|
|
|
#endif // defined(DART_HOST_OS_MACOS)
|