Ben Konyi
8e00ebc689
google3 makes heavy use of symlinks, with no guarantee that the relative location of files with respect to each other will be maintained after the symlinks are resolved. This causes issues when trying to locate the DartDev snapshot using the VM executables resolved path as a base. This change updates the DartDev snapshot detection logic to first try to find the snapshot using the resolved executable path before falling back to using the unresolved path used to launch the VM (e.g., the path specified by argv[0]). TEST=pkg/dartdev/test/ Change-Id: I19a41c440ac82cbc671dafb3bda23a31fb4cdc0c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370000 Reviewed-by: Derek Xu <derekx@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
44 lines
1.2 KiB
C++
44 lines
1.2 KiB
C++
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_BIN_EXE_UTILS_H_
|
|
#define RUNTIME_BIN_EXE_UTILS_H_
|
|
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include "include/dart_api.h"
|
|
#include "platform/globals.h"
|
|
#include "platform/utils.h"
|
|
|
|
namespace dart {
|
|
namespace bin {
|
|
|
|
class EXEUtils {
|
|
public:
|
|
// Returns the resolved path to the directory the current executable resides
|
|
// in.
|
|
static CStringUniquePtr GetDirectoryPrefixFromResolvedExeName();
|
|
|
|
// Returns the path to the directory the current executable resides
|
|
// in without following symlinks.
|
|
//
|
|
// Returns null if Platform::GetExecutableName() returns null.
|
|
static CStringUniquePtr GetDirectoryPrefixFromUnresolvedExeName();
|
|
|
|
#if !defined(DART_HOST_OS_WINDOWS)
|
|
// Loads a compact symbolization table from "$exepath.sym" that is used by the
|
|
// VM's profiler and crash stack trace dumper to symbolize C frames.
|
|
static void LoadDartProfilerSymbols(const char* exepath);
|
|
#endif
|
|
|
|
private:
|
|
DISALLOW_COPY_AND_ASSIGN(EXEUtils);
|
|
};
|
|
|
|
} // namespace bin
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_BIN_EXE_UTILS_H_
|