a9469269d7
In AOT this makes reading faster: Output from `out/ReleaseX64/dart pkg/front_end/tool/benchmarker.dart --iterations=10 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.1 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.2 --arguments="--warmups=10" --arguments="--iterations=5" --arguments="AstFromBinaryEager" --arguments="out/ReleaseX64/vm_platform_strong.dill"`: ``` msec task-clock:u: -8.6925% +/- 0.5737% (-167.09 +/- 11.03) page-faults:u: 0.1410% +/- 0.0051% (243.00 +/- 8.71) cycles:u: -10.2918% +/- 0.6161% (-732576747.50 +/- 43853449.16) instructions:u: -14.4988% +/- 0.0004% (-1636799813.90 +/- 39902.18) branch-misses:u: -3.4891% +/- 2.1142% (-1166085.00 +/- 706582.35) seconds time elapsed: -8.7005% +/- 0.5634% (-0.17 +/- 0.01) seconds user: -9.9752% +/- 1.5104% (-0.17 +/- 0.03) ``` Stats running manually (run as e.g. `out/ReleaseX64/dart-sdk/bin/dartaotruntime pkg/front_end/test/kernel_binary_bench.aot.1 --warmups=10 --iterations=5 AstFromBinaryEager out/ReleaseX64/vm_platform_strong.dill`): ``` AstFromBinaryEagerCold: -12.5174% +/- 3.10688% AstFromBinaryEagerWarmup: -8.33675% +/- 2.62433% AstFromBinaryEager: -10.3432% +/- 3.68375% ``` I don't expect there to be much of a change (if any) in JIT as the actual type was in practise always Uint8List anyway. TEST=Existing tests. Change-Id: I86b16ed207343848dee2e376f42598c223bbc48f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393740 Reviewed-by: Mayank Patke <fishythefish@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Morgan :) <davidmorgan@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
81 lines
2.4 KiB
Dart
81 lines
2.4 KiB
Dart
// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
import 'dart:io' as io;
|
|
import 'dart:typed_data';
|
|
|
|
import 'package:front_end/src/api_unstable/vm.dart';
|
|
|
|
class HttpAwareFileSystem implements FileSystem {
|
|
FileSystem original;
|
|
|
|
HttpAwareFileSystem(this.original);
|
|
|
|
@override
|
|
FileSystemEntity entityForUri(Uri uri) {
|
|
if (uri.isScheme('http') || uri.isScheme('https')) {
|
|
return new HttpFileSystemEntity(this, uri);
|
|
} else {
|
|
return original.entityForUri(uri);
|
|
}
|
|
}
|
|
}
|
|
|
|
class HttpFileSystemEntity implements FileSystemEntity {
|
|
HttpAwareFileSystem fileSystem;
|
|
Uri uri;
|
|
|
|
HttpFileSystemEntity(this.fileSystem, this.uri);
|
|
|
|
@override
|
|
Future<bool> exists() async {
|
|
return connectAndRun((io.HttpClient httpClient) async {
|
|
io.HttpClientRequest request = await httpClient.headUrl(uri);
|
|
io.HttpClientResponse response = await request.close();
|
|
await response.drain();
|
|
return response.statusCode == io.HttpStatus.ok;
|
|
});
|
|
}
|
|
|
|
@override
|
|
Future<bool> existsAsyncIfPossible() => exists();
|
|
|
|
@override
|
|
Future<Uint8List> readAsBytes() async {
|
|
return connectAndRun((io.HttpClient httpClient) async {
|
|
io.HttpClientRequest request = await httpClient.getUrl(uri);
|
|
io.HttpClientResponse response = await request.close();
|
|
if (response.statusCode != io.HttpStatus.ok) {
|
|
await response.drain();
|
|
throw new FileSystemException(uri, response.toString());
|
|
}
|
|
List<List<int>> list = await response.toList();
|
|
return new Uint8List.fromList(list.expand((list) => list).toList());
|
|
});
|
|
}
|
|
|
|
@override
|
|
Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
|
|
|
|
@override
|
|
Future<String> readAsString() async {
|
|
return String.fromCharCodes(await readAsBytes());
|
|
}
|
|
|
|
Future<T> connectAndRun<T>(Future<T> body(io.HttpClient httpClient)) async {
|
|
io.HttpClient? httpClient;
|
|
try {
|
|
httpClient = new io.HttpClient();
|
|
// Set timeout to be shorter than anticipated OS default
|
|
httpClient.connectionTimeout = const Duration(seconds: 5);
|
|
return await body(httpClient);
|
|
} on Exception catch (e) {
|
|
throw new FileSystemException(uri, e.toString());
|
|
} finally {
|
|
httpClient?.close(force: true);
|
|
}
|
|
}
|
|
}
|