Brian Wilkerson
a16de199d7
This is a rediculously large CL, and if you want me to split it up I'm willing to do so. However, the changes were all made by running a script I wrote and then running the formatter over the code, so hopefully a spot-check will be sufficient. Change-Id: Ifc59b2cc3bf9e4edf0229a130cd587dc73f95615 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505042 Reviewed-by: Samuel Rawlins <srawlins@google.com> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
54 lines
1.1 KiB
Dart
54 lines
1.1 KiB
Dart
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:test_reflective_loader/test_reflective_loader.dart';
|
|
|
|
import '../rule_test_support.dart';
|
|
|
|
void main() {
|
|
defineReflectiveSuite(() {
|
|
defineReflectiveTests(AvoidUnnecessaryContainersTest);
|
|
});
|
|
}
|
|
|
|
@reflectiveTest
|
|
class AvoidUnnecessaryContainersTest extends LintRuleTest {
|
|
@override
|
|
bool get addFlutterPackageDep => true;
|
|
|
|
@override
|
|
String get lintRule => LintNames.avoid_unnecessary_containers;
|
|
|
|
test_childOnly() async {
|
|
await assertDiagnosticsFromMarkdown(r'''
|
|
import 'package:flutter/widgets.dart';
|
|
Widget f() {
|
|
return [!Container!](child: Row());
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_noArguments() async {
|
|
await assertNoDiagnostics(r'''
|
|
import 'package:flutter/widgets.dart';
|
|
Widget f() {
|
|
return Container();
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_otherArguments() async {
|
|
await assertNoDiagnostics(r'''
|
|
import 'package:flutter/widgets.dart';
|
|
Widget f() {
|
|
return Container(
|
|
child: Row(),
|
|
width: 10,
|
|
height: 10,
|
|
);
|
|
}
|
|
''');
|
|
}
|
|
}
|