a9469269d7
In AOT this makes reading faster: Output from `out/ReleaseX64/dart pkg/front_end/tool/benchmarker.dart --iterations=10 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.1 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.2 --arguments="--warmups=10" --arguments="--iterations=5" --arguments="AstFromBinaryEager" --arguments="out/ReleaseX64/vm_platform_strong.dill"`: ``` msec task-clock:u: -8.6925% +/- 0.5737% (-167.09 +/- 11.03) page-faults:u: 0.1410% +/- 0.0051% (243.00 +/- 8.71) cycles:u: -10.2918% +/- 0.6161% (-732576747.50 +/- 43853449.16) instructions:u: -14.4988% +/- 0.0004% (-1636799813.90 +/- 39902.18) branch-misses:u: -3.4891% +/- 2.1142% (-1166085.00 +/- 706582.35) seconds time elapsed: -8.7005% +/- 0.5634% (-0.17 +/- 0.01) seconds user: -9.9752% +/- 1.5104% (-0.17 +/- 0.03) ``` Stats running manually (run as e.g. `out/ReleaseX64/dart-sdk/bin/dartaotruntime pkg/front_end/test/kernel_binary_bench.aot.1 --warmups=10 --iterations=5 AstFromBinaryEager out/ReleaseX64/vm_platform_strong.dill`): ``` AstFromBinaryEagerCold: -12.5174% +/- 3.10688% AstFromBinaryEagerWarmup: -8.33675% +/- 2.62433% AstFromBinaryEager: -10.3432% +/- 3.68375% ``` I don't expect there to be much of a change (if any) in JIT as the actual type was in practise always Uint8List anyway. TEST=Existing tests. Change-Id: I86b16ed207343848dee2e376f42598c223bbc48f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393740 Reviewed-by: Mayank Patke <fishythefish@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Morgan :) <davidmorgan@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
72 lines
1.6 KiB
Dart
72 lines
1.6 KiB
Dart
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:io';
|
|
import 'dart:typed_data';
|
|
|
|
import 'package:kernel/binary/ast_from_binary.dart';
|
|
import 'package:kernel/kernel.dart';
|
|
|
|
import 'find_sdk_dills.dart';
|
|
|
|
void main() {
|
|
List<File> dills = findSdkDills();
|
|
print("Found ${dills.length} dills!");
|
|
|
|
List<File> errors = [];
|
|
for (File dill in dills) {
|
|
if (!tryFile(dill)) {
|
|
errors.add(dill);
|
|
}
|
|
}
|
|
if (errors.isEmpty) {
|
|
print("All OK.");
|
|
} else {
|
|
print("Errors when reading:");
|
|
for (File error in errors) {
|
|
print(error);
|
|
}
|
|
exitCode = 1;
|
|
}
|
|
}
|
|
|
|
bool tryFile(File dill) {
|
|
print("Reading $dill");
|
|
Uint8List bytes = dill.readAsBytesSync();
|
|
|
|
try {
|
|
Component component = new Component();
|
|
new BinaryBuilderWithMetadata(bytes).readComponent(component);
|
|
LocationTester tester = new LocationTester();
|
|
component.accept(tester);
|
|
return tester.ok;
|
|
} catch (e, st) {
|
|
print("Error for $dill:");
|
|
print(e);
|
|
print(st);
|
|
print("");
|
|
print("--------------------");
|
|
print("");
|
|
return false;
|
|
}
|
|
}
|
|
|
|
class LocationTester extends RecursiveVisitor {
|
|
bool ok = true;
|
|
|
|
@override
|
|
void defaultTreeNode(TreeNode node) {
|
|
super.defaultTreeNode(node);
|
|
try {
|
|
node.location;
|
|
} catch (e) {
|
|
ok = false;
|
|
print("Failure on $node: $e");
|
|
try {
|
|
print(node.parent?.location);
|
|
} catch (e) {}
|
|
}
|
|
}
|
|
}
|