Paul Berry
a0f467f0e9
The analyzer already has an enum with the same name, but a slightly different declaration. (The analyzer's enum declares only severities of `error`, `warning`, and `info`, whereas the CFE's enum also declares severities of `context`, `ignored`, and `internalProblem`). I'm currently embarking on an arc of work that I hope will eventually culminate in unifying the analyzer and CFE diagnostic message representations (and their severities) into a single set of classes. Until that unification is complete, both representations will have to co-exist in the `_fe_analyzer_shared` package. To reduce confusion during that time period, I would like the classes to have distinct names. Since the analyzer's `Severity` enum is exposed through the analyzer public API, analyzer clients may depend on the name. So it makes sense to rename the CFE's `Severity` enum. Tested: standard trybots Change-Id: I95622950f49b1754267e441e4636e046045629bb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442102 Reviewed-by: Liam Appelbe <liama@google.com> Reviewed-by: Mayank Patke <fishythefish@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Ömer Ağacan <omersa@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
25 lines
968 B
Dart
25 lines
968 B
Dart
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:_fe_analyzer_shared/src/messages/severity.dart'
|
|
show CfeSeverity;
|
|
|
|
/// Test that Severity has the expected indexes. Note that this is important
|
|
/// and shouldn't be changed lightly because we use it in serialization!
|
|
void main() {
|
|
expect(CfeSeverity.context.index, 0);
|
|
expect(CfeSeverity.error.index, 1);
|
|
expect(CfeSeverity.internalProblem.index, 3);
|
|
expect(CfeSeverity.warning.index, 4);
|
|
|
|
expect(CfeSeverity.values[0], CfeSeverity.context);
|
|
expect(CfeSeverity.values[1], CfeSeverity.error);
|
|
expect(CfeSeverity.values[3], CfeSeverity.internalProblem);
|
|
expect(CfeSeverity.values[4], CfeSeverity.warning);
|
|
}
|
|
|
|
void expect(Object actual, Object expect) {
|
|
if (expect != actual) throw "Expected $expect got $actual";
|
|
}
|