d579b03f71
Changes the `front_end` and `_fe_analyzer_shared` code that reports the following diagnostics so that it uses `withArguments` rather than `withArgumentsOld`: - `expectedButGot` - `expectedButGot2` - `expectedAfterButGot` - `expectedToken` - `unmatchedToken` - `constFieldWithoutInitializer` - `finalFieldWithoutInitializer` - `superclassHasNoMethod` - `unavailableDartLibrary` - `unsupportedPlatformDartLibraryImport` These messages required special care because they are translated into analyzer diagnostics by the analyzer method `FastaErrorReporter.reportByCode`, and the logic to do the translation depends on the exact parameter names used by the messages. For some of the messages I've clarified the parameter names and updated `FastaErrorReporter.reportByCode` accordingly. For others, I left the parameter names as is. Change-Id: I6a6a696481c75f4cbb198d1e012aa1ca4294ed61 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/476323 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
51 lines
1.9 KiB
Plaintext
51 lines
1.9 KiB
Plaintext
Problems reported:
|
|
|
|
parser/patterns/skipOuterPattern_eof:2:3: Expected ';' after this.
|
|
int var = 0;
|
|
^^^
|
|
|
|
parser/patterns/skipOuterPattern_eof:2:11: Expected an identifier, but got '='.
|
|
int var = 0;
|
|
^
|
|
|
|
parser/patterns/skipOuterPattern_eof:1:8: Can't find '}' to match '{'.
|
|
main() {
|
|
^
|
|
|
|
beginCompilationUnit(main)
|
|
beginMetadataStar(main)
|
|
endMetadataStar(0)
|
|
beginTopLevelMember(main)
|
|
beginTopLevelMethod(UnmatchedToken({), null, null)
|
|
handleNoType(UnmatchedToken({))
|
|
handleIdentifier(main, topLevelFunctionDeclaration)
|
|
handleNoTypeVariables(()
|
|
beginFormalParameters((, MemberKind.TopLevelMethod)
|
|
endFormalParameters(0, (, ), MemberKind.TopLevelMethod)
|
|
handleAsyncModifier(null, null)
|
|
beginBlockFunctionBody({)
|
|
handleIdentifier(int, expression)
|
|
handleNoTypeArguments(var)
|
|
handleNoArguments(var)
|
|
handleSend(int, int)
|
|
handleRecoverableError(Message[Template(ExpectedAfterButGot), Expected ';' after this., null, {expected: ;}], int, int)
|
|
handleExpressionStatement(int, ;)
|
|
beginMetadataStar(var)
|
|
endMetadataStar(0)
|
|
handleNoType(var)
|
|
beginVariablesDeclaration(=, null, var)
|
|
handleRecoverableError(Message[Template(ExpectedIdentifier), Expected an identifier, but got '='., Try inserting an identifier before '='., {lexeme: =}], =, =)
|
|
handleIdentifier(, localVariableDeclaration)
|
|
beginInitializedIdentifier()
|
|
beginVariableInitializer(=)
|
|
handleLiteralInt(0)
|
|
endVariableInitializer(=)
|
|
endInitializedIdentifier()
|
|
endVariablesDeclaration(1, ;)
|
|
endBlockFunctionBody(2, {, })
|
|
endTopLevelMethod(main, null, })
|
|
endTopLevelDeclaration(})
|
|
handleErrorToken(UnmatchedToken({))
|
|
handleRecoverableError(Message[Template(UnmatchedToken), Can't find '}' to match '{'., null, {expected: }, lexeme: {}], UnmatchedToken({), UnmatchedToken({))
|
|
endCompilationUnit(1, )
|