afcfbbeba8
(Part of https://github.com/dart-lang/sdk/issues/63288) This change migrates the packages owned by the developer experience team to use the new constructor declaration syntax, described in https://github.com/dart-lang/language/blob/main/accepted/future-releases/primary-constructors/feature-specification.md#abbreviations-of-in-body-constructor-declarations. This change was performed in an automated fashion, by (a) bumping the packages' SDK constraints to `3.13.0-0`, (b) enabling the lints `unnecessary_type_name_in_constructor` and `unnecessary_const_in_enum_constructor`, (c) fixing the resulting lint failures using `dart fix`, and then (d) reformatting the affected files. To ease code review, I've reverted unrelated formatting changes. Since this change requires bumping SDK constaints to `3.13.0-0`, it was only performed on packages that are *not* published on pub. (Packages that *are* published on pub should remain on lower language versions until at least after the stable version of 3.13 is released, so that we don't block users on the stable channel from receiving updates to those packages.) Change-Id: Ibb4daebafd239da58251e838ea6a3f336a6a6964 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505046 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>
82 lines
3.0 KiB
Dart
82 lines
3.0 KiB
Dart
// Copyright (c) 2021, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:io';
|
|
|
|
import 'package:analyzer/dart/analysis/analysis_context_collection.dart';
|
|
import 'package:analyzer/dart/analysis/results.dart';
|
|
import 'package:analyzer/dart/ast/ast.dart';
|
|
import 'package:analyzer/file_system/physical_file_system.dart';
|
|
import 'package:analyzer_testing/package_root.dart';
|
|
|
|
class BulkFixDetails {
|
|
Future<Map<String, CorrectionDetails>> collectOverrides() async {
|
|
var overrideDetails = <String, CorrectionDetails>{};
|
|
|
|
var pkgRootPath = PhysicalResourceProvider.INSTANCE.pathContext.normalize(
|
|
packageRoot,
|
|
);
|
|
var directory = Directory(
|
|
'$pkgRootPath/analysis_server/lib/src/services/correction/dart',
|
|
);
|
|
var collection = AnalysisContextCollection(
|
|
includedPaths: [directory.absolute.path],
|
|
resourceProvider: PhysicalResourceProvider.INSTANCE,
|
|
);
|
|
var context = collection.contexts[0];
|
|
|
|
for (var file in directory.listSync()) {
|
|
var resolvedFile =
|
|
await context.currentSession.getResolvedUnit(file.absolute.path)
|
|
as ResolvedUnitResult;
|
|
for (var classDecl
|
|
in resolvedFile.unit.declarations.whereType<ClassDeclaration>()) {
|
|
var classElement = classDecl.declaredFragment?.element;
|
|
if (classElement != null &&
|
|
classElement.allSupertypes.any(
|
|
(element) => element.element.name == 'CorrectionProducer',
|
|
)) {
|
|
var correctionName = classDecl.namePart.typeName.lexeme;
|
|
|
|
for (var method
|
|
in classDecl.body.members.whereType<MethodDeclaration>()) {
|
|
if (method.name.lexeme == 'canBeAppliedInBulk') {
|
|
var hasComment =
|
|
method.returnType?.beginToken.precedingComments != null;
|
|
|
|
var body = method.body;
|
|
if (body is BlockFunctionBody) {
|
|
var last = body.block.statements.last;
|
|
if (last is ReturnStatement) {
|
|
var canBeBulkApplied =
|
|
(last.expression as BooleanLiteral).value;
|
|
overrideDetails[correctionName] = CorrectionDetails(
|
|
canBeBulkApplied: canBeBulkApplied,
|
|
hasComment: hasComment,
|
|
);
|
|
}
|
|
} else if (body is ExpressionFunctionBody) {
|
|
var expression = body.expression;
|
|
var canBeBulkApplied = (expression as BooleanLiteral).value;
|
|
overrideDetails[correctionName] = CorrectionDetails(
|
|
canBeBulkApplied: canBeBulkApplied,
|
|
hasComment: hasComment,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return overrideDetails;
|
|
}
|
|
}
|
|
|
|
class CorrectionDetails {
|
|
bool canBeBulkApplied;
|
|
bool hasComment;
|
|
|
|
new({required this.canBeBulkApplied, required this.hasComment});
|
|
}
|